LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: add keyword for devicetree overlay notifiers
@ 2018-04-28  0:50 frowand.list
  2018-04-28  0:57 ` Frank Rowand
  0 siblings, 1 reply; 3+ messages in thread
From: frowand.list @ 2018-04-28  0:50 UTC (permalink / raw)
  To: Rob Herring, pantelis.antoniou, Pantelis Antoniou
  Cc: devicetree, linux-kernel, Jan Kiszka

From: Frank Rowand <frank.rowand@sony.com>

From: Frank Rowand <frowand.list@gmail.com>

Devicetree overlay notifiers have a chance to potentially get
pointers into the overlay unflattened devicetree and overlay FDT.
The only protection against these pointers being accessed after
the underlying data has been released by kfree() is by source
code review of patches.  Add a keyword line to the devicetree
overlay maintainers entry to try to catch overlay notifier
related patches.

The keyword line is added to the devicetree overlay entry instead
of the devicetree entry so that not all maintainers will receive
the additional review traffic.  Add Frank Rowand (already a
maintainer in the devicetree entry) so that he will receive
the additional review traffic.

Signed-off-by: Frank Rowand <frowand.list@gmail.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 92be777d060a..aca3956694f8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10422,12 +10422,14 @@ F:	drivers/infiniband/ulp/opa_vnic
 
 OPEN FIRMWARE AND DEVICE TREE OVERLAYS
 M:	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
+M:	Frank Rowand <frowand.list@gmail.com>
 L:	devicetree@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/dynamic-resolution-notes.txt
 F:	Documentation/devicetree/overlay-notes.txt
 F:	drivers/of/overlay.c
 F:	drivers/of/resolver.c
+K:	of_overlay_notifier_
 
 OPEN FIRMWARE AND FLATTENED DEVICE TREE
 M:	Rob Herring <robh+dt@kernel.org>
-- 
Frank Rowand <frank.rowand@sony.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MAINTAINERS: add keyword for devicetree overlay notifiers
  2018-04-28  0:50 [PATCH] MAINTAINERS: add keyword for devicetree overlay notifiers frowand.list
@ 2018-04-28  0:57 ` Frank Rowand
  2018-04-28  1:13   ` Frank Rowand
  0 siblings, 1 reply; 3+ messages in thread
From: Frank Rowand @ 2018-04-28  0:57 UTC (permalink / raw)
  To: Rob Herring, pantelis.antoniou, Pantelis Antoniou
  Cc: devicetree, linux-kernel, Jan Kiszka

Hi Rob,

I'm not sure how the extra "From:" of sony.com got into
this email.  I'll have to dig into my scripts and/or
git configs to figure that out.  The real "From:" is
the gmail.com one.

-Frank

On 04/27/18 17:50, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
> 
> From: Frank Rowand <frowand.list@gmail.com>
> 
> Devicetree overlay notifiers have a chance to potentially get
> pointers into the overlay unflattened devicetree and overlay FDT.
> The only protection against these pointers being accessed after
> the underlying data has been released by kfree() is by source
> code review of patches.  Add a keyword line to the devicetree
> overlay maintainers entry to try to catch overlay notifier
> related patches.
> 
> The keyword line is added to the devicetree overlay entry instead
> of the devicetree entry so that not all maintainers will receive
> the additional review traffic.  Add Frank Rowand (already a
> maintainer in the devicetree entry) so that he will receive
> the additional review traffic.
> 
> Signed-off-by: Frank Rowand <frowand.list@gmail.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92be777d060a..aca3956694f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10422,12 +10422,14 @@ F:	drivers/infiniband/ulp/opa_vnic
>  
>  OPEN FIRMWARE AND DEVICE TREE OVERLAYS
>  M:	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> +M:	Frank Rowand <frowand.list@gmail.com>
>  L:	devicetree@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/devicetree/dynamic-resolution-notes.txt
>  F:	Documentation/devicetree/overlay-notes.txt
>  F:	drivers/of/overlay.c
>  F:	drivers/of/resolver.c
> +K:	of_overlay_notifier_
>  
>  OPEN FIRMWARE AND FLATTENED DEVICE TREE
>  M:	Rob Herring <robh+dt@kernel.org>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MAINTAINERS: add keyword for devicetree overlay notifiers
  2018-04-28  0:57 ` Frank Rowand
@ 2018-04-28  1:13   ` Frank Rowand
  0 siblings, 0 replies; 3+ messages in thread
From: Frank Rowand @ 2018-04-28  1:13 UTC (permalink / raw)
  To: Rob Herring, pantelis.antoniou, Pantelis Antoniou
  Cc: devicetree, linux-kernel, Jan Kiszka

Hi Rob,

On 04/27/18 17:57, Frank Rowand wrote:
> Hi Rob,
> 
> I'm not sure how the extra "From:" of sony.com got into
> this email.  I'll have to dig into my scripts and/or
> git configs to figure that out.  The real "From:" is
> the gmail.com one.

Darn it...

The real "From: is the sony.com one.  The wrong "From" is the gmail one.

-Frank

> 
> -Frank
> 
> On 04/27/18 17:50, frowand.list@gmail.com wrote:
>> From: Frank Rowand <frank.rowand@sony.com>
>>
>> From: Frank Rowand <frowand.list@gmail.com>
>>
>> Devicetree overlay notifiers have a chance to potentially get
>> pointers into the overlay unflattened devicetree and overlay FDT.
>> The only protection against these pointers being accessed after
>> the underlying data has been released by kfree() is by source
>> code review of patches.  Add a keyword line to the devicetree
>> overlay maintainers entry to try to catch overlay notifier
>> related patches.
>>
>> The keyword line is added to the devicetree overlay entry instead
>> of the devicetree entry so that not all maintainers will receive
>> the additional review traffic.  Add Frank Rowand (already a
>> maintainer in the devicetree entry) so that he will receive
>> the additional review traffic.
>>
>> Signed-off-by: Frank Rowand <frowand.list@gmail.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 92be777d060a..aca3956694f8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -10422,12 +10422,14 @@ F:	drivers/infiniband/ulp/opa_vnic
>>  
>>  OPEN FIRMWARE AND DEVICE TREE OVERLAYS
>>  M:	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>> +M:	Frank Rowand <frowand.list@gmail.com>
>>  L:	devicetree@vger.kernel.org
>>  S:	Maintained
>>  F:	Documentation/devicetree/dynamic-resolution-notes.txt
>>  F:	Documentation/devicetree/overlay-notes.txt
>>  F:	drivers/of/overlay.c
>>  F:	drivers/of/resolver.c
>> +K:	of_overlay_notifier_
>>  
>>  OPEN FIRMWARE AND FLATTENED DEVICE TREE
>>  M:	Rob Herring <robh+dt@kernel.org>
>>
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-28  1:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-28  0:50 [PATCH] MAINTAINERS: add keyword for devicetree overlay notifiers frowand.list
2018-04-28  0:57 ` Frank Rowand
2018-04-28  1:13   ` Frank Rowand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).