LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: naoya.horiguchi@nec.com, mhocko@suse.com, minchan@kernel.org,
	cgoldswo@codeaurora.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/memory_hotplug: use helper zone_is_zone_device() to simplify the code
Date: Mon, 23 Aug 2021 14:14:19 +0200	[thread overview]
Message-ID: <31b111bd-82e6-7cb1-3bd4-590ff2963a83@redhat.com> (raw)
In-Reply-To: <20210821094246.10149-2-linmiaohe@huawei.com>

On 21.08.21 11:42, Miaohe Lin wrote:
> Use helper zone_is_zone_device() to simplify the code and remove some
> explicit CONFIG_ZONE_DEVICE codes.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/memory_hotplug.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index b287ff3d7229..d986d3791986 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -477,15 +477,13 @@ void __ref remove_pfn_range_from_zone(struct zone *zone,
>   				 sizeof(struct page) * cur_nr_pages);
>   	}
>   
> -#ifdef CONFIG_ZONE_DEVICE
>   	/*
>   	 * Zone shrinking code cannot properly deal with ZONE_DEVICE. So
>   	 * we will not try to shrink the zones - which is okay as
>   	 * set_zone_contiguous() cannot deal with ZONE_DEVICE either way.
>   	 */
> -	if (zone_idx(zone) == ZONE_DEVICE)
> +	if (zone_is_zone_device(zone))
>   		return;
> -#endif
>   
>   	clear_zone_contiguous(zone);
>   
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb


  parent reply	other threads:[~2021-08-23 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21  9:42 [PATCH 0/3] Cleanup and fixups for memory hotplug Miaohe Lin
2021-08-21  9:42 ` [PATCH 1/3] mm/memory_hotplug: use helper zone_is_zone_device() to simplify the code Miaohe Lin
2021-08-23  8:20   ` HORIGUCHI NAOYA(堀口 直也)
2021-08-23  9:11   ` Oscar Salvador
2021-08-23 12:14   ` David Hildenbrand [this message]
2021-08-21  9:42 ` [PATCH 2/3] mm/memory_hotplug: fix potential permanent lru cache disable Miaohe Lin
2021-08-23  8:21   ` HORIGUCHI NAOYA(堀口 直也)
2021-08-23  9:15   ` Oscar Salvador
2021-08-23 11:13     ` Miaohe Lin
2021-08-23 12:15   ` David Hildenbrand
2021-08-21  9:42 ` [PATCH 3/3] mm/memory_hotplug: make HWPoisoned dirty swapcache pages unmovable Miaohe Lin
2021-08-23  8:26   ` HORIGUCHI NAOYA(堀口 直也)
2021-08-23  9:14     ` Miaohe Lin
2021-11-04 22:07       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31b111bd-82e6-7cb1-3bd4-590ff2963a83@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgoldswo@codeaurora.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=naoya.horiguchi@nec.com \
    --subject='Re: [PATCH 1/3] mm/memory_hotplug: use helper zone_is_zone_device() to simplify the code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).