LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Natalie Protasevich" <protasnb@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: lenb@kernel.org, "Andi Kleen" <ak@suse.de>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: FW: [PATCH] i386: irq: Kill IRQ compression
Date: Fri, 16 Feb 2007 02:41:51 -0700	[thread overview]
Message-ID: <32209efe0702160141k32f16923qdf93abdf5d473886@mail.gmail.com> (raw)
In-Reply-To: <19D0D50E9B1D0A40A9F0323DBFA04ACC023B0E21@USRV-EXCH4.na.uis.unisys.com>

l> From: Eric W. Biederman [mailto:ebiederm@xmission.com]
> Sent: Friday, February 16, 2007 2:22 AM
> To: Protasevich, Natalie
> Cc: Len Brown; Andi Kleen; lkml - Kernel Mailing List;
> linux-acpi@vger.kernel.org
> Subject: Re: [PATCH] i386: irq: Kill IRQ compression
>
> ebiederm@xmission.com (Eric W. Biederman) writes:
>
> > By itself I don't think we are going to observe any real problems
> > with this patch.
> >
> > However if we are going to be serious about this we need to do a
> > few more things.
> >
> > - kill ioapic_renumber_irq.
>
> Looking closer ioapic_renumber_irq does not appear to be an irq
> compress thing.  Rather it appears to be a work around for a weird
> acpi implementation where gsi 0 - 15 are not the ISA irqs.
>
> Natalie is my reading of the code there correct?

Yes, indeed.

>
> If so keeping ioapic_renumber_irq makes sense.  Although giving
> it a name that suggests it is working around weird implementation
> details would be good.

Sure. I think it was originally renumber_gsi something, but Len had to
change it so it sounds more explicit as familiar "IRQ".
--Natalie
>
> Eric
>

       reply	other threads:[~2007-02-16  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <19D0D50E9B1D0A40A9F0323DBFA04ACC023B0E21@USRV-EXCH4.na.uis.unisys.com>
2007-02-16  9:41 ` Natalie Protasevich [this message]
     [not found] <19D0D50E9B1D0A40A9F0323DBFA04ACC023B0E20@USRV-EXCH4.na.uis.unisys.com>
2007-02-16  9:11 ` Natalie Protasevich
2007-02-16  9:27   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32209efe0702160141k32f16923qdf93abdf5d473886@mail.gmail.com \
    --to=protasnb@gmail.com \
    --cc=ak@suse.de \
    --cc=ebiederm@xmission.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: FW: [PATCH] i386: irq: Kill IRQ compression' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).