LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: dhowells@redhat.com, Matthew Wilcox <willy@infradead.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Christoph Hellwig <hch@infradead.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Vlastimil Babka <vbabka@suse.cz>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Jeff Layton <jlayton@kernel.org>,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Folios: Can we resolve this please?
Date: Tue, 31 Aug 2021 23:15:47 +0100	[thread overview]
Message-ID: <3285174.1630448147@warthog.procyon.org.uk> (raw)

Hi Linus, Andrew, Johannes,

Can we come to a quick resolution on folios?  I'd really like this to be
solved in this merge window if at all possible as I (and others) have stuff
that will depend on and will conflict with Willy's folio work.  It would be
great to get this sorted one way or another.

As I see it, there are three issues, I think, and I think they kind of go like
this:

 (1) Johannes wants to get away from pages being used as the unit of memory
     currency and thinks that folios aren't helpful in this regard[1].  There
     seems to be some disagreement about where this is heading.

 (2) Linus isn't entirely keen on Willy's approach[2], with a bottom up
     approach hiding the page objects behind a new type from the pov of the
     filesystem, but would rather see the page struct stay the main API type
     and the changes be hidden transparently inside of that.

     I think from what Linus said, he may be in favour (if that's not too
     strong a word) of using a new type to make sure we don't miss the
     necessary changes[3].

 (3) Linus isn't in favour of the name 'folio' for the new type[2].  Various
     names have been bandied around and Linus seems okay with "pageset"[4],
     though it's already in minor(-ish) use[5][6].  Willy has an alternate
     patchset with "folio" changed to "pageset"[7].

With regard to (1), I think the folio concept could be used in future to hide
at least some of the paginess from filesystems.

With regard to (2), I think a top-down approach won't work until and unless we
wrap all accesses to struct page by filesystems (and device drivers) in
wrapper functions - we need to stop filesystems fiddling with page internals
because what page internals may mean may change.

With regard to (3), I'm personally fine with the name "folio", as are other
people[8][9][10][11], but I could also live with a conversion to "pageset".

Is it possible to take the folios patchset as-is and just live with the name,
or just take Willy's rename-job (although it hasn't had linux-next soak time
yet)?  Or is the approach fundamentally flawed and in need of redoing?

Thanks,
David

Link: https://lore.kernel.org/r/YSQSkSOWtJCE4g8p@cmpxchg.org/ [1]
Link: https://lore.kernel.org/r/CAHk-=wjD8i2zJVQ9SfF2t=_0Fkgy-i5Z=mQjCw36AHvbBTGXyg@mail.gmail.com/ [2]
Link: https://lore.kernel.org/r/CAHk-=wgkA=RKJ-vke0EoOUK19Hv1f=47Da6pWAWQZPhjKD6WOg@mail.gmail.com/ [3]
Link: https://lore.kernel.org/r/CAHk-=wiZ=wwa4oAA0y=Kztafgp0n+BDTEV6ybLoH2nvLBeJBLA@mail.gmail.com/ [4]
Link: https://lore.kernel.org/r/CAHk-=whd8ugrzMS-3bupkPQz9VS+dWHPpsVssrDfuFgfff+n5A@mail.gmail.com/ [5]
Link: https://lore.kernel.org/r/CAHk-=wgwRW1_o6iBOxtSE+vm7uiSr98wkTLbCze9-7wW0ZhOLQ@mail.gmail.com/ [6]
Link: https://lore.kernel.org/r/YSmtjVTqR9%2F4W1aq@casper.infradead.org/ [7]
Link: https://lore.kernel.org/r/YSXkDFNkgAhQGB0E@infradead.org/ [8]
Link: https://lore.kernel.org/r/92cbfb8f-7418-15d5-c469-d7861e860589@rasmusvillemoes.dk/ [9]
Link: https://lore.kernel.org/r/cf30c0e8d1eecf08b2651c5984ff09539e2266f9.camel@kernel.org/ [10]
Link: https://lore.kernel.org/r/20210826005914.GG12597@magnolia/ [11]


             reply	other threads:[~2021-08-31 22:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 22:15 David Howells [this message]
2021-09-01 10:18 ` David Hildenbrand
2021-09-01 10:18 ` David Hildenbrand
2021-09-01 11:42 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3285174.1630448147@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=djwong@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --subject='Re: Folios: Can we resolve this please?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).