From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB12C4338F for ; Thu, 19 Aug 2021 01:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29E2860EBD for ; Thu, 19 Aug 2021 01:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235597AbhHSB4q (ORCPT ); Wed, 18 Aug 2021 21:56:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235258AbhHSB4p (ORCPT ); Wed, 18 Aug 2021 21:56:45 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB4FC061764 for ; Wed, 18 Aug 2021 18:56:09 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id qk33so9182156ejc.12 for ; Wed, 18 Aug 2021 18:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hpN+seMId1R48ghtCTKV+9iaLm5LmXQaGNgNqrThWN8=; b=ZirmNlnoFyDaRJW/IgiEe1WWOU5kuNmt8Ayh4dUZjeSupbjfmZR8aS+MQYk23OTKqi Qf8pf80f+9zP1glKgRg/9On65qMn9u7WWcY/L/VenACALBCPI24tXhBP3PeGA2vPPY2f AFNbV3afViLMu5bdogbpyoLBYHy+w1V42GQaqD/gvw1Nf0pVmgmP31EOvxcpcNE1tZ/1 DHPj7vwdvnrIDpEhMp0iFCGgUKpg9Ko5X7pxzOrVtXSebBZVcaTFIUhng860qyt5Y0ZO smfePlrkj7TlsfbQx+ynM3vVncildEwWQeXB1Ldl0/MmPByLu+AA1s/Sr0egcbt6c8eW X7bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hpN+seMId1R48ghtCTKV+9iaLm5LmXQaGNgNqrThWN8=; b=RUXO3ajdhSX2x3vWzMbvdt6FUbh9qUGA2CTZl58iAe5sD0K53l5q9m6utItQwxykWE chmLxpHC4WTX02MV/xuC8Omj6LTYm111SkeETFj2uQYs5VgtffrnOuQ89wT9J0Ac0t9e RbT5MfaSNGPhMeNlwKL+YbZpPG2NHrN6aROnEP6R5MmN/AvY0orcIbckLXu8nKbPMkci o4tef658a8IIn3i4uqsOCoqVzmXS+5qcmWlOHvPIZjBMQhZZM1TkL1YEB2tBoO41ktz3 19A0JrG43Wt6e65rIQ/Y0FdqPlVDR7hh4AByybrC362dWKLzp0JcmWAAsL6Z26F9kiV0 DJ4g== X-Gm-Message-State: AOAM530vUBxCE9ZHPLiJ+GNx9nHqr7Vcxzb14rm6TCYsTyzEyz9pTrdG kwL8g3poSF+sgtnvaFcbmTM= X-Google-Smtp-Source: ABdhPJzT8AUaQY0sG1OzCxvz9x77+muyQv0xPyREbtofc0+WY7AJchEmYqkU9NT/UvwhyeIGAn+/Mw== X-Received: by 2002:a17:906:1ec9:: with SMTP id m9mr13319242ejj.115.1629338168041; Wed, 18 Aug 2021 18:56:08 -0700 (PDT) Received: from localhost.localdomain (host-79-22-109-211.retail.telecomitalia.it. [79.22.109.211]) by smtp.gmail.com with ESMTPSA id j13sm923368edr.89.2021.08.18.18.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 18:56:07 -0700 (PDT) From: "Fabio M. De Francesco" To: gregkh@linuxfoundation.org, Phillip Potter Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, martin@kaiser.cx, straube.linux@gmail.com, Larry.Finger@lwfinger.net Subject: Re: [PATCH 3/6] staging: r8188eu: remove txrpt_ccx_sw_88e and txrpt_ccx_qtime_88e macros Date: Thu, 19 Aug 2021 03:56:06 +0200 Message-ID: <3294226.eXTACl5KOM@localhost.localdomain> In-Reply-To: <20210818234253.208271-4-phil@philpotter.co.uk> References: <20210818234253.208271-1-phil@philpotter.co.uk> <20210818234253.208271-4-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 19, 2021 1:42:50 AM CEST Phillip Potter wrote: > Remove txrpt_ccx_sw_88e and txrpt_ccx_qtime_88e macro definitions from > include/rtl8188e_xmit.h, as these were only called from the now removed > dump_txrpt_ccx_88e function, which was itself not called from anywhere > anyway. > > Signed-off-by: Phillip Potter > --- > drivers/staging/r8188eu/include/rtl8188e_xmit.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h > index 20b55e3850ba..e7eb19c4ee9d 100644 > --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h > +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h > @@ -133,10 +133,6 @@ struct txrpt_ccx_88e { > u8 sw0; > }; > > -#define txrpt_ccx_sw_88e(txrpt_ccx) ((txrpt_ccx)->sw0 + ((txrpt_ccx)->sw1<<8)) > -#define txrpt_ccx_qtime_88e(txrpt_ccx) \ > - ((txrpt_ccx)->ccx_qtime0+((txrpt_ccx)->ccx_qtime1<<8)) > - > void rtl8188e_fill_fake_txdesc(struct adapter *padapter, u8 *pDesc, > u32 BufferLen, u8 IsPsPoll, u8 IsBTQosNull); > s32 rtl8188eu_init_xmit_priv(struct adapter *padapter); > -- > 2.31.1 > At a quick look it looks good. Built with "make C=2 -j8 drivers/staging/r8188eu/ W=1" on x86-64, it does not introduce any errors or warnings, so... Acked-by: Fabio M. De Francesco Thanks, Fabio