LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	linux@arm.linux.org.uk, vinod.koul@intel.com,
	linux-mmc@vger.kernel.org, nsekhar@ti.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, khilman@deeprootsystems.com,
	Tony Lindgren <tony@atomide.com>, Mark Brown <broonie@kernel.org>,
	chris@printf.net, dmaengine@vger.kernel.org,
	ulf.hansson@linaro.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition
Date: Thu, 27 Nov 2014 15:50:46 +0100	[thread overview]
Message-ID: <3300340.ou8f7H2hIc@wuerfel> (raw)
In-Reply-To: <547733E3.3020408@ti.com>

On Thursday 27 November 2014 16:23:31 Peter Ujfalusi wrote:
> This will only work in case of legacy boot. When booting with DT we do not
> have pdata and after this patch in dt boot we are not going to be able to get
> the DMA resources either.

No, when booting with DT, the filter_fn and data are not used at all,
we get the dma channel by parsing the DT instead.

> I think if we want to do something like this, it has to be done within the
> dmaengine framework. The dma controller's of_dma_filter_info already have
> .filter_fn which could be used by the framework.

No, of_dma_filter_info/of_dma_simple_xlate was a mistake, we should never
have even introduced that. All drivers that rely on this can simply
provide their own xlate function that calls of_dma_get_slave_channel()
or one of the related functions.

edma is particularly trivial, it can just use of_dma_xlate_by_chan_id()
instead of of_dma_simple_xlate, as it looks up the channel by its number.

	Arnd

  reply	other threads:[~2014-11-27 14:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 10:41 [PATCH 0/3] ARM: edma: Correct header file usage Peter Ujfalusi
2014-11-27 10:41 ` [PATCH 1/3] ASoC: davinci-evm: Do not include edma headers Peter Ujfalusi
2014-11-27 10:58   ` Mark Brown
2014-11-27 10:41 ` [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition Peter Ujfalusi
2014-11-27 11:14   ` Arnd Bergmann
2014-11-27 14:23     ` Peter Ujfalusi
2014-11-27 14:50       ` Arnd Bergmann [this message]
2014-11-27 18:46         ` Peter Ujfalusi
2014-11-27 21:52           ` Arnd Bergmann
2014-11-28  7:16             ` Peter Ujfalusi
2014-11-28 10:51               ` Arnd Bergmann
2014-11-28 11:48                 ` Peter Ujfalusi
2014-11-28 10:57   ` Ulf Hansson
2014-11-27 10:41 ` [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file Peter Ujfalusi
2014-12-08 12:49   ` Vinod Koul
2014-12-08 13:16     ` Arnd Bergmann
2014-12-30 13:17     ` Peter Ujfalusi
2015-01-22  1:40   ` Olof Johansson
2015-01-26  7:29     ` Peter Ujfalusi
2015-01-14  9:51 ` [PATCH 0/3] ARM: edma: Correct header file usage Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3300340.ou8f7H2hIc@wuerfel \
    --to=arnd@arndb.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=chris@printf.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=khilman@deeprootsystems.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vinod.koul@intel.com \
    --subject='Re: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).