LKML Archive on
help / color / mirror / Atom feed
From: Dan Murphy <>
To: "Andrew F. Davis" <>, <>,
	<>, <>,
Cc: <>, <>,
Subject: Re: [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver
Date: Thu, 10 May 2018 10:16:19 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 05/10/2018 09:31 AM, Andrew F. Davis wrote:
> On 05/10/2018 09:04 AM, Dan Murphy wrote:
>>>> +static int lm3601x_remove(struct i2c_client *client)
>>>> +{
>>>> +	struct lm3601x_led *led = i2c_get_clientdata(client);
>>>> +
>>>> +	regmap_write(led->regmap, LM3601X_ENABLE_REG, 0);
>>>> +
>>> If probe doesn't enable this, remove shouldn't disable it. It can lead
>>> to odd cases if the driver is removed and added again.
>> I want to make sure the LED is off and in standby mode.  Maybe I will just set it to
>> the default value instead.
> Why? If you want to do this then implement PM controls and put it in
> standby mode there.

Implementing PM controls does not cause this line to be removed on a removal.

>>> Plus, removing the driver is not a command to disable the LED anyway.
>> True but you don't want to leave any LEDs in the on state without a driver to support it.
>> This could burn out the LED or the board if left on on max brightness
> I disagree, we should not try to decide what the user wants here. We
> should only do what we are instructed to do, which for remove() is to
> cleanup what probe has done so the driver can be removed w/o leaking
> memory or device state.

So your OK with a causing a burn out of the device or LED or draining the battery because the driver was
unloaded and there is not way to turn it off besides hard power cycling the device.  Because even a reboot
of the device will still leave the LED on throughout the boot until the driver is reloaded.

I will let the maintainer weigh in on this issue.

>> Dan

Dan Murphy

  reply	other threads:[~2018-05-10 15:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 12:27 [PATCH v4 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Dan Murphy
2018-05-10 12:27 ` [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver Dan Murphy
2018-05-10 13:44   ` Andrew F. Davis
2018-05-10 14:04     ` Dan Murphy
2018-05-10 14:31       ` Andrew F. Davis
2018-05-10 15:16         ` Dan Murphy [this message]
2018-05-10 18:39         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).