LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>,
	jaegeuk@kernel.org, yuchao0@huawei.com
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: Make sanity_check_curseg static
Date: Sat, 25 May 2019 21:56:42 +0800	[thread overview]
Message-ID: <33f73a57-285d-e37e-f911-6f3ad5cc6e01@kernel.org> (raw)
In-Reply-To: <20190525124809.17424-1-yuehaibing@huawei.com>

Haibing,

Thanks for the patch, there is a similar report from 0-day project, but I forget
to fix my v1 patch.

Anyway, I prefer to merge this into original patch which has not upstreamed yet. :)

Thanks,

On 2019-5-25 20:48, YueHaibing wrote:
> Fix sparse warning:
> 
> fs/f2fs/segment.c:4246:5: warning:
>  symbol 'sanity_check_curseg' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  fs/f2fs/segment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 1a83115284b9..51f57393ad5b 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -4243,7 +4243,7 @@ static int build_dirty_segmap(struct f2fs_sb_info *sbi)
>  	return init_victim_secmap(sbi);
>  }
>  
> -int sanity_check_curseg(struct f2fs_sb_info *sbi)
> +static int sanity_check_curseg(struct f2fs_sb_info *sbi)
>  {
>  	int i;
>  
> 

      reply	other threads:[~2019-05-25 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-25 12:48 [PATCH -next] f2fs: Make sanity_check_curseg static YueHaibing
2019-05-25 13:56 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33f73a57-285d-e37e-f911-6f3ad5cc6e01@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).