LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: use canonical compatible for touchpad/touchscreen
@ 2018-05-01 22:46 Dmitry Torokhov
  2018-05-02 16:53 ` Brian Norris
  2018-05-03 12:36 ` Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2018-05-01 22:46 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Mark Rutland, Matthias Kaehlcke, Brian Norris,
	Emil Renner Berthing, Jeffy Chen, devicetree, linux-rockchip,
	linux-kernel

"atmel,atmel_mxt_tp" and "atmel,atmel_mxt_ts" are ChromeOS inventions,
let's replace them with canonical compatible string "atmel,maxtouch".

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
index 191a6bcb17040..82179125bfb7c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
@@ -255,7 +255,7 @@ ap_i2c_dig: &i2c2 {
 
 &ap_i2c_tp {
 	trackpad@4a {
-		compatible = "atmel,atmel_mxt_tp";
+		compatible = "atmel,maxtouch";
 		reg = <0x4a>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&trackpad_int_l>;
@@ -271,7 +271,7 @@ ap_i2c_dig: &i2c2 {
 
 &ap_i2c_ts {
 	touchscreen@4b {
-		compatible = "atmel,atmel_mxt_ts";
+		compatible = "atmel,maxtouch";
 		reg = <0x4b>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&touch_int_l>;
-- 
2.17.0.441.gb46fe60e1d-goog


-- 
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: use canonical compatible for touchpad/touchscreen
  2018-05-01 22:46 [PATCH] arm64: dts: rockchip: use canonical compatible for touchpad/touchscreen Dmitry Torokhov
@ 2018-05-02 16:53 ` Brian Norris
  2018-05-03 12:36 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2018-05-02 16:53 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Matthias Kaehlcke,
	Emil Renner Berthing, Jeffy Chen, devicetree,
	open list:ARM/Rockchip SoC...,
	Linux Kernel

On Tue, May 1, 2018 at 3:46 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> "atmel,atmel_mxt_tp" and "atmel,atmel_mxt_ts" are ChromeOS inventions,
> let's replace them with canonical compatible string "atmel,maxtouch".
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

I guess the other IDs are in the driver just for non-DT usage? Anyway,
seems fine:

Reviewed-by: Brian Norris <briannorris@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: use canonical compatible for touchpad/touchscreen
  2018-05-01 22:46 [PATCH] arm64: dts: rockchip: use canonical compatible for touchpad/touchscreen Dmitry Torokhov
  2018-05-02 16:53 ` Brian Norris
@ 2018-05-03 12:36 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2018-05-03 12:36 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Rob Herring, Mark Rutland, Matthias Kaehlcke, Brian Norris,
	Emil Renner Berthing, Jeffy Chen, devicetree, linux-rockchip,
	linux-kernel

Am Mittwoch, 2. Mai 2018, 00:46:28 CEST schrieb Dmitry Torokhov:
> "atmel,atmel_mxt_tp" and "atmel,atmel_mxt_ts" are ChromeOS inventions,
> let's replace them with canonical compatible string "atmel,maxtouch".
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

I've amended the patch subject with a "on gru-kevin" and applied
it for 4.18 with Brian's Reviewed-by


Thanks
Heiko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-03 12:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 22:46 [PATCH] arm64: dts: rockchip: use canonical compatible for touchpad/touchscreen Dmitry Torokhov
2018-05-02 16:53 ` Brian Norris
2018-05-03 12:36 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).