LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: allen <allen.chen@ite.com.tw>
Cc: "Pi-Hsun Shih" <pihsun@chromium.org>,
	"David Airlie" <airlied@linux.ie>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Johan Hovold" <johan@kernel.org>,
	"Michal Vokáč" <michal.vokac@ysoft.com>,
	"Koen Kooi" <koen@dominion.thruhere.net>,
	"Vladimir Zapolskiy" <vz@mleia.com>,
	"Ben Whitten" <ben.whitten@gmail.com>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Guenter Roeck" <groeck@google.com>
Subject: Re: [PATCH 1/3] dt-bindings: Add binding for IT6505.
Date: Thu, 16 May 2019 14:58:08 +0200	[thread overview]
Message-ID: <3548960.TAD2hRMT5j@phil> (raw)
In-Reply-To: <1557301722-20827-2-git-send-email-allen.chen@ite.com.tw>

Hi Allen,

Am Mittwoch, 8. Mai 2019, 09:48:40 CEST schrieb allen:
> From: Allen Chen <allen.chen@ite.com.tw>
> 
> Add a DT binding documentation for IT6505.
> 
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> 
> ---
>  .../bindings/display/bridge/ite,it6505.txt         | 30 ++++++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.txt        |  1 +
>  2 files changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> new file mode 100644
> index 0000000..c3506ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> @@ -0,0 +1,30 @@
> +iTE it6505 DP bridge bindings
> +
> +Required properties:
> +        - compatible: "ite,it6505"
> +        - reg: i2c address of the bridge
> +        - ovdd-supply: I/O voltage
> +        - pwr18-supply: Core voltage
> +        - interrupts: interrupt specifier of INT pin
> +        - reset-gpios: gpio specifier of RESET pin
> +
> +Example:
> +	it6505dptx: it6505dptx@5c {
> +                compatible = "ite,it6505";
> +                status = "okay";

binding examples should not contain a "status" property.
Also as this is a board-specific i2c device, you shouldn't need
a status property in the board dts as well, as the default is
"okay" anyway.


> +                interrupt-parent = <&pio>;
> +                interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> +                reg = <0x5c>;
> +                pinctrl-names = "default";
> +                pinctrl-0 = <&it6505_pins>;
> +                ovdd-supply = <&mt6358_vsim1_reg>;
> +                pwr18-supply = <&it6505_pp18_reg>;
> +                reset-gpios = <&pio 179 1>;
> +                hpd-gpios = <&pio 9 0>;

This is missing from the property-list above.

> +                extcon = <&usbc_extcon>;

Not documented as well. Also this looks like it is the same functionality
as on rk3399-gru devices and circumvents the Type-C subsystem entirely
when handling the display-port alt-mode of the typec port.

At least on rk3399-gru the extcon from the chromeos-ec delivered the
status and allowed chaning settings of the hidden type-c controller
(fusb302 in that case). And while that works for ChromeOS devices this
makes it impossible for other devices to sanely use the chip as well.


The kernels type-c framework did develop a lot more in the meantime,
so this "hack" should probably not spread to more parts and instead should
use the type-c framework.

I pestered Guenter last year at ELCE about making cros-ec-pd a part of
the kernel's type-c subsystem, but I guess nobody had the time so far.

 

> +                port {
> +                        it6505_in: endpoint {
> +                                remote-endpoint = <&dpi_out>;

Ports usage also it not documented above. 


Heiko

> +                        };
> +                };
> +        };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 2c3fc51..c088646 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -184,6 +184,7 @@ iom	Iomega Corporation
>  isee	ISEE 2007 S.L.
>  isil	Intersil
>  issi	Integrated Silicon Solutions Inc.
> +ite	iTE Tech. Inc.
>  itead	ITEAD Intelligent Systems Co.Ltd
>  iwave  iWave Systems Technologies Pvt. Ltd.
>  jdi	Japan Display Inc.
> 





  reply	other threads:[~2019-05-16 12:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1557301722-20827-1-git-send-email-allen.chen@ite.com.tw>
2019-05-08  7:48 ` allen
2019-05-16 12:58   ` Heiko Stuebner [this message]
2019-05-08  7:48 ` [PATCH 2/3] drm/bridge: add it6505 driver allen
2019-05-08 21:07   ` Sam Ravnborg
2019-05-08  7:48 ` [PATCH 3/3] drm/bridge: it6505 driver add char device feature allen
2019-05-08  9:31 [PATCH 0/3] IT6505 cover letter allen
2019-05-08  9:31 ` [PATCH 1/3] dt-bindings: Add binding for IT6505 allen
2019-06-13 19:59   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3548960.TAD2hRMT5j@phil \
    --to=heiko@sntech.de \
    --cc=airlied@linux.ie \
    --cc=allen.chen@ite.com.tw \
    --cc=ben.whitten@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=groeck@google.com \
    --cc=johan@kernel.org \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.vokac@ysoft.com \
    --cc=pihsun@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=treding@nvidia.com \
    --cc=vz@mleia.com \
    --subject='Re: [PATCH 1/3] dt-bindings: Add binding for IT6505.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).