LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
To: "'minchan@kernel.org'" <minchan@kernel.org>,
"'Konstantin Khlebnikov'" <koct9i@gmail.com>,
"'Kirill A. Shutemov'" <kirill@shutemov.name>,
"'Andrew Morton'" <akpm@linux-foundation.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-mm@kvack.org'" <linux-mm@kvack.org>,
"'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>,
"'n-horiguchi@ah.jp.nec.com'" <n-horiguchi@ah.jp.nec.com>
Subject: [RFC] MADV_FREE doesn't work when doesn't have swap partition
Date: Thu, 18 Dec 2014 11:50:01 +0800 [thread overview]
Message-ID: <35FD53F367049845BC99AC72306C23D103EDAF89E14C@CNBJMBX05.corpusers.net> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D103E688B31408@CNBJMBX05.corpusers.net>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1041 bytes --]
I notice this commit:
mm: support madvise(MADV_FREE),
it can free clean anonymous pages directly,
doesn't need pageout to swap partition,
but I found it doesn't work on my platform,
which don't enable any swap partitions.
I make a change for this.
Just to explain my issue clearly,
Do we need some other checks to still scan anonymous pages even
Don't have swap partition but have clean anonymous pages?
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 5e8772b..8258f3a 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1941,7 +1941,7 @@ static void get_scan_count(struct lruvec *lruvec, int swappiness,
force_scan = true;
/* If we have no swap space, do not bother scanning anon pages. */
- if (!sc->may_swap || (get_nr_swap_pages() <= 0)) {
+ if (!sc->may_swap) {
scan_balance = SCAN_FILE;
goto out;
}
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2014-12-18 3:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 8:57 [RFC] mm:add KPF_ZERO_PAGE flag for /proc/kpageflags Wang, Yalin
2014-12-05 9:20 ` Konstantin Khlebnikov
2014-12-05 10:22 ` Wang, Yalin
2014-12-05 22:31 ` Andrew Morton
2014-12-08 2:00 ` [RFC V4] " Wang, Yalin
2014-12-08 11:46 ` Kirill A. Shutemov
2014-12-09 3:24 ` [RFC V5] " Wang, Yalin
2014-12-10 7:22 ` [RFC] mm:fix zero_page huge_zero_page rss/pss statistic Wang, Yalin
2014-12-10 11:05 ` Kirill A. Shutemov
2014-12-12 1:59 ` Wang, Yalin
2014-12-12 11:10 ` Kirill A. Shutemov
2014-12-10 17:06 ` [RFC V5] mm:add KPF_ZERO_PAGE flag for /proc/kpageflags Konstantin Khlebnikov
2014-12-12 3:30 ` [RFC] discard task stack pages instead of pageout into swap partition Wang, Yalin
2014-12-18 3:50 ` Wang, Yalin [this message]
2014-12-19 1:04 ` [RFC] MADV_FREE doesn't work when doesn't have " Minchan Kim
2014-12-19 6:54 ` Wang, Yalin
2014-12-22 10:30 ` Konstantin Khlebnikov
2014-12-26 11:56 ` [RFC] mm:change meminfo cached calculation Wang, Yalin
2015-01-07 0:43 ` Andrew Morton
2015-01-07 1:04 ` Hugh Dickins
2015-01-07 1:25 ` Andrew Morton
2015-01-07 2:03 ` Hugh Dickins
2015-01-11 8:23 ` Konstantin Khlebnikov
2014-12-05 10:21 ` [RFC V2] mm:add KPF_ZERO_PAGE flag for /proc/kpageflags Wang, Yalin
2014-12-05 11:05 ` Kirill A. Shutemov
2014-12-08 1:51 ` [RFC V3] " Wang, Yalin
2014-12-08 7:47 ` [PATCH] mm:add VM_BUG_ON() for page_mapcount() Wang, Yalin
2014-12-08 11:50 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35FD53F367049845BC99AC72306C23D103EDAF89E14C@CNBJMBX05.corpusers.net \
--to=yalin.wang@sonymobile.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=koct9i@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--subject='Re: [RFC] MADV_FREE doesn'\''t work when doesn'\''t have swap partition' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).