LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: build failure after merge of the pm tree
@ 2020-03-17  7:52 Stephen Rothwell
  2020-03-18 11:44 ` Stephen Rothwell
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2020-03-17  7:52 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Colin Ian King

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
failed like this:

fs/libfs.c: In function 'memory_read_from_io_buffer':
fs/libfs.c:829:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
  829 |  memcpy_fromio(to, from + pos, count);
      |  ^~~~~~~~~~~~~

Caused by commit

  08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")

Missing include of linux/io.h?

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2020-03-17  7:52 linux-next: build failure after merge of the pm tree Stephen Rothwell
@ 2020-03-18 11:44 ` Stephen Rothwell
  2020-03-18 11:52   ` Colin Ian King
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2020-03-18 11:44 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Colin Ian King

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi all,

On Tue, 17 Mar 2020 18:52:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
> failed like this:
> 
> fs/libfs.c: In function 'memory_read_from_io_buffer':
> fs/libfs.c:829:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
>   829 |  memcpy_fromio(to, from + pos, count);
>       |  ^~~~~~~~~~~~~
> 
> Caused by commit
> 
>   08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")
> 
> Missing include of linux/io.h?
> 
> I have reverted that commit for today.

This was fixed today (by including linux/ioh), but the latest update to
the pm tree has removed that include again.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2020-03-18 11:44 ` Stephen Rothwell
@ 2020-03-18 11:52   ` Colin Ian King
  2020-03-18 12:18     ` Stephen Rothwell
  0 siblings, 1 reply; 110+ messages in thread
From: Colin Ian King @ 2020-03-18 11:52 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1.1: Type: text/plain, Size: 903 bytes --]

On 18/03/2020 11:44, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 17 Mar 2020 18:52:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
>> failed like this:
>>
>> fs/libfs.c: In function 'memory_read_from_io_buffer':
>> fs/libfs.c:829:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
>>   829 |  memcpy_fromio(to, from + pos, count);
>>       |  ^~~~~~~~~~~~~
>>
>> Caused by commit
>>
>>   08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")
>>
>> Missing include of linux/io.h?
>>
>> I have reverted that commit for today.
> 
> This was fixed today (by including linux/ioh), but the latest update to
> the pm tree has removed that include again.
> 
Hopefully it won't be reverted from linux-next?

Colin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2020-03-18 11:52   ` Colin Ian King
@ 2020-03-18 12:18     ` Stephen Rothwell
  2020-03-19  5:42       ` Stephen Rothwell
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2020-03-18 12:18 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Rafael J. Wysocki, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi Colin,

On Wed, 18 Mar 2020 11:52:00 +0000 Colin Ian King <colin.king@canonical.com> wrote:
>
> > This was fixed today (by including linux/ioh), but the latest update to
> > the pm tree has removed that include again.
> >   
> Hopefully it won't be reverted from linux-next?

Linux-next just contains what its constituent trees contain each day ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2020-03-18 12:18     ` Stephen Rothwell
@ 2020-03-19  5:42       ` Stephen Rothwell
  2020-03-19  9:32         ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2020-03-19  5:42 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Colin Ian King, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi Stephen,

On Wed, 18 Mar 2020 23:18:37 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Colin,
> 
> On Wed, 18 Mar 2020 11:52:00 +0000 Colin Ian King <colin.king@canonical.com> wrote:
> >  
> > > This was fixed today (by including linux/ioh), but the latest update to
> > > the pm tree has removed that include again.
> > >     
> > Hopefully it won't be reverted from linux-next?  
> 
> Linux-next just contains what its constituent trees contain each day ...

I have had to revert commit

  08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")

again.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2020-03-19  5:42       ` Stephen Rothwell
@ 2020-03-19  9:32         ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2020-03-19  9:32 UTC (permalink / raw)
  To: Stephen Rothwell, Colin Ian King
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Thursday, March 19, 2020 6:42:59 AM CET Stephen Rothwell wrote:
> 
> --Sig_/Pgc07lYg4LlrlRQi0UWj2DK
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi Stephen,
> 
> On Wed, 18 Mar 2020 23:18:37 +1100 Stephen Rothwell <sfr@canb.auug.org.au> =
> wrote:
> >
> > Hi Colin,
> >=20
> > On Wed, 18 Mar 2020 11:52:00 +0000 Colin Ian King <colin.king@canonical.c=
> om> wrote:
> > > =20
> > > > This was fixed today (by including linux/ioh), but the latest update =
> to
> > > > the pm tree has removed that include again.
> > > >    =20
> > > Hopefully it won't be reverted from linux-next? =20
> >=20
> > Linux-next just contains what its constituent trees contain each day ...
> 
> I have had to revert commit
> 
>   08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")

Dropped from linux-pm now and sorry for the breakage.

Colin, please resend this one when all of the dependencies are in place in the
Linus' tree.

Thanks!




^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-06-29  0:23 Stephen Rothwell
@ 2022-06-29 13:01 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2022-06-29 13:01 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

On Wednesday, June 29, 2022 2:23:04 AM CEST Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> In file included from include/linux/list.h:5,
>                  from include/linux/kobject.h:19,
>                  from include/linux/of.h:17,
>                  from include/linux/irqdomain.h:35,
>                  from include/linux/acpi.h:13,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c: In function 'hisi_lpc_acpi_remove':
> drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                         ^~
> include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
>    18 |         void *__mptr = (void *)(ptr);                                   \
>       |                                 ^~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                         ^~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                         ^~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
>    20 |                       __same_type(*(ptr), void),                        \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
>   293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
>       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/uapi/linux/posix_types.h:5,
>                  from include/uapi/linux/types.h:14,
>                  from include/linux/types.h:6,
>                  from include/linux/kasan-checks.h:5,
>                  from include/asm-generic/rwonce.h:26,
>                  from ./arch/x86/include/generated/asm/rwonce.h:1,
>                  from include/linux/compiler.h:248,
>                  from include/linux/build_bug.h:5,
>                  from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
>    16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
>       |                                                          ^~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/kobject.h:19,
>                  from include/linux/of.h:17,
>                  from include/linux/irqdomain.h:35,
>                  from include/linux/acpi.h:13,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/list.h:665:16: note: in definition of macro 'list_entry_is_head'
>   665 |         (&pos->member == (head))
>       |                ^~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                         ^~
> include/linux/list.h:665:27: note: in definition of macro 'list_entry_is_head'
>   665 |         (&pos->member == (head))
>       |                           ^~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/list.h:5,
>                  from include/linux/kobject.h:19,
>                  from include/linux/of.h:17,
>                  from include/linux/irqdomain.h:35,
>                  from include/linux/acpi.h:13,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
>    18 |         void *__mptr = (void *)(ptr);                                   \
>       |                                 ^~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
>    20 |                       __same_type(*(ptr), void),                        \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
>   293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
>       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/uapi/linux/posix_types.h:5,
>                  from include/uapi/linux/types.h:14,
>                  from include/linux/types.h:6,
>                  from include/linux/kasan-checks.h:5,
>                  from include/asm-generic/rwonce.h:26,
>                  from ./arch/x86/include/generated/asm/rwonce.h:1,
>                  from include/linux/compiler.h:248,
>                  from include/linux/build_bug.h:5,
>                  from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |                                                     ^~~~
> include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
>    16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
>       |                                                          ^~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
>   488 |         list_for_each_entry(child, &adev->children, node)
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/list.h:5,
>                  from include/linux/kobject.h:19,
>                  from include/linux/of.h:17,
>                  from include/linux/irqdomain.h:35,
>                  from include/linux/acpi.h:13,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c: In function 'hisi_lpc_acpi_probe':
> drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                         ^~
> include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
>    18 |         void *__mptr = (void *)(ptr);                                   \
>       |                                 ^~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                         ^~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                         ^~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
>    20 |                       __same_type(*(ptr), void),                        \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
>   293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
>       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/uapi/linux/posix_types.h:5,
>                  from include/uapi/linux/types.h:14,
>                  from include/linux/types.h:6,
>                  from include/linux/kasan-checks.h:5,
>                  from include/asm-generic/rwonce.h:26,
>                  from ./arch/x86/include/generated/asm/rwonce.h:1,
>                  from include/linux/compiler.h:248,
>                  from include/linux/build_bug.h:5,
>                  from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
>    16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
>       |                                                          ^~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>   531 |         list_entry((ptr)->next, type, member)
>       |         ^~~~~~~~~~
> include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>   674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>       |                    ^~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/kobject.h:19,
>                  from include/linux/of.h:17,
>                  from include/linux/irqdomain.h:35,
>                  from include/linux/acpi.h:13,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/list.h:665:16: note: in definition of macro 'list_entry_is_head'
>   665 |         (&pos->member == (head))
>       |                ^~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                         ^~
> include/linux/list.h:665:27: note: in definition of macro 'list_entry_is_head'
>   665 |         (&pos->member == (head))
>       |                           ^~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/list.h:5,
>                  from include/linux/kobject.h:19,
>                  from include/linux/of.h:17,
>                  from include/linux/irqdomain.h:35,
>                  from include/linux/acpi.h:13,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
>    18 |         void *__mptr = (void *)(ptr);                                   \
>       |                                 ^~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
>    20 |                       __same_type(*(ptr), void),                        \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
>   293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
>       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>       |                                                        ^~~~
> include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |         ^~~~~~~~~~~~~
> include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>    19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                       ^~~~~~~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> In file included from include/uapi/linux/posix_types.h:5,
>                  from include/uapi/linux/types.h:14,
>                  from include/linux/types.h:6,
>                  from include/linux/kasan-checks.h:5,
>                  from include/asm-generic/rwonce.h:26,
>                  from ./arch/x86/include/generated/asm/rwonce.h:1,
>                  from include/linux/compiler.h:248,
>                  from include/linux/build_bug.h:5,
>                  from include/linux/bits.h:22,
>                  from include/linux/ioport.h:13,
>                  from include/linux/acpi.h:12,
>                  from drivers/bus/hisi_lpc.c:9:
> drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |                                                     ^~~~
> include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
>    16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
>       |                                                          ^~~~~~
> include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>   520 |         container_of(ptr, type, member)
>       |         ^~~~~~~~~~~~
> include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>   564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>       |         ^~~~~~~~~~
> include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>   676 |              pos = list_next_entry(pos, member))
>       |                    ^~~~~~~~~~~~~~~
> drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
>   509 |         list_for_each_entry(child, &adev->children, node) {
>       |         ^~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   647590eb6f34 ("ACPI: bus: Drop unused list heads from struct acpi_device")
> 
> I have used the pm tree from next-20220628 for today.

Thanks for the report, should be addressed now.

Cheers,
Rafael




^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2022-06-29  0:23 Stephen Rothwell
  2022-06-29 13:01 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2022-06-29  0:23 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 41043 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from include/linux/list.h:5,
                 from include/linux/kobject.h:19,
                 from include/linux/of.h:17,
                 from include/linux/irqdomain.h:35,
                 from include/linux/acpi.h:13,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c: In function 'hisi_lpc_acpi_remove':
drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                         ^~
include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
   18 |         void *__mptr = (void *)(ptr);                                   \
      |                                 ^~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                         ^~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                         ^~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
   20 |                       __same_type(*(ptr), void),                        \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
  293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
                 from include/uapi/linux/types.h:14,
                 from include/linux/types.h:6,
                 from include/linux/kasan-checks.h:5,
                 from include/asm-generic/rwonce.h:26,
                 from ./arch/x86/include/generated/asm/rwonce.h:1,
                 from include/linux/compiler.h:248,
                 from include/linux/build_bug.h:5,
                 from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
   16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
      |                                                          ^~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/kobject.h:19,
                 from include/linux/of.h:17,
                 from include/linux/irqdomain.h:35,
                 from include/linux/acpi.h:13,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/list.h:665:16: note: in definition of macro 'list_entry_is_head'
  665 |         (&pos->member == (head))
      |                ^~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:41: error: 'struct acpi_device' has no member named 'children'
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                         ^~
include/linux/list.h:665:27: note: in definition of macro 'list_entry_is_head'
  665 |         (&pos->member == (head))
      |                           ^~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/list.h:5,
                 from include/linux/kobject.h:19,
                 from include/linux/of.h:17,
                 from include/linux/irqdomain.h:35,
                 from include/linux/acpi.h:13,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
   18 |         void *__mptr = (void *)(ptr);                                   \
      |                                 ^~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
   20 |                       __same_type(*(ptr), void),                        \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
  293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
                 from include/uapi/linux/types.h:14,
                 from include/linux/types.h:6,
                 from include/linux/kasan-checks.h:5,
                 from include/asm-generic/rwonce.h:26,
                 from ./arch/x86/include/generated/asm/rwonce.h:1,
                 from include/linux/compiler.h:248,
                 from include/linux/build_bug.h:5,
                 from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:488:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  488 |         list_for_each_entry(child, &adev->children, node)
      |                                                     ^~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
   16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
      |                                                          ^~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:488:9: note: in expansion of macro 'list_for_each_entry'
  488 |         list_for_each_entry(child, &adev->children, node)
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/list.h:5,
                 from include/linux/kobject.h:19,
                 from include/linux/of.h:17,
                 from include/linux/irqdomain.h:35,
                 from include/linux/acpi.h:13,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c: In function 'hisi_lpc_acpi_probe':
drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                         ^~
include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
   18 |         void *__mptr = (void *)(ptr);                                   \
      |                                 ^~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                         ^~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                         ^~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
   20 |                       __same_type(*(ptr), void),                        \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
  293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
                 from include/uapi/linux/types.h:14,
                 from include/linux/types.h:6,
                 from include/linux/kasan-checks.h:5,
                 from include/asm-generic/rwonce.h:26,
                 from ./arch/x86/include/generated/asm/rwonce.h:1,
                 from include/linux/compiler.h:248,
                 from include/linux/build_bug.h:5,
                 from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
   16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
      |                                                          ^~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
  674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/kobject.h:19,
                 from include/linux/of.h:17,
                 from include/linux/irqdomain.h:35,
                 from include/linux/acpi.h:13,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/list.h:665:16: note: in definition of macro 'list_entry_is_head'
  665 |         (&pos->member == (head))
      |                ^~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:41: error: 'struct acpi_device' has no member named 'children'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                         ^~
include/linux/list.h:665:27: note: in definition of macro 'list_entry_is_head'
  665 |         (&pos->member == (head))
      |                           ^~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/list.h:5,
                 from include/linux/kobject.h:19,
                 from include/linux/of.h:17,
                 from include/linux/irqdomain.h:35,
                 from include/linux/acpi.h:13,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/container_of.h:18:33: note: in definition of macro 'container_of'
   18 |         void *__mptr = (void *)(ptr);                                   \
      |                                 ^~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
   20 |                       __same_type(*(ptr), void),                        \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:293:27: error: expression in static assertion is not an integer
  293 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
   19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
                 from include/uapi/linux/types.h:14,
                 from include/linux/types.h:6,
                 from include/linux/kasan-checks.h:5,
                 from include/asm-generic/rwonce.h:26,
                 from ./arch/x86/include/generated/asm/rwonce.h:1,
                 from include/linux/compiler.h:248,
                 from include/linux/build_bug.h:5,
                 from include/linux/bits.h:22,
                 from include/linux/ioport.h:13,
                 from include/linux/acpi.h:12,
                 from drivers/bus/hisi_lpc.c:9:
drivers/bus/hisi_lpc.c:509:53: error: 'struct acpi_device' has no member named 'node'; did you mean 'fwnode'?
  509 |         list_for_each_entry(child, &adev->children, node) {
      |                                                     ^~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
   16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
      |                                                          ^~~~~~
include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
  564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
      |         ^~~~~~~~~~
include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
  676 |              pos = list_next_entry(pos, member))
      |                    ^~~~~~~~~~~~~~~
drivers/bus/hisi_lpc.c:509:9: note: in expansion of macro 'list_for_each_entry'
  509 |         list_for_each_entry(child, &adev->children, node) {
      |         ^~~~~~~~~~~~~~~~~~~

Caused by commit

  647590eb6f34 ("ACPI: bus: Drop unused list heads from struct acpi_device")

I have used the pm tree from next-20220628 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-04-28  8:56 ` Zhang Rui
@ 2022-04-28 12:32   ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2022-04-28 12:32 UTC (permalink / raw)
  To: Zhang Rui
  Cc: Stephen Rothwell, Rafael J. Wysocki, Artem Bityutskiy,
	Linux Kernel Mailing List, Linux Next Mailing List,
	Linux PM list

On Thu, Apr 28, 2022 at 10:56 AM Zhang Rui <rui.zhang@intel.com> wrote:
>
> Resend with linux-pm mailing list CCed.
>
> On Thu, 2022-04-28 at 11:00 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (x86_64
> > allmodconfig)
> > failed like this:
> >
> > drivers/idle/intel_idle.c: In function 'adl_idle_state_table_update':
> > drivers/idle/intel_idle.c:1701:17: error: 'disable_promotion_to_c1e'
> > undeclared (first use in this function)
> >  1701 |                 disable_promotion_to_c1e = true;
> >       |                 ^~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/idle/intel_idle.c:1701:17: note: each undeclared identifier
> > is reported only once for each function it appears in
> > drivers/idle/intel_idle.c:1706:9: error: implicit declaration of
> > function 'c1e_promotion_enable' [-Werror=implicit-function-
> > declaration]
> >  1706 |         c1e_promotion_enable();
> >       |         ^~~~~~~~~~~~~~~~~~~~
> > drivers/idle/intel_idle.c: At top level:
> > drivers/idle/intel_idle.c:1854:13: error: conflicting types for
> > 'c1e_promotion_enable'; have 'void(void)' [-Werror]
> >  1854 | static void c1e_promotion_enable(void)
> >       |             ^~~~~~~~~~~~~~~~~~~~
> > drivers/idle/intel_idle.c:1854:13: error: static declaration of
> > 'c1e_promotion_enable' follows non-static declaration
> > drivers/idle/intel_idle.c:1706:9: note: previous implicit declaration
> > of 'c1e_promotion_enable' with type 'void(void)'
> >  1706 |         c1e_promotion_enable();
> >       |         ^~~~~~~~~~~~~~~~~~~~
> >
> > Caused by commit
> >
> >   39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module
> > parameter")
> >
> > interacting with commit
> >
> >   cc6e234b8264 ("intel_idle: Add AlderLake support")
> >
> > Presumably this should have been fixed up in commit
> >
> >   55ecda6f25ef ("Merge branch 'intel-idle' into linux-next")
> >
> > I have used the pm tree from next-20220427 for today.
> >
> TBH, I'm not quite sure about the Fixes tag below.
>
> Although commit 39c184a6a9a7 is merged later and breaks commit
> cc6e234b8264, but given that commit 39c184a6a9a7 is for -rc material
> and commit cc6e234b8264 and this patch are for next merge window, so I
> still use the orginal ADL intel_idle commit for Fixes tag.

Thanks for the fix.

I think I'll redo the ADL support commit with the below folded in.

> From 9b784d7f9ea5593a92eb6d616523b5f47464e981 Mon Sep 17 00:00:00 2001
> From: Zhang Rui <rui.zhang@intel.com>
> Date: Thu, 28 Apr 2022 09:37:10 +0800
> Subject: [PATCH] intel_idle: fix C1E handling for AlderLake
>
> commit cc6e234b8264 ("intel_idle: Add AlderLake support") disables the C1E
> promotion using the 'disable_promotion_to_c1e' variable, but enables the
> the C1E promotion by invoking c1e_promotion_enable() directly.
>
> Then, commit 39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module
> parameter") removes the 'disable_promotion_to_c1e' variable and introduces
> a new tri-state 'c1e_promotion' variable that can be used for both
> enabling and disabling C1E promotion, on a per CPU basis.
>
> Switch to use the new 'c1e_promotion' variable to fix the build failure,
> and also to do C1E promotion bit update on all CPUs.
>
> Fixes: commit cc6e234b8264 ("intel_idle: Add AlderLake support")
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/idle/intel_idle.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 7c081ed26b64..2de6e0a2d9a1 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1698,12 +1698,12 @@ static void __init adl_idle_state_table_update(void)
>                 cpuidle_state_table[1].flags |= CPUIDLE_FLAG_UNUSABLE;
>
>                 /* Disable C1E by clearing the "C1E promotion" bit. */
> -               disable_promotion_to_c1e = true;
> +               c1e_promotion = C1E_PROMOTION_DISABLE;
>                 return;
>         }
>  end:
>         /* Make sure C1E is enabled by default */
> -       c1e_promotion_enable();
> +       c1e_promotion = C1E_PROMOTION_ENABLE;
>  }
>
>  /**
> --
> 2.17.1
>
>

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-04-28  1:00 Stephen Rothwell
  2022-04-28  3:07 ` Zhang Rui
  2022-04-28  8:53 ` Zhang Rui
@ 2022-04-28  8:56 ` Zhang Rui
  2022-04-28 12:32   ` Rafael J. Wysocki
  2 siblings, 1 reply; 110+ messages in thread
From: Zhang Rui @ 2022-04-28  8:56 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki
  Cc: Artem Bityutskiy, Linux Kernel Mailing List,
	Linux Next Mailing List, Linux PM list

Resend with linux-pm mailing list CCed.

On Thu, 2022-04-28 at 11:00 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64
> allmodconfig)
> failed like this:
> 
> drivers/idle/intel_idle.c: In function 'adl_idle_state_table_update':
> drivers/idle/intel_idle.c:1701:17: error: 'disable_promotion_to_c1e'
> undeclared (first use in this function)
>  1701 |                 disable_promotion_to_c1e = true;
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c:1701:17: note: each undeclared identifier
> is reported only once for each function it appears in
> drivers/idle/intel_idle.c:1706:9: error: implicit declaration of
> function 'c1e_promotion_enable' [-Werror=implicit-function-
> declaration]
>  1706 |         c1e_promotion_enable();
>       |         ^~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c: At top level:
> drivers/idle/intel_idle.c:1854:13: error: conflicting types for
> 'c1e_promotion_enable'; have 'void(void)' [-Werror]
>  1854 | static void c1e_promotion_enable(void)
>       |             ^~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c:1854:13: error: static declaration of
> 'c1e_promotion_enable' follows non-static declaration
> drivers/idle/intel_idle.c:1706:9: note: previous implicit declaration
> of 'c1e_promotion_enable' with type 'void(void)'
>  1706 |         c1e_promotion_enable();
>       |         ^~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module
> parameter")
> 
> interacting with commit
> 
>   cc6e234b8264 ("intel_idle: Add AlderLake support")
> 
> Presumably this should have been fixed up in commit
> 
>   55ecda6f25ef ("Merge branch 'intel-idle' into linux-next")
> 
> I have used the pm tree from next-20220427 for today.
> 
TBH, I'm not quite sure about the Fixes tag below.

Although commit 39c184a6a9a7 is merged later and breaks commit
cc6e234b8264, but given that commit 39c184a6a9a7 is for -rc material
and commit cc6e234b8264 and this patch are for next merge window, so I
still use the orginal ADL intel_idle commit for Fixes tag.

thanks,
rui

From 9b784d7f9ea5593a92eb6d616523b5f47464e981 Mon Sep 17 00:00:00 2001
From: Zhang Rui <rui.zhang@intel.com>
Date: Thu, 28 Apr 2022 09:37:10 +0800
Subject: [PATCH] intel_idle: fix C1E handling for AlderLake

commit cc6e234b8264 ("intel_idle: Add AlderLake support") disables the C1E
promotion using the 'disable_promotion_to_c1e' variable, but enables the
the C1E promotion by invoking c1e_promotion_enable() directly.

Then, commit 39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module
parameter") removes the 'disable_promotion_to_c1e' variable and introduces
a new tri-state 'c1e_promotion' variable that can be used for both
enabling and disabling C1E promotion, on a per CPU basis.

Switch to use the new 'c1e_promotion' variable to fix the build failure,
and also to do C1E promotion bit update on all CPUs.

Fixes: commit cc6e234b8264 ("intel_idle: Add AlderLake support")
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/idle/intel_idle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 7c081ed26b64..2de6e0a2d9a1 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -1698,12 +1698,12 @@ static void __init adl_idle_state_table_update(void)
 		cpuidle_state_table[1].flags |= CPUIDLE_FLAG_UNUSABLE;
 
 		/* Disable C1E by clearing the "C1E promotion" bit. */
-		disable_promotion_to_c1e = true;
+		c1e_promotion = C1E_PROMOTION_DISABLE;
 		return;
 	}
 end:
 	/* Make sure C1E is enabled by default */
-	c1e_promotion_enable();
+	c1e_promotion = C1E_PROMOTION_ENABLE;
 }
 
 /**
-- 
2.17.1



^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-04-28  1:00 Stephen Rothwell
  2022-04-28  3:07 ` Zhang Rui
@ 2022-04-28  8:53 ` Zhang Rui
  2022-04-28  8:56 ` Zhang Rui
  2 siblings, 0 replies; 110+ messages in thread
From: Zhang Rui @ 2022-04-28  8:53 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki
  Cc: Artem Bityutskiy, Linux Kernel Mailing List, Linux Next Mailing List

On Thu, 2022-04-28 at 11:00 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64
> allmodconfig)
> failed like this:
> 
> drivers/idle/intel_idle.c: In function 'adl_idle_state_table_update':
> drivers/idle/intel_idle.c:1701:17: error: 'disable_promotion_to_c1e'
> undeclared (first use in this function)
>  1701 |                 disable_promotion_to_c1e = true;
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c:1701:17: note: each undeclared identifier
> is reported only once for each function it appears in
> drivers/idle/intel_idle.c:1706:9: error: implicit declaration of
> function 'c1e_promotion_enable' [-Werror=implicit-function-
> declaration]
>  1706 |         c1e_promotion_enable();
>       |         ^~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c: At top level:
> drivers/idle/intel_idle.c:1854:13: error: conflicting types for
> 'c1e_promotion_enable'; have 'void(void)' [-Werror]
>  1854 | static void c1e_promotion_enable(void)
>       |             ^~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c:1854:13: error: static declaration of
> 'c1e_promotion_enable' follows non-static declaration
> drivers/idle/intel_idle.c:1706:9: note: previous implicit declaration
> of 'c1e_promotion_enable' with type 'void(void)'
>  1706 |         c1e_promotion_enable();
>       |         ^~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module
> parameter")
> 
> interacting with commit
> 
>   cc6e234b8264 ("intel_idle: Add AlderLake support")
> 
> Presumably this should have been fixed up in commit
> 
>   55ecda6f25ef ("Merge branch 'intel-idle' into linux-next")
> 
> I have used the pm tree from next-20220427 for today.
> 

TBH, I'm not quite sure about the Fixes tag below.

Although commit 39c184a6a9a7 is merged later and breaks commit
cc6e234b8264, but given that commit 39c184a6a9a7 is for -rc material
and commit cc6e234b8264 and this patch are for next merge window, so I
still use the orginal ADL intel_idle commit for Fixes tag.

thanks,
rui

From 9b784d7f9ea5593a92eb6d616523b5f47464e981 Mon Sep 17 00:00:00 2001
From: Zhang Rui <rui.zhang@intel.com>
Date: Thu, 28 Apr 2022 09:37:10 +0800
Subject: [PATCH] intel_idle: fix C1E handling for AlderLake

commit cc6e234b8264 ("intel_idle: Add AlderLake support") disables the C1E
promotion using the 'disable_promotion_to_c1e' variable, but enables the
the C1E promotion by invoking c1e_promotion_enable() directly.

Then, commit 39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module
parameter") removes the 'disable_promotion_to_c1e' variable and introduces
a new tri-state 'c1e_promotion' variable that can be used for both
enabling and disabling C1E promotion, on a per CPU basis.

Switch to use the new 'c1e_promotion' variable to fix the build failure,
and also to do C1E promotion bit update on all CPUs.

Fixes: commit cc6e234b8264 ("intel_idle: Add AlderLake support")
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/idle/intel_idle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 7c081ed26b64..2de6e0a2d9a1 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -1698,12 +1698,12 @@ static void __init adl_idle_state_table_update(void)
 		cpuidle_state_table[1].flags |= CPUIDLE_FLAG_UNUSABLE;
 
 		/* Disable C1E by clearing the "C1E promotion" bit. */
-		disable_promotion_to_c1e = true;
+		c1e_promotion = C1E_PROMOTION_DISABLE;
 		return;
 	}
 end:
 	/* Make sure C1E is enabled by default */
-	c1e_promotion_enable();
+	c1e_promotion = C1E_PROMOTION_ENABLE;
 }
 
 /**
-- 
2.17.1




^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-04-28  1:00 Stephen Rothwell
@ 2022-04-28  3:07 ` Zhang Rui
  2022-04-28  8:53 ` Zhang Rui
  2022-04-28  8:56 ` Zhang Rui
  2 siblings, 0 replies; 110+ messages in thread
From: Zhang Rui @ 2022-04-28  3:07 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki
  Cc: Artem Bityutskiy, Linux Kernel Mailing List, Linux Next Mailing List

This is caused by the new merged commit 39c184a6a9a7 ("intel_idle: Fix
the 'preferred_cstates' module parameter"), which removes the variable
and function that commit cc6e234b8264 ("intel_idle: Add AlderLake
support") depends on.

I will send a patch on top to fix this soon.

thanks,
rui

On Thu, 2022-04-28 at 11:00 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64
> allmodconfig)
> failed like this:
> 
> drivers/idle/intel_idle.c: In function 'adl_idle_state_table_update':
> drivers/idle/intel_idle.c:1701:17: error: 'disable_promotion_to_c1e'
> undeclared (first use in this function)
>  1701 |                 disable_promotion_to_c1e = true;
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c:1701:17: note: each undeclared identifier
> is reported only once for each function it appears in
> drivers/idle/intel_idle.c:1706:9: error: implicit declaration of
> function 'c1e_promotion_enable' [-Werror=implicit-function-
> declaration]
>  1706 |         c1e_promotion_enable();
>       |         ^~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c: At top level:
> drivers/idle/intel_idle.c:1854:13: error: conflicting types for
> 'c1e_promotion_enable'; have 'void(void)' [-Werror]
>  1854 | static void c1e_promotion_enable(void)
>       |             ^~~~~~~~~~~~~~~~~~~~
> drivers/idle/intel_idle.c:1854:13: error: static declaration of
> 'c1e_promotion_enable' follows non-static declaration
> drivers/idle/intel_idle.c:1706:9: note: previous implicit declaration
> of 'c1e_promotion_enable' with type 'void(void)'
>  1706 |         c1e_promotion_enable();
>       |         ^~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module
> parameter")
> 
> interacting with commit
> 
>   cc6e234b8264 ("intel_idle: Add AlderLake support")
> 
> Presumably this should have been fixed up in commit
> 
>   55ecda6f25ef ("Merge branch 'intel-idle' into linux-next")
> 
> I have used the pm tree from next-20220427 for today.
> 


^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2022-04-28  1:00 Stephen Rothwell
  2022-04-28  3:07 ` Zhang Rui
                   ` (2 more replies)
  0 siblings, 3 replies; 110+ messages in thread
From: Stephen Rothwell @ 2022-04-28  1:00 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Zhang Rui, Artem Bityutskiy, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/idle/intel_idle.c: In function 'adl_idle_state_table_update':
drivers/idle/intel_idle.c:1701:17: error: 'disable_promotion_to_c1e' undeclared (first use in this function)
 1701 |                 disable_promotion_to_c1e = true;
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/idle/intel_idle.c:1701:17: note: each undeclared identifier is reported only once for each function it appears in
drivers/idle/intel_idle.c:1706:9: error: implicit declaration of function 'c1e_promotion_enable' [-Werror=implicit-function-declaration]
 1706 |         c1e_promotion_enable();
      |         ^~~~~~~~~~~~~~~~~~~~
drivers/idle/intel_idle.c: At top level:
drivers/idle/intel_idle.c:1854:13: error: conflicting types for 'c1e_promotion_enable'; have 'void(void)' [-Werror]
 1854 | static void c1e_promotion_enable(void)
      |             ^~~~~~~~~~~~~~~~~~~~
drivers/idle/intel_idle.c:1854:13: error: static declaration of 'c1e_promotion_enable' follows non-static declaration
drivers/idle/intel_idle.c:1706:9: note: previous implicit declaration of 'c1e_promotion_enable' with type 'void(void)'
 1706 |         c1e_promotion_enable();
      |         ^~~~~~~~~~~~~~~~~~~~

Caused by commit

  39c184a6a9a7 ("intel_idle: Fix the 'preferred_cstates' module parameter")

interacting with commit

  cc6e234b8264 ("intel_idle: Add AlderLake support")

Presumably this should have been fixed up in commit

  55ecda6f25ef ("Merge branch 'intel-idle' into linux-next")

I have used the pm tree from next-20220427 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-01-04 14:43     ` Heiner Kallweit
@ 2022-01-04 14:57       ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2022-01-04 14:57 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Rafael J. Wysocki, Rafael J. Wysocki, Linux Kernel Mailing List,
	Linux Next Mailing List, Stephen Rothwell, Linux PM

On Tue, Jan 4, 2022 at 3:43 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 04.01.2022 09:02, Stephen Rothwell wrote:
> > Hi Heiner,
> >
> > On Tue, 4 Jan 2022 08:29:28 +0100 Heiner Kallweit <hkallweit1@gmail.com> wrote:
> >>
> >> The patch in the pm tree annotating pm_runtime_resume_and_get() as __must_check
> >> follows some fixes of pm_runtime_resume_and_get() usage that went through other
> >> trees. These fixes are in linux-next but don't seem to be in the pm tree.
> >> We talk about:
> >> f04b4fb47d83 ("ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()")
> >
> > In the sound-asoc tree.
> >
> >> 3d6b661330a7 ("crypto: stm32 - Revert broken pm_runtime_resume_and_get changes")
> >
> > In the crypto tree.
> >
> > Both those are merged into linux-next after the pm tree.  If Linus did
> > the same, the pm tree commit would break his build.  The only way you
> > can have that pm tree commit in linux-next is to ask Andrew Morton to
> > put it in the post linux-next part of his patch series.  Otherwise, it
> > needs to be removed form the pm tree and wait until after the next
> > merge window closes (or at least both the above trees have been merged
> > by Linus).
> >
> Rafael,
> can you take care of this?

Done.

I've dropped the commit in question from pm-core and I'm going to add
it back and submit by the end of the merge window.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-01-04  8:02   ` Stephen Rothwell
@ 2022-01-04 14:43     ` Heiner Kallweit
  2022-01-04 14:57       ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Heiner Kallweit @ 2022-01-04 14:43 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List,
	Linux Next Mailing List, Stephen Rothwell, Linux PM

On 04.01.2022 09:02, Stephen Rothwell wrote:
> Hi Heiner,
> 
> On Tue, 4 Jan 2022 08:29:28 +0100 Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> The patch in the pm tree annotating pm_runtime_resume_and_get() as __must_check
>> follows some fixes of pm_runtime_resume_and_get() usage that went through other
>> trees. These fixes are in linux-next but don't seem to be in the pm tree.
>> We talk about:
>> f04b4fb47d83 ("ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()")
> 
> In the sound-asoc tree.
> 
>> 3d6b661330a7 ("crypto: stm32 - Revert broken pm_runtime_resume_and_get changes")
> 
> In the crypto tree.
> 
> Both those are merged into linux-next after the pm tree.  If Linus did
> the same, the pm tree commit would break his build.  The only way you
> can have that pm tree commit in linux-next is to ask Andrew Morton to
> put it in the post linux-next part of his patch series.  Otherwise, it
> needs to be removed form the pm tree and wait until after the next
> merge window closes (or at least both the above trees have been merged
> by Linus).
> 
Rafael,
can you take care of this?
To avoid such issues I think next time I'd route all dependent patches
through one tree and just get the ACK from the other involved maintainers.

Thank you, Heiner

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-01-04  7:29 ` Heiner Kallweit
@ 2022-01-04  8:02   ` Stephen Rothwell
  2022-01-04 14:43     ` Heiner Kallweit
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2022-01-04  8:02 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

Hi Heiner,

On Tue, 4 Jan 2022 08:29:28 +0100 Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> The patch in the pm tree annotating pm_runtime_resume_and_get() as __must_check
> follows some fixes of pm_runtime_resume_and_get() usage that went through other
> trees. These fixes are in linux-next but don't seem to be in the pm tree.
> We talk about:
> f04b4fb47d83 ("ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()")

In the sound-asoc tree.

> 3d6b661330a7 ("crypto: stm32 - Revert broken pm_runtime_resume_and_get changes")

In the crypto tree.

Both those are merged into linux-next after the pm tree.  If Linus did
the same, the pm tree commit would break his build.  The only way you
can have that pm tree commit in linux-next is to ask Andrew Morton to
put it in the post linux-next part of his patch series.  Otherwise, it
needs to be removed form the pm tree and wait until after the next
merge window closes (or at least both the above trees have been merged
by Linus).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2022-01-04  0:15 Stephen Rothwell
@ 2022-01-04  7:29 ` Heiner Kallweit
  2022-01-04  8:02   ` Stephen Rothwell
  0 siblings, 1 reply; 110+ messages in thread
From: Heiner Kallweit @ 2022-01-04  7:29 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 04.01.2022 01:15, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_84 allmodconfig)
> failed like this:
> 
> sound/soc/sh/rz-ssi.c: In function 'rz_ssi_probe':
> sound/soc/sh/rz-ssi.c:1023:2: error: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Werror=unused-result]
>  1023 |  pm_runtime_resume_and_get(&pdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   877d952c261e ("PM: runtime: Annotate pm_runtime_resume_and_get() as __must_check")
> 
> This also produced the following warnings in my arm multi_v7_defconfig
> build:
> 
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_hw_init':
> drivers/crypto/stm32/stm32-hash.c:816:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>   816 |  pm_runtime_resume_and_get(hdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_import':
> drivers/crypto/stm32/stm32-hash.c:1003:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>  1003 |  pm_runtime_resume_and_get(hdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_export':
> drivers/crypto/stm32/stm32-hash.c:965:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>   965 |  pm_runtime_resume_and_get(hdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-cryp.c: In function 'stm32_cryp_hw_init':
> drivers/crypto/stm32/stm32-cryp.c:545:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>   545 |  pm_runtime_resume_and_get(cryp->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I have used the pm tree from next-20211224 for today.
> 
The patch in the pm tree annotating pm_runtime_resume_and_get() as __must_check
follows some fixes of pm_runtime_resume_and_get() usage that went through other
trees. These fixes are in linux-next but don't seem to be in the pm tree.
We talk about:
f04b4fb47d83 ("ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()")
3d6b661330a7 ("crypto: stm32 - Revert broken pm_runtime_resume_and_get changes")

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2022-01-04  0:15 Stephen Rothwell
  2022-01-04  7:29 ` Heiner Kallweit
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2022-01-04  0:15 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Heiner Kallweit, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_84 allmodconfig)
failed like this:

sound/soc/sh/rz-ssi.c: In function 'rz_ssi_probe':
sound/soc/sh/rz-ssi.c:1023:2: error: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Werror=unused-result]
 1023 |  pm_runtime_resume_and_get(&pdev->dev);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  877d952c261e ("PM: runtime: Annotate pm_runtime_resume_and_get() as __must_check")

This also produced the following warnings in my arm multi_v7_defconfig
build:

drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_hw_init':
drivers/crypto/stm32/stm32-hash.c:816:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
  816 |  pm_runtime_resume_and_get(hdev->dev);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_import':
drivers/crypto/stm32/stm32-hash.c:1003:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
 1003 |  pm_runtime_resume_and_get(hdev->dev);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_export':
drivers/crypto/stm32/stm32-hash.c:965:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
  965 |  pm_runtime_resume_and_get(hdev->dev);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/crypto/stm32/stm32-cryp.c: In function 'stm32_cryp_hw_init':
drivers/crypto/stm32/stm32-cryp.c:545:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
  545 |  pm_runtime_resume_and_get(cryp->dev);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I have used the pm tree from next-20211224 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-12-03 16:50   ` Rafael J. Wysocki
@ 2021-12-03 17:22     ` Daniel Lezcano
  0 siblings, 0 replies; 110+ messages in thread
From: Daniel Lezcano @ 2021-12-03 17:22 UTC (permalink / raw)
  To: Rafael J. Wysocki, Stephen Rothwell
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 03/12/2021 17:50, Rafael J. Wysocki wrote:
> On Thursday, December 2, 2021 11:04:45 AM CET Daniel Lezcano wrote:
>>
>> On 02/12/2021 00:28, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
>>> failed like this:
>>>
>>> drivers/powercap/dtpm.c: In function 'init_dtpm':
>>> drivers/powercap/dtpm.c:466:21: error: unused variable 'dtpm_descr' [-Werror=unused-variable]
>>>   466 |  struct dtpm_descr *dtpm_descr;
>>>       |                     ^~~~~~~~~~
>>> cc1: all warnings being treated as errors
>>>
>>> Caused by commit
>>>
>>>   f751db8adaea ("powercap/drivers/dtpm: Disable DTPM at boot time")
>>
>> Rafael, will you drop the patch from your tree and I send a new one with
>> the local variable also, or shall I send a change on top of?
> 
> I'll fix this.

Ok, thanks. Sorry for the inconvenience


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-12-02 10:04 ` Daniel Lezcano
@ 2021-12-03 16:50   ` Rafael J. Wysocki
  2021-12-03 17:22     ` Daniel Lezcano
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2021-12-03 16:50 UTC (permalink / raw)
  To: Stephen Rothwell, Daniel Lezcano
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On Thursday, December 2, 2021 11:04:45 AM CET Daniel Lezcano wrote:
> 
> On 02/12/2021 00:28, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > drivers/powercap/dtpm.c: In function 'init_dtpm':
> > drivers/powercap/dtpm.c:466:21: error: unused variable 'dtpm_descr' [-Werror=unused-variable]
> >   466 |  struct dtpm_descr *dtpm_descr;
> >       |                     ^~~~~~~~~~
> > cc1: all warnings being treated as errors
> > 
> > Caused by commit
> > 
> >   f751db8adaea ("powercap/drivers/dtpm: Disable DTPM at boot time")
> 
> Rafael, will you drop the patch from your tree and I send a new one with
> the local variable also, or shall I send a change on top of?

I'll fix this.




^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-12-01 23:28 Stephen Rothwell
@ 2021-12-02 10:04 ` Daniel Lezcano
  2021-12-03 16:50   ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Daniel Lezcano @ 2021-12-02 10:04 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki
  Cc: Linux Kernel Mailing List, Linux Next Mailing List


On 02/12/2021 00:28, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/powercap/dtpm.c: In function 'init_dtpm':
> drivers/powercap/dtpm.c:466:21: error: unused variable 'dtpm_descr' [-Werror=unused-variable]
>   466 |  struct dtpm_descr *dtpm_descr;
>       |                     ^~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   f751db8adaea ("powercap/drivers/dtpm: Disable DTPM at boot time")

Rafael, will you drop the patch from your tree and I send a new one with
the local variable also, or shall I send a change on top of?

> 
> I have used the pm tree from next-20211201 for today.
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2021-12-01 23:28 Stephen Rothwell
  2021-12-02 10:04 ` Daniel Lezcano
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2021-12-01 23:28 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Daniel Lezcano, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/powercap/dtpm.c: In function 'init_dtpm':
drivers/powercap/dtpm.c:466:21: error: unused variable 'dtpm_descr' [-Werror=unused-variable]
  466 |  struct dtpm_descr *dtpm_descr;
      |                     ^~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  f751db8adaea ("powercap/drivers/dtpm: Disable DTPM at boot time")

I have used the pm tree from next-20211201 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-02-09 14:32           ` Rafael J. Wysocki
@ 2021-02-09 16:04             ` Andy Shevchenko
  0 siblings, 0 replies; 110+ messages in thread
From: Andy Shevchenko @ 2021-02-09 16:04 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Rafael J. Wysocki, Stephen Rothwell, Linux Kernel Mailing List,
	Linux Next Mailing List

On Tue, Feb 09, 2021 at 03:32:38PM +0100, Rafael J. Wysocki wrote:
> On Mon, Feb 8, 2021 at 8:48 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Feb 8, 2021 at 9:47 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Mon, Feb 8, 2021 at 9:30 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > > > On Friday, February 5, 2021 12:15:22 PM CET Andy Shevchenko wrote:
> > > > > On Fri, Feb 5, 2021 at 11:14 AM Andy Shevchenko
> > > > > <andy.shevchenko@gmail.com> wrote:
> > > > > > On Friday, February 5, 2021, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > > > > >> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > > > > >> failed like this:
> > > > > >>
> > > > > >
> > > > > > Rafael, maybe I was unclear when explaining to you the dependencies with the series of series, but all three parts should go ordered. In any case it’s easy to fix. I will send you a PR late today of the immutable tag (part 1) that needs to be included in order to avoid the above.
> > > > >
> > > > > PR had just been sent to linux-acpi@ and Rafael in Cc.
> > > >
> > > > I haven't seen that PR, though, in any of my inboxes etc.
> > > >
> > > > Can you please point me to an archive or similar where I can find it?
> > >
> > > Sure, lore has it
> > >
> > > https://lore.kernel.org/linux-acpi/YB0mPPgpIpQzhNXS@smile.fi.intel.com/T/#u
> >
> > If it is possible, please pull that PR and on top of that (re-)apply
> > the MFD related series.
> 
> Done (merged into the bleeding-edge branch).

Looks perfect, thanks! I will send a last part soon (tomorrow at last).

> I was confused by it apparently asking Linus to pull. :-)

Ah, sorry, it looks like I forgot to update the text when sending it again...

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-02-08 19:48         ` Andy Shevchenko
@ 2021-02-09 14:32           ` Rafael J. Wysocki
  2021-02-09 16:04             ` Andy Shevchenko
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2021-02-09 14:32 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Rafael J. Wysocki, Stephen Rothwell, Andy Shevchenko,
	Linux Kernel Mailing List, Linux Next Mailing List,
	Rafael J. Wysocki

On Mon, Feb 8, 2021 at 8:48 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Feb 8, 2021 at 9:47 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Feb 8, 2021 at 9:30 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > >
> > > On Friday, February 5, 2021 12:15:22 PM CET Andy Shevchenko wrote:
> > > > On Fri, Feb 5, 2021 at 11:14 AM Andy Shevchenko
> > > > <andy.shevchenko@gmail.com> wrote:
> > > > > On Friday, February 5, 2021, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > >> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > > > >> failed like this:
> > > > >>
> > > > >
> > > > > Rafael, maybe I was unclear when explaining to you the dependencies with the series of series, but all three parts should go ordered. In any case it’s easy to fix. I will send you a PR late today of the immutable tag (part 1) that needs to be included in order to avoid the above.
> > > >
> > > > PR had just been sent to linux-acpi@ and Rafael in Cc.
> > >
> > > I haven't seen that PR, though, in any of my inboxes etc.
> > >
> > > Can you please point me to an archive or similar where I can find it?
> >
> > Sure, lore has it
> >
> > https://lore.kernel.org/linux-acpi/YB0mPPgpIpQzhNXS@smile.fi.intel.com/T/#u
>
> If it is possible, please pull that PR and on top of that (re-)apply
> the MFD related series.

Done (merged into the bleeding-edge branch).

I was confused by it apparently asking Linus to pull. :-)

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-02-08 19:47       ` Andy Shevchenko
@ 2021-02-08 19:48         ` Andy Shevchenko
  2021-02-09 14:32           ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Andy Shevchenko @ 2021-02-08 19:48 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, Andy Shevchenko, Linux Kernel Mailing List,
	Linux Next Mailing List, Rafael J. Wysocki

On Mon, Feb 8, 2021 at 9:47 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Feb 8, 2021 at 9:30 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > On Friday, February 5, 2021 12:15:22 PM CET Andy Shevchenko wrote:
> > > On Fri, Feb 5, 2021 at 11:14 AM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:
> > > > On Friday, February 5, 2021, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > >> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > > >> failed like this:
> > > >>
> > > >
> > > > Rafael, maybe I was unclear when explaining to you the dependencies with the series of series, but all three parts should go ordered. In any case it’s easy to fix. I will send you a PR late today of the immutable tag (part 1) that needs to be included in order to avoid the above.
> > >
> > > PR had just been sent to linux-acpi@ and Rafael in Cc.
> >
> > I haven't seen that PR, though, in any of my inboxes etc.
> >
> > Can you please point me to an archive or similar where I can find it?
>
> Sure, lore has it
>
> https://lore.kernel.org/linux-acpi/YB0mPPgpIpQzhNXS@smile.fi.intel.com/T/#u

If it is possible, please pull that PR and on top of that (re-)apply
the MFD related series.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-02-08 19:30     ` Rafael J. Wysocki
@ 2021-02-08 19:47       ` Andy Shevchenko
  2021-02-08 19:48         ` Andy Shevchenko
  0 siblings, 1 reply; 110+ messages in thread
From: Andy Shevchenko @ 2021-02-08 19:47 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, Andy Shevchenko, Linux Kernel Mailing List,
	Linux Next Mailing List, Rafael J. Wysocki

On Mon, Feb 8, 2021 at 9:30 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> On Friday, February 5, 2021 12:15:22 PM CET Andy Shevchenko wrote:
> > On Fri, Feb 5, 2021 at 11:14 AM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Friday, February 5, 2021, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > >> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > >> failed like this:
> > >>
> > >
> > > Rafael, maybe I was unclear when explaining to you the dependencies with the series of series, but all three parts should go ordered. In any case it’s easy to fix. I will send you a PR late today of the immutable tag (part 1) that needs to be included in order to avoid the above.
> >
> > PR had just been sent to linux-acpi@ and Rafael in Cc.
>
> I haven't seen that PR, though, in any of my inboxes etc.
>
> Can you please point me to an archive or similar where I can find it?

Sure, lore has it

https://lore.kernel.org/linux-acpi/YB0mPPgpIpQzhNXS@smile.fi.intel.com/T/#u

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2021-02-05 11:15   ` Andy Shevchenko
@ 2021-02-08 19:30     ` Rafael J. Wysocki
  2021-02-08 19:47       ` Andy Shevchenko
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2021-02-08 19:30 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Stephen Rothwell, Andy Shevchenko, Linux Kernel Mailing List,
	Linux Next Mailing List, Rafael J. Wysocki

On Friday, February 5, 2021 12:15:22 PM CET Andy Shevchenko wrote:
> On Fri, Feb 5, 2021 at 11:14 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Friday, February 5, 2021, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> >> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> >> failed like this:
> >>
> >
> > Rafael, maybe I was unclear when explaining to you the dependencies with the series of series, but all three parts should go ordered. In any case it’s easy to fix. I will send you a PR late today of the immutable tag (part 1) that needs to be included in order to avoid the above.
> 
> PR had just been sent to linux-acpi@ and Rafael in Cc.

I haven't seen that PR, though, in any of my inboxes etc.

Can you please point me to an archive or similar where I can find it?

Cheers!




^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
       [not found] ` <CAHp75VfiyAtxg+wqZ30kSzCfFFsLndLjzrUc1njZG0x6vQeyBQ@mail.gmail.com>
@ 2021-02-05 11:15   ` Andy Shevchenko
  2021-02-08 19:30     ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Andy Shevchenko @ 2021-02-05 11:15 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, Andy Shevchenko, Linux Kernel Mailing List,
	Linux Next Mailing List

On Fri, Feb 5, 2021 at 11:14 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Friday, February 5, 2021, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

>> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>
> Rafael, maybe I was unclear when explaining to you the dependencies with the series of series, but all three parts should go ordered. In any case it’s easy to fix. I will send you a PR late today of the immutable tag (part 1) that needs to be included in order to avoid the above.

PR had just been sent to linux-acpi@ and Rafael in Cc.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2021-02-05  0:51 Stephen Rothwell
       [not found] ` <CAHp75VfiyAtxg+wqZ30kSzCfFFsLndLjzrUc1njZG0x6vQeyBQ@mail.gmail.com>
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2021-02-05  0:51 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Andy Shevchenko, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c: In function 'tc35876x_brightness_init':
drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c:454:8: error: implicit declaration of function 'intel_scu_ipc_ioread8'; did you mean 'intel_scu_ipc_readv'? [-Werror=implicit-function-declaration]
  454 |  ret = intel_scu_ipc_ioread8(GPIOPWMCTRL, &pwmctrl);
      |        ^~~~~~~~~~~~~~~~~~~~~
      |        intel_scu_ipc_readv
drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c:461:9: error: implicit declaration of function 'intel_scu_ipc_iowrite8'; did you mean 'intel_scu_ipc_writev'? [-Werror=implicit-function-declaration]
  461 |   ret = intel_scu_ipc_iowrite8(GPIOPWMCTRL, 0x01);
      |         ^~~~~~~~~~~~~~~~~~~~~~
      |         intel_scu_ipc_writev
drivers/watchdog/intel_scu_watchdog.c:34:10: fatal error: asm/apb_timer.h: No such file or directory
   34 | #include <asm/apb_timer.h>
      |          ^~~~~~~~~~~~~~~~~
drivers/rtc/rtc-mrst.c:38:10: fatal error: asm/intel_mid_vrtc.h: No such file or directory
   38 | #include <asm/intel_mid_vrtc.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~

Caused by commits

  80b6aebc7705 ("x86/platform/intel-mid: Remove unused leftovers (vRTC)")
  975272714c6f ("x86/apb_timer: Remove driver for deprecated platform")
  08a1ce661b5c ("mfd: intel_msic: Remove driver for deprecated platform")

I have used the pm tree from next-20210204 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2020-12-09  9:57 Stephen Rothwell
  0 siblings, 0 replies; 110+ messages in thread
From: Stephen Rothwell @ 2020-12-09  9:57 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Jonathan Corbet, Hans de Goede, Mark Pearson,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (htmldocs) failed
like this:

Sphinx parallel build error:
docutils.utils.SystemMessage: /home/sfr/next/next/Documentation/ABI/testing/sysfs-platform_profile.rst:1: (SEVERE/4) Missing matching underline for section title overline.

=======================================================================
 Platform Profile Selection (e.g. :ref:`\/sys\/firmware\/acpi\/platform_profile <abi_sys_firmware_acpi_platform_profile>`)

Caused by commit

  ff950bebd0e0 ("Documentation: Add documentation for new platform_profile sysfs attribute")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2019-07-31  5:34 Stephen Rothwell
@ 2019-07-31 10:27 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2019-07-31 10:27 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Marcelo Tosatti

On Wednesday, July 31, 2019 7:34:19 AM CEST Stephen Rothwell wrote:
> 
> --Sig_/RVaztRR.13XAL2aXFk8lo/g
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
> failed like this:
> 
> x86_64-linux-gnu-ld: kernel/sched/core.o: in function `cpuidle_poll_time':
> core.c:(.text+0x230): multiple definition of `cpuidle_poll_time'; arch/x86/=
> kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/loadavg.o: in function `cpuidle_poll_time=
> ':
> loadavg.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/x86=
> /kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/clock.o: in function `cpuidle_poll_time':
> clock.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/x86/k=
> ernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/cputime.o: in function `cpuidle_poll_time=
> ':
> cputime.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/x86=
> /kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/idle.o: in function `cpuidle_poll_time':
> idle.c:(.text+0xd0): multiple definition of `cpuidle_poll_time'; arch/x86/k=
> ernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/fair.o: in function `cpuidle_poll_time':
> fair.c:(.text+0xb20): multiple definition of `cpuidle_poll_time'; arch/x86/=
> kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/rt.o: in function `cpuidle_poll_time':
> rt.c:(.text+0x790): multiple definition of `cpuidle_poll_time'; arch/x86/ke=
> rnel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/deadline.o: in function `cpuidle_poll_tim=
> e':
> deadline.c:(.text+0xce0): multiple definition of `cpuidle_poll_time'; arch/=
> x86/kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/wait.o: in function `cpuidle_poll_time':
> wait.c:(.text+0x1d0): multiple definition of `cpuidle_poll_time'; arch/x86/=
> kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/wait_bit.o: in function `cpuidle_poll_tim=
> e':
> wait_bit.c:(.text+0x50): multiple definition of `cpuidle_poll_time'; arch/x=
> 86/kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/swait.o: in function `cpuidle_poll_time':
> swait.c:(.text+0x30): multiple definition of `cpuidle_poll_time'; arch/x86/=
> kernel/process.o:process.c:(.text+0xc0): first defined here
> x86_64-linux-gnu-ld: kernel/sched/completion.o: in function `cpuidle_poll_t=
> ime':
> completion.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/=
> x86/kernel/process.o:process.c:(.text+0xc0): first defined here
> 
> Caused by commit
> 
>   259231a04561 ("cpuidle: add poll_limit_ns to cpuidle_device structure")
> 
> I have added the following patch for today:
>

I've applied this patch to my pm-cpuidle branch, thanks Stephen!

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 31 Jul 2019 15:29:52 +1000
> Subject: [PATCH] cpuidle: header file stubs must be "static inline"
> 
> An x86_64 allmodconfig build produces these errors:
> 
> x86_64-linux-gnu-ld: kernel/sched/core.o: in function `cpuidle_poll_time':
> core.c:(.text+0x230): multiple definition of `cpuidle_poll_time'; arch/x86/=
> kernel/process.o:process.c:(.text+0xc0): first defined here
> 
> (and more)
> 
> Fixes: 259231a04561 ("cpuidle: add poll_limit_ns to cpuidle_device structur=
> e")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/linux/cpuidle.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
> index ba535a1a47d5..1a9f54eb3aa1 100644
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -170,7 +170,7 @@ static inline int cpuidle_enter(struct cpuidle_driver *=
> drv,
>  				struct cpuidle_device *dev, int index)
>  {return -ENODEV; }
>  static inline void cpuidle_reflect(struct cpuidle_device *dev, int index) =
> { }
> -extern u64 cpuidle_poll_time(struct cpuidle_driver *drv,
> +static inline u64 cpuidle_poll_time(struct cpuidle_driver *drv,
>  			     struct cpuidle_device *dev)
>  {return 0; }
>  static inline int cpuidle_register_driver(struct cpuidle_driver *drv)
> --=20
> 2.20.1
> 
> --=20
> Cheers,
> Stephen Rothwell
> 
> --Sig_/RVaztRR.13XAL2aXFk8lo/g
> Content-Type: application/pgp-signature
> Content-Description: OpenPGP digital signature
> 
> 
> --Sig_/RVaztRR.13XAL2aXFk8lo/g--
> 





^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2019-07-31  5:34 Stephen Rothwell
  2019-07-31 10:27 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2019-07-31  5:34 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Marcelo Tosatti

[-- Attachment #1: Type: text/plain, Size: 4180 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
failed like this:

x86_64-linux-gnu-ld: kernel/sched/core.o: in function `cpuidle_poll_time':
core.c:(.text+0x230): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/loadavg.o: in function `cpuidle_poll_time':
loadavg.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/clock.o: in function `cpuidle_poll_time':
clock.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/cputime.o: in function `cpuidle_poll_time':
cputime.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/idle.o: in function `cpuidle_poll_time':
idle.c:(.text+0xd0): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/fair.o: in function `cpuidle_poll_time':
fair.c:(.text+0xb20): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/rt.o: in function `cpuidle_poll_time':
rt.c:(.text+0x790): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/deadline.o: in function `cpuidle_poll_time':
deadline.c:(.text+0xce0): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/wait.o: in function `cpuidle_poll_time':
wait.c:(.text+0x1d0): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/wait_bit.o: in function `cpuidle_poll_time':
wait_bit.c:(.text+0x50): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/swait.o: in function `cpuidle_poll_time':
swait.c:(.text+0x30): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here
x86_64-linux-gnu-ld: kernel/sched/completion.o: in function `cpuidle_poll_time':
completion.c:(.text+0x0): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here

Caused by commit

  259231a04561 ("cpuidle: add poll_limit_ns to cpuidle_device structure")

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 31 Jul 2019 15:29:52 +1000
Subject: [PATCH] cpuidle: header file stubs must be "static inline"

An x86_64 allmodconfig build produces these errors:

x86_64-linux-gnu-ld: kernel/sched/core.o: in function `cpuidle_poll_time':
core.c:(.text+0x230): multiple definition of `cpuidle_poll_time'; arch/x86/kernel/process.o:process.c:(.text+0xc0): first defined here

(and more)

Fixes: 259231a04561 ("cpuidle: add poll_limit_ns to cpuidle_device structure")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/cpuidle.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index ba535a1a47d5..1a9f54eb3aa1 100644
--- a/include/linux/cpuidle.h
+++ b/include/linux/cpuidle.h
@@ -170,7 +170,7 @@ static inline int cpuidle_enter(struct cpuidle_driver *drv,
 				struct cpuidle_device *dev, int index)
 {return -ENODEV; }
 static inline void cpuidle_reflect(struct cpuidle_device *dev, int index) { }
-extern u64 cpuidle_poll_time(struct cpuidle_driver *drv,
+static inline u64 cpuidle_poll_time(struct cpuidle_driver *drv,
 			     struct cpuidle_device *dev)
 {return 0; }
 static inline int cpuidle_register_driver(struct cpuidle_driver *drv)
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2019-07-15  0:02 Stephen Rothwell
@ 2019-07-15  9:44 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2019-07-15  9:44 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhang Rui,
	Pandruvada, Srinivas

Hi Stephen,

On Monday, July 15, 2019 2:02:36 AM CEST Stephen Rothwell wrote:
> 
> --Sig_/JvAwh/r3+t+V+F.+O2706e.
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> In file included from <command-line>:
> include/linux/intel_rapl.h:116:19: error: field 'pcap_rapl_online' has inco=
> mplete type
>   enum cpuhp_state pcap_rapl_online;
>                    ^~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   7ebf8eff63b4 ("intel_rapl: introduce struct rapl_if_private")
> 
> This was detected by the new test that attempts to build each include
> file standalone.
> 
> I have added the following fix patch for today:

I've applied this patch on top of the RAPL series and added it to my linux-next branch.

Thanks!

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 15 Jul 2019 09:56:30 +1000
> Subject: [PATCH] intel_rapl: need linux/cpuhotplug.h for enum cpuhp_state
> 
> Fixes: 7ebf8eff63b4 ("intel_rapl: introduce struct rapl_if_private")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/linux/intel_rapl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/intel_rapl.h b/include/linux/intel_rapl.h
> index 0c179d92d110..efb3ce892c20 100644
> --- a/include/linux/intel_rapl.h
> +++ b/include/linux/intel_rapl.h
> @@ -12,6 +12,7 @@
> =20
>  #include <linux/types.h>
>  #include <linux/powercap.h>
> +#include <linux/cpuhotplug.h>
> =20
>  enum rapl_domain_type {
>  	RAPL_DOMAIN_PACKAGE,	/* entire package/socket */
> --=20
> 2.20.1
> 
> --=20
> Cheers,
> Stephen Rothwell
> 
> --Sig_/JvAwh/r3+t+V+F.+O2706e.
> Content-Type: application/pgp-signature
> Content-Description: OpenPGP digital signature
> 
> 
> --Sig_/JvAwh/r3+t+V+F.+O2706e.--
> 





^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2019-07-15  0:02 Stephen Rothwell
  2019-07-15  9:44 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2019-07-15  0:02 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhang Rui,
	Pandruvada, Srinivas

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from <command-line>:
include/linux/intel_rapl.h:116:19: error: field 'pcap_rapl_online' has incomplete type
  enum cpuhp_state pcap_rapl_online;
                   ^~~~~~~~~~~~~~~~

Caused by commit

  7ebf8eff63b4 ("intel_rapl: introduce struct rapl_if_private")

This was detected by the new test that attempts to build each include
file standalone.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 15 Jul 2019 09:56:30 +1000
Subject: [PATCH] intel_rapl: need linux/cpuhotplug.h for enum cpuhp_state

Fixes: 7ebf8eff63b4 ("intel_rapl: introduce struct rapl_if_private")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/intel_rapl.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/intel_rapl.h b/include/linux/intel_rapl.h
index 0c179d92d110..efb3ce892c20 100644
--- a/include/linux/intel_rapl.h
+++ b/include/linux/intel_rapl.h
@@ -12,6 +12,7 @@
 
 #include <linux/types.h>
 #include <linux/powercap.h>
+#include <linux/cpuhotplug.h>
 
 enum rapl_domain_type {
 	RAPL_DOMAIN_PACKAGE,	/* entire package/socket */
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2019-07-04  9:48 ` Viresh Kumar
@ 2019-07-04 10:33   ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2019-07-04 10:33 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Matthias Kaehlcke, Ulf Hansson

On Thursday, July 4, 2019 11:48:34 AM CEST Viresh Kumar wrote:
> On 04-07-19, 19:41, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
> > failed like this:
> > 
> > In file included from kernel/power/qos.c:33:
> > include/linux/pm_qos.h: In function 'dev_pm_qos_read_value':
> > include/linux/pm_qos.h:205:9: error: expected '(' before 'type'
> >   switch type {
> >          ^~~~
> >          (
> > include/linux/pm_qos.h:205:9: warning: statement with no effect [-Wunused-value]
> >   switch type {
> >          ^~~~
> > include/linux/pm_qos.h:216:1: warning: no return statement in function returning non-void [-Wreturn-type]
> >  }
> >  ^
> > include/linux/pm_qos.h: At top level:
> > include/linux/pm_qos.h:231:4: error: expected identifier or '(' before '{' token
> >     { return 0; }
> >     ^
> > In file included from kernel/power/qos.c:33:
> > include/linux/pm_qos.h:228:19: warning: 'dev_pm_qos_add_notifier' declared 'static' but never defined [-Wunused-function]
> >  static inline int dev_pm_qos_add_notifier(struct device *dev,
> >                    ^~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Caused by commits
> > 
> >   024a47a2732d ("PM / QOS: Pass request type to dev_pm_qos_{add|remove}_notifier()")
> >   57fa6137402b ("PM / QOS: Pass request type to dev_pm_qos_read_value()")
> 
> Yeah, I have already sent the replacement patchset to Rafael.

And which has been applied promptly.

Thanks,
Rafael




^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2019-07-04  9:41 Stephen Rothwell
@ 2019-07-04  9:48 ` Viresh Kumar
  2019-07-04 10:33   ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Viresh Kumar @ 2019-07-04  9:48 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, Linux Next Mailing List,
	Linux Kernel Mailing List, Matthias Kaehlcke, Ulf Hansson

On 04-07-19, 19:41, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
> failed like this:
> 
> In file included from kernel/power/qos.c:33:
> include/linux/pm_qos.h: In function 'dev_pm_qos_read_value':
> include/linux/pm_qos.h:205:9: error: expected '(' before 'type'
>   switch type {
>          ^~~~
>          (
> include/linux/pm_qos.h:205:9: warning: statement with no effect [-Wunused-value]
>   switch type {
>          ^~~~
> include/linux/pm_qos.h:216:1: warning: no return statement in function returning non-void [-Wreturn-type]
>  }
>  ^
> include/linux/pm_qos.h: At top level:
> include/linux/pm_qos.h:231:4: error: expected identifier or '(' before '{' token
>     { return 0; }
>     ^
> In file included from kernel/power/qos.c:33:
> include/linux/pm_qos.h:228:19: warning: 'dev_pm_qos_add_notifier' declared 'static' but never defined [-Wunused-function]
>  static inline int dev_pm_qos_add_notifier(struct device *dev,
>                    ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commits
> 
>   024a47a2732d ("PM / QOS: Pass request type to dev_pm_qos_{add|remove}_notifier()")
>   57fa6137402b ("PM / QOS: Pass request type to dev_pm_qos_read_value()")

Yeah, I have already sent the replacement patchset to Rafael.

-- 
viresh

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2019-07-04  9:41 Stephen Rothwell
  2019-07-04  9:48 ` Viresh Kumar
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2019-07-04  9:41 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Viresh Kumar,
	Matthias Kaehlcke, Ulf Hansson

[-- Attachment #1: Type: text/plain, Size: 2470 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
failed like this:

In file included from kernel/power/qos.c:33:
include/linux/pm_qos.h: In function 'dev_pm_qos_read_value':
include/linux/pm_qos.h:205:9: error: expected '(' before 'type'
  switch type {
         ^~~~
         (
include/linux/pm_qos.h:205:9: warning: statement with no effect [-Wunused-value]
  switch type {
         ^~~~
include/linux/pm_qos.h:216:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^
include/linux/pm_qos.h: At top level:
include/linux/pm_qos.h:231:4: error: expected identifier or '(' before '{' token
    { return 0; }
    ^
In file included from kernel/power/qos.c:33:
include/linux/pm_qos.h:228:19: warning: 'dev_pm_qos_add_notifier' declared 'static' but never defined [-Wunused-function]
 static inline int dev_pm_qos_add_notifier(struct device *dev,
                   ^~~~~~~~~~~~~~~~~~~~~~~

Caused by commits

  024a47a2732d ("PM / QOS: Pass request type to dev_pm_qos_{add|remove}_notifier()")
  57fa6137402b ("PM / QOS: Pass request type to dev_pm_qos_read_value()")

I applied the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 4 Jul 2019 19:36:25 +1000
Subject: [PATCH] PM / QOS: fix typos

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/pm_qos.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h
index 17132b10b233..2aebbc5b9950 100644
--- a/include/linux/pm_qos.h
+++ b/include/linux/pm_qos.h
@@ -202,7 +202,7 @@ static inline s32 __dev_pm_qos_resume_latency(struct device *dev)
 static inline s32 dev_pm_qos_read_value(struct device *dev,
 					enum dev_pm_qos_req_type type)
 {
-	switch type {
+	switch (type) {
 	case DEV_PM_QOS_RESUME_LATENCY:
 		return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT;
 	case DEV_PM_QOS_MIN_FREQUENCY:
@@ -227,7 +227,7 @@ static inline int dev_pm_qos_remove_request(struct dev_pm_qos_request *req)
 			{ return 0; }
 static inline int dev_pm_qos_add_notifier(struct device *dev,
 					  struct notifier_block *notifier,
-					  enum dev_pm_qos_req_type type);
+					  enum dev_pm_qos_req_type type)
 			{ return 0; }
 static inline int dev_pm_qos_remove_notifier(struct device *dev,
 					     struct notifier_block *notifier,
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2019-07-01  3:37 Stephen Rothwell
@ 2019-07-01  7:48 ` Viresh Kumar
  0 siblings, 0 replies; 110+ messages in thread
From: Viresh Kumar @ 2019-07-01  7:48 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, Linux Next Mailing List, Linux Kernel Mailing List

On 01-07-19, 13:37, Stephen Rothwell wrote:
> In file included from drivers/cpufreq/intel_pstate.c:11:
> drivers/cpufreq/intel_pstate.c: In function 'intel_pstate_update_max_freq':
> drivers/cpufreq/intel_pstate.c:912:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
>   new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                                ^~~~~~~~~~~

Yeah, that was a recent update and I missed this path completely.

> Caused by commit
> 
>   218208538ffe ("cpufreq: Add QoS requests for userspace constraints")

@Rafael: I hope merging below to this commit would be the right thing to do ?

-- 
viresh

-------------------------8<-------------------------
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 9da4dc33b716..99bcdb6d4d83 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1105,7 +1105,7 @@ static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy, unsigned int cp
        return ret;
 }
 
-static void refresh_frequency_limits(struct cpufreq_policy *policy)
+void refresh_frequency_limits(struct cpufreq_policy *policy)
 {
        struct cpufreq_policy new_policy;
 
@@ -1120,6 +1120,7 @@ static void refresh_frequency_limits(struct cpufreq_policy *policy)
 
        up_write(&policy->rwsem);
 }
+EXPORT_SYMBOL(refresh_frequency_limits);
 
 static void handle_update(struct work_struct *work)
 {
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index f2ff5de988c1..cc27d4c59dca 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -898,7 +898,6 @@ static void intel_pstate_update_policies(void)
 static void intel_pstate_update_max_freq(unsigned int cpu)
 {
        struct cpufreq_policy *policy = cpufreq_cpu_acquire(cpu);
-       struct cpufreq_policy new_policy;
        struct cpudata *cpudata;
 
        if (!policy)
@@ -908,11 +907,7 @@ static void intel_pstate_update_max_freq(unsigned int cpu)
        policy->cpuinfo.max_freq = global.turbo_disabled_mf ?
                        cpudata->pstate.max_freq : cpudata->pstate.turbo_freq;
 
-       memcpy(&new_policy, policy, sizeof(*policy));
-       new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
-       new_policy.min = min(policy->user_policy.min, new_policy.max);
-
-       cpufreq_set_policy(policy, &new_policy);
+       refresh_frequency_limits(policy);
 
        cpufreq_cpu_release(policy);
 }
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index dca2ae358542..d757a56a74dc 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -200,6 +200,7 @@ void cpufreq_cpu_release(struct cpufreq_policy *policy);
 int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu);
 int cpufreq_set_policy(struct cpufreq_policy *policy,
                       struct cpufreq_policy *new_policy);
+void refresh_frequency_limits(struct cpufreq_policy *policy);
 void cpufreq_update_policy(unsigned int cpu);
 void cpufreq_update_limits(unsigned int cpu);
 bool have_governor_per_policy(void);


^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2019-07-01  3:37 Stephen Rothwell
  2019-07-01  7:48 ` Viresh Kumar
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2019-07-01  3:37 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Viresh Kumar

[-- Attachment #1: Type: text/plain, Size: 11216 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from drivers/cpufreq/intel_pstate.c:11:
drivers/cpufreq/intel_pstate.c: In function 'intel_pstate_update_max_freq':
drivers/cpufreq/intel_pstate.c:912:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                               ^~~~~~~~~~~
include/linux/kernel.h:819:22: note: in definition of macro '__typecheck'
   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
                      ^
include/linux/kernel.h:843:24: note: in expansion of macro '__safe_cmp'
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^~~~~~~~~~
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:912:19: note: in expansion of macro 'min'
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                   ^~~
drivers/cpufreq/intel_pstate.c:912:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                               ^~~~~~~~~~~
include/linux/kernel.h:827:48: note: in definition of macro '__is_constexpr'
  (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
                                                ^
include/linux/kernel.h:833:25: note: in expansion of macro '__no_side_effects'
   (__typecheck(x, y) && __no_side_effects(x, y))
                         ^~~~~~~~~~~~~~~~~
include/linux/kernel.h:843:24: note: in expansion of macro '__safe_cmp'
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^~~~~~~~~~
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:912:19: note: in expansion of macro 'min'
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                   ^~~
drivers/cpufreq/intel_pstate.c:912:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                               ^~~~~~~~~~~
include/linux/kernel.h:835:27: note: in definition of macro '__cmp'
 #define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
                           ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:912:19: note: in expansion of macro 'min'
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                   ^~~
drivers/cpufreq/intel_pstate.c:912:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                               ^~~~~~~~~~~
include/linux/kernel.h:835:40: note: in definition of macro '__cmp'
 #define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
                                        ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:912:19: note: in expansion of macro 'min'
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                   ^~~
drivers/cpufreq/intel_pstate.c:912:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                               ^~~~~~~~~~~
include/linux/kernel.h:838:10: note: in definition of macro '__cmp_once'
   typeof(x) unique_x = (x);  \
          ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:912:19: note: in expansion of macro 'min'
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                   ^~~
drivers/cpufreq/intel_pstate.c:912:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                               ^~~~~~~~~~~
include/linux/kernel.h:838:25: note: in definition of macro '__cmp_once'
   typeof(x) unique_x = (x);  \
                         ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:912:19: note: in expansion of macro 'min'
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                   ^~~
include/linux/kernel.h:843:2: error: first argument to '__builtin_choose_expr' not a constant
  __builtin_choose_expr(__safe_cmp(x, y), \
  ^~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:912:19: note: in expansion of macro 'min'
  new_policy.max = min(policy->user_policy.max, policy->cpuinfo.max_freq);
                   ^~~
drivers/cpufreq/intel_pstate.c:913:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                               ^~~~~~~~~~~
include/linux/kernel.h:819:22: note: in definition of macro '__typecheck'
   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
                      ^
include/linux/kernel.h:843:24: note: in expansion of macro '__safe_cmp'
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^~~~~~~~~~
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:913:19: note: in expansion of macro 'min'
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                   ^~~
drivers/cpufreq/intel_pstate.c:913:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                               ^~~~~~~~~~~
include/linux/kernel.h:827:48: note: in definition of macro '__is_constexpr'
  (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
                                                ^
include/linux/kernel.h:833:25: note: in expansion of macro '__no_side_effects'
   (__typecheck(x, y) && __no_side_effects(x, y))
                         ^~~~~~~~~~~~~~~~~
include/linux/kernel.h:843:24: note: in expansion of macro '__safe_cmp'
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^~~~~~~~~~
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:913:19: note: in expansion of macro 'min'
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                   ^~~
drivers/cpufreq/intel_pstate.c:913:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                               ^~~~~~~~~~~
include/linux/kernel.h:835:27: note: in definition of macro '__cmp'
 #define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
                           ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:913:19: note: in expansion of macro 'min'
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                   ^~~
drivers/cpufreq/intel_pstate.c:913:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                               ^~~~~~~~~~~
include/linux/kernel.h:835:40: note: in definition of macro '__cmp'
 #define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
                                        ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:913:19: note: in expansion of macro 'min'
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                   ^~~
drivers/cpufreq/intel_pstate.c:913:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                               ^~~~~~~~~~~
include/linux/kernel.h:838:10: note: in definition of macro '__cmp_once'
   typeof(x) unique_x = (x);  \
          ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:913:19: note: in expansion of macro 'min'
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                   ^~~
drivers/cpufreq/intel_pstate.c:913:31: error: 'struct cpufreq_policy' has no member named 'user_policy'; did you mean 'last_policy'?
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                               ^~~~~~~~~~~
include/linux/kernel.h:838:25: note: in definition of macro '__cmp_once'
   typeof(x) unique_x = (x);  \
                         ^
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:913:19: note: in expansion of macro 'min'
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                   ^~~
include/linux/kernel.h:843:2: error: first argument to '__builtin_choose_expr' not a constant
  __builtin_choose_expr(__safe_cmp(x, y), \
  ^~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:852:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:913:19: note: in expansion of macro 'min'
  new_policy.min = min(policy->user_policy.min, new_policy.max);
                   ^~~

Caused by commit

  218208538ffe ("cpufreq: Add QoS requests for userspace constraints")

from the pm tree interacting with commit

  9083e4986124 ("cpufreq: intel_pstate: Update max frequency on global turbo changes")

from Linus' tree.

I have used the pm tree from next-20190628 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2018-05-24 14:16 Mark Brown
  0 siblings, 0 replies; 110+ messages in thread
From: Mark Brown @ 2018-05-24 14:16 UTC (permalink / raw)
  To: Rafael J. Wysocki, Zhang Rui, Wendy Wang, Catalin Marinas, Will Deacon
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (arm64 defconfig)
failed like this:

drivers/acpi/ec.o: In function `acpi_ec_dispatch_gpe':
/home/broonie/next/next/drivers/acpi/ec.c:1040: undefined reference to `acpi_dispatch_gpe'
/home/broonie/next/next/drivers/acpi/ec.c:1040:(.text+0x228c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `acpi_dispatch_gpe'

Probably caused by commit

  8f81c457105b5d4 ("ACPI: EC: Dispatch the EC GPE directly on s2idle wake")

(though the symbol appears to be there and like it should be built and
the relocation warning looks funky...).  I've used the PM tree from the
last -next.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-09-14  4:27 Stephen Rothwell
@ 2016-09-14 21:38 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2016-09-14 21:38 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Krzysztof Kozlowski, MyungJoo Ham,
	Chanwoo Choi

On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
>   clk_set_min_rate(tegra->emc_clock, rate);
>   ^
> 
> Caused by commit
> 
>   797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
> 
> clk_set_min_rate() usage depends on CONFIG_HAVE_CLK.
> 
> I added the following for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 14 Sep 2016 14:22:25 +1000
> Subject: [PATCH] partial revert of 797da5598f3a ("PM / devfreq: Add
>  COMPILE_TEST for build coverage")
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/devfreq/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index cadd56e50b2c..93b6ada06676 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  
>  config ARM_TEGRA_DEVFREQ
>  	tristate "Tegra DEVFREQ Driver"
> -	depends on ARCH_TEGRA_124_SOC || COMPILE_TEST
> +	depends on ARCH_TEGRA_124_SOC
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select PM_OPP
>  	help

I've just gone ahead and applied it.

Thanks Stephen!

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2016-09-14  4:27 Stephen Rothwell
  2016-09-14 21:38 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2016-09-14  4:27 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Krzysztof Kozlowski, MyungJoo Ham,
	Chanwoo Choi

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
  clk_set_min_rate(tegra->emc_clock, rate);
  ^

Caused by commit

  797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")

clk_set_min_rate() usage depends on CONFIG_HAVE_CLK.

I added the following for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 14 Sep 2016 14:22:25 +1000
Subject: [PATCH] partial revert of 797da5598f3a ("PM / devfreq: Add
 COMPILE_TEST for build coverage")

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/devfreq/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index cadd56e50b2c..93b6ada06676 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
 
 config ARM_TEGRA_DEVFREQ
 	tristate "Tegra DEVFREQ Driver"
-	depends on ARCH_TEGRA_124_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA_124_SOC
 	select DEVFREQ_GOV_SIMPLE_ONDEMAND
 	select PM_OPP
 	help
-- 
2.8.1




-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-07-22 12:08   ` Rafael J. Wysocki
@ 2016-07-22 12:16     ` Fengguang Wu
  0 siblings, 0 replies; 110+ messages in thread
From: Fengguang Wu @ 2016-07-22 12:16 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Steve Muckle, Stephen Rothwell, linux-next, linux-kernel, kbuild-all

On Fri, Jul 22, 2016 at 02:08:35PM +0200, Rafael J. Wysocki wrote:
>On Thursday, July 21, 2016 07:26:28 PM Steve Muckle wrote:
>> On Fri, Jul 22, 2016 at 11:56:20AM +1000, Stephen Rothwell wrote:
>> > Hi Rafael,
>> >
>> > After merging the pm tree, today's linux-next build (arm
>> > multi_v7_defconfig) failed like this:
>> >
>> > ERROR: "cpufreq_driver_resolve_freq" [kernel/sched/cpufreq_schedutil.ko] undefined!
>> >
>> > Caused by commit
>> >
>> >   5cbea46984d6 ("cpufreq: schedutil: map raw required frequency to driver frequency")
>> >
>> > I used the pm tree from next-20160721 for today.
>>
>> Sorry - I have just sent a patch to address this.
>
>OK, thanks!
>
>Interestingly enough, that hasn't been caught by 0-day.

Sorry it's bisected to a merge commit, hence not reported..
It should be better handled in future.

tree:   git://internal_merge_and_test_tree devel-catchup-201607140443
head:   5f2b635268c560fa7a531e0bdc7765800287ab0f
commit: a868e9fc557aa84ea307d1a394a161420ac20498 [2/12] Merge 'linux-review/Steve-Muckle/cpufreq-avoid-redundant-driver-calls-in-schedutil/20160714-042907' into devel-catchup-201607140443
config: i386-randconfig-s1-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        git checkout a868e9fc557aa84ea307d1a394a161420ac20498
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> ERROR: "cpufreq_driver_resolve_freq" [kernel/sched/cpufreq_schedutil.ko] undefined!

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-07-22  2:26 ` Steve Muckle
@ 2016-07-22 12:08   ` Rafael J. Wysocki
  2016-07-22 12:16     ` Fengguang Wu
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2016-07-22 12:08 UTC (permalink / raw)
  To: Steve Muckle
  Cc: Stephen Rothwell, linux-next, linux-kernel, Fengguang Wu, kbuild-all

On Thursday, July 21, 2016 07:26:28 PM Steve Muckle wrote:
> On Fri, Jul 22, 2016 at 11:56:20AM +1000, Stephen Rothwell wrote:
> > Hi Rafael,
> > 
> > After merging the pm tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > ERROR: "cpufreq_driver_resolve_freq" [kernel/sched/cpufreq_schedutil.ko] undefined!
> > 
> > Caused by commit
> > 
> >   5cbea46984d6 ("cpufreq: schedutil: map raw required frequency to driver frequency")
> > 
> > I used the pm tree from next-20160721 for today.
> 
> Sorry - I have just sent a patch to address this.

OK, thanks!

Interestingly enough, that hasn't been caught by 0-day.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-07-22  1:56 Stephen Rothwell
@ 2016-07-22  2:26 ` Steve Muckle
  2016-07-22 12:08   ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Steve Muckle @ 2016-07-22  2:26 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, linux-next, linux-kernel, Steve Muckle

On Fri, Jul 22, 2016 at 11:56:20AM +1000, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> ERROR: "cpufreq_driver_resolve_freq" [kernel/sched/cpufreq_schedutil.ko] undefined!
> 
> Caused by commit
> 
>   5cbea46984d6 ("cpufreq: schedutil: map raw required frequency to driver frequency")
> 
> I used the pm tree from next-20160721 for today.

Sorry - I have just sent a patch to address this.

thanks,
Steve

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2016-07-22  1:56 Stephen Rothwell
  2016-07-22  2:26 ` Steve Muckle
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2016-07-22  1:56 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Steve Muckle

Hi Rafael,

After merging the pm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: "cpufreq_driver_resolve_freq" [kernel/sched/cpufreq_schedutil.ko] undefined!

Caused by commit

  5cbea46984d6 ("cpufreq: schedutil: map raw required frequency to driver frequency")

I used the pm tree from next-20160721 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-07-11  5:29   ` Stephen Rothwell
@ 2016-07-11 12:57     ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2016-07-11 12:57 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mika Westerberg, linux-next, linux-kernel, Octavian Purdila

On Monday, July 11, 2016 03:29:55 PM Stephen Rothwell wrote:
> Hi Mika,
> 
> On Mon, 11 Jul 2016 07:48:17 +0300 Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> >
> > Looks like it is the module name (configfs.o) that confuses modpost or
> > linker. The below patch fixes it for me.
> 
> That makes sense.  Thanks.

OK, I'll apply the Mika's patch.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-07-11  4:48 ` Mika Westerberg
@ 2016-07-11  5:29   ` Stephen Rothwell
  2016-07-11 12:57     ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2016-07-11  5:29 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: Rafael J. Wysocki, linux-next, linux-kernel, Octavian Purdila

Hi Mika,

On Mon, 11 Jul 2016 07:48:17 +0300 Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
>
> Looks like it is the module name (configfs.o) that confuses modpost or
> linker. The below patch fixes it for me.

That makes sense.  Thanks.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-07-11  1:46 Stephen Rothwell
@ 2016-07-11  4:48 ` Mika Westerberg
  2016-07-11  5:29   ` Stephen Rothwell
  0 siblings, 1 reply; 110+ messages in thread
From: Mika Westerberg @ 2016-07-11  4:48 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, linux-next, linux-kernel, Octavian Purdila

On Mon, Jul 11, 2016 at 11:46:53AM +1000, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> ERROR: "config_item_put" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> ERROR: "config_item_init_type_name" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> 
> ... and many more ...
> 
> Presumably (maybe?) caused by commit
> 
>   0bf54fcd9504 ("ACPI: add support for configfs")
> 
> though it is not obvious why this should be a problem.

Looks like it is the module name (configfs.o) that confuses modpost or
linker. The below patch fixes it for me.

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH] ACPI: Rename configfs.c to acpi_configfs.c to prevent link error

If we compile ACPI configfs.c as module it will confuse the linker as it
hides symbols from the actual configfs:

Kernel: arch/x86/boot/bzImage is ready  (#1236)
  MODPOST 5739 modules
ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
...

Prevent these by renaming the file to acpi_configfs.c instead.

Reported-by: Scott Lawson <scott.lawson@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/acpi/Makefile                        | 2 +-
 drivers/acpi/{configfs.c => acpi_configfs.c} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/acpi/{configfs.c => acpi_configfs.c} (100%)

diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 1dc2173ad8d0..f72a83df1cf3 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -99,6 +99,6 @@ obj-$(CONFIG_ACPI_EXTLOG)	+= acpi_extlog.o
 obj-$(CONFIG_PMIC_OPREGION)	+= pmic/intel_pmic.o
 obj-$(CONFIG_CRC_PMIC_OPREGION) += pmic/intel_pmic_crc.o
 obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o
-obj-$(CONFIG_ACPI_CONFIGFS)	+= configfs.o
+obj-$(CONFIG_ACPI_CONFIGFS)	+= acpi_configfs.o
 
 video-objs			+= acpi_video.o video_detect.o
diff --git a/drivers/acpi/configfs.c b/drivers/acpi/acpi_configfs.c
similarity index 100%
rename from drivers/acpi/configfs.c
rename to drivers/acpi/acpi_configfs.c
-- 
2.8.1

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2016-07-11  1:46 Stephen Rothwell
  2016-07-11  4:48 ` Mika Westerberg
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2016-07-11  1:46 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Octavian Purdila, Mika Westerberg

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
ERROR: "config_item_put" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
ERROR: "config_item_init_type_name" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!

... and many more ...

Presumably (maybe?) caused by commit

  0bf54fcd9504 ("ACPI: add support for configfs")

though it is not obvious why this should be a problem.

I have used the version of the pm tree from next-20160708 for today.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2016-06-02  2:12 Stephen Rothwell
  0 siblings, 0 replies; 110+ messages in thread
From: Stephen Rothwell @ 2016-06-02  2:12 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

arch/powerpc/platforms/cell/cpufreq_spudemand.c: In function 'spu_gov_govern':
arch/powerpc/platforms/cell/cpufreq_spudemand.c:98:7: error: 'CPUFREQ_GOV_START' undeclared (first use in this function)
  case CPUFREQ_GOV_START:
       ^
arch/powerpc/platforms/cell/cpufreq_spudemand.c:98:7: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/platforms/cell/cpufreq_spudemand.c:124:7: error: 'CPUFREQ_GOV_STOP' undeclared (first use in this function)
  case CPUFREQ_GOV_STOP:
       ^
arch/powerpc/platforms/cell/cpufreq_spudemand.c: At top level:
arch/powerpc/platforms/cell/cpufreq_spudemand.c:142:2: error: unknown field 'governor' specified in initializer
  .governor = spu_gov_govern,
  ^
arch/powerpc/platforms/cell/cpufreq_spudemand.c:142:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .governor = spu_gov_govern,
              ^
arch/powerpc/platforms/cell/cpufreq_spudemand.c:142:14: note: (near initialization for 'spu_governor.init')

Caused by commit

  c1596d383aef ("cpufreq: governor: Get rid of governor events")

I have used the pm tree from next-20160601 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2016-04-01  1:27 Stephen Rothwell
@ 2016-04-01 20:51 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2016-04-01 20:51 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

On Friday, April 01, 2016 12:27:43 PM Stephen Rothwell wrote:
> Hi Rafael,

Hi Stephen,

> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "__tracepoint_cpu_frequency" [kernel/sched/cpufreq_schedutil.ko] undefined!
> 
> Caused by commit
> 
>   d4913d2934b5 ("cpufreq: schedutil: New governor based on scheduler utilization data")
> 
> I have used the pm tree from next-20160331 for today.

Sorry for the breakage.  It hasn't been caught by 0-day somehow, not sure why.

Will fix shortly.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2016-04-01  1:27 Stephen Rothwell
  2016-04-01 20:51 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2016-04-01  1:27 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "__tracepoint_cpu_frequency" [kernel/sched/cpufreq_schedutil.ko] undefined!

Caused by commit

  d4913d2934b5 ("cpufreq: schedutil: New governor based on scheduler utilization data")

I have used the pm tree from next-20160331 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-12-09  1:54 Stephen Rothwell
@ 2015-12-09  2:00 ` Viresh Kumar
  0 siblings, 0 replies; 110+ messages in thread
From: Viresh Kumar @ 2015-12-09  2:00 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, linux-next, linux-kernel, Ashwin Chaugule

On 09-12-15, 12:54, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "gov_cancel_work" [drivers/cpufreq/cpufreq_ondemand.ko] undefined!
> 
> Caused by commit
> 
>   68e115b19a01 ("cpufreq: governor: replace per-cpu delayed work with timers")
> 
> I have used the pm tree from next-20151208 for today.

Yeah, it missed this stupid change. Sorry about that.

diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
index 948771f169d2..4de12fd35b1f 100644
--- a/drivers/cpufreq/cpufreq_governor.c
+++ b/drivers/cpufreq/cpufreq_governor.c
@@ -205,6 +205,7 @@ void gov_cancel_work(struct cpu_common_dbs_info *shared)
        gov_cancel_timers(shared->policy);
        atomic_set(&shared->skip_work, 0);
 }
+EXPORT_SYMBOL_GPL(gov_cancel_work);
 
 /* Will return if we need to evaluate cpu load again or not */
 static bool need_load_eval(struct cpu_common_dbs_info *shared,


Rafael, I am resending the original patch with this change.

-- 
viresh

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2015-12-09  1:54 Stephen Rothwell
  2015-12-09  2:00 ` Viresh Kumar
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2015-12-09  1:54 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Viresh Kumar, Ashwin Chaugule

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "gov_cancel_work" [drivers/cpufreq/cpufreq_ondemand.ko] undefined!

Caused by commit

  68e115b19a01 ("cpufreq: governor: replace per-cpu delayed work with timers")

I have used the pm tree from next-20151208 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-11-01  6:57 Stephen Rothwell
@ 2015-11-02  0:37 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2015-11-02  0:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Olof Johansson, Arnd Bergmann, linux-arm-kernel, linux-next,
	linux-kernel, Matthias Brugger, Marc Zyngier

On Sunday, November 01, 2015 05:57:18 PM Stephen Rothwell wrote:
> Hi Rafael,

Hi,

Thanks for the patch!

> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> arch/arm/mach-mediatek/mediatek.c: In function 'mediatek_timer_init':
> arch/arm/mach-mediatek/mediatek.c:43:2: error: implicit declaration of function 'clocksource_of_init' [-Werror=implicit-function-declaration]
>   clocksource_of_init();
>   ^
> 
> Caused by commit
> 
>   3722ed2380ad ("clocksource: cosmetic: Drop OF 'dependency' from symbols")
> 
> interacting with commit
> 
>   9821e545c5e0 ("ARM: mediatek: enable gpt6 on boot up to make arch timer working")
> 
> from the arm-soc tree.
> 
> I applied the following merge fix patch for today (someone should tell
> Linus when theese trees are merged):

I'll do that.

Thanks,
Rafael


^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2015-11-01  6:57 Stephen Rothwell
  2015-11-02  0:37 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2015-11-01  6:57 UTC (permalink / raw)
  To: Rafael J. Wysocki, Olof Johansson, Arnd Bergmann, linux-arm-kernel
  Cc: linux-next, linux-kernel, Matthias Brugger, Marc Zyngier

Hi Rafael,

After merging the pm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arch/arm/mach-mediatek/mediatek.c: In function 'mediatek_timer_init':
arch/arm/mach-mediatek/mediatek.c:43:2: error: implicit declaration of function 'clocksource_of_init' [-Werror=implicit-function-declaration]
  clocksource_of_init();
  ^

Caused by commit

  3722ed2380ad ("clocksource: cosmetic: Drop OF 'dependency' from symbols")

interacting with commit

  9821e545c5e0 ("ARM: mediatek: enable gpt6 on boot up to make arch timer working")

from the arm-soc tree.

I applied the following merge fix patch for today (someone should tell
Linus when theese trees are merged):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sun, 1 Nov 2015 17:52:26 +1100
Subject: [PATCH] ARM: mediatek: fixup for clocksource_of_init API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/arm/mach-mediatek/mediatek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
index 19dc738c1abc..c88a47a3dc37 100644
--- a/arch/arm/mach-mediatek/mediatek.c
+++ b/arch/arm/mach-mediatek/mediatek.c
@@ -40,7 +40,7 @@ static void __init mediatek_timer_init(void)
 	}
 
 	of_clk_init(NULL);
-	clocksource_of_init();
+	clocksource_probe();
 };
 
 static const char * const mediatek_board_dt_compat[] = {
-- 
2.6.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-04-13  4:24 Stephen Rothwell
  2015-04-13 12:06 ` Rafael J. Wysocki
@ 2015-04-15  2:30 ` Stephen Rothwell
  1 sibling, 0 replies; 110+ messages in thread
From: Stephen Rothwell @ 2015-04-15  2:30 UTC (permalink / raw)
  To: Len Brown
  Cc: Rafael J. Wysocki, linux-next, linux-kernel, Dasaratharaman Chandramouli

[-- Attachment #1: Type: text/plain, Size: 2841 bytes --]

Hi Len,

On Mon, 13 Apr 2015 14:24:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> In file included from arch/x86/include/asm/msr.h:131:0,
>                  from arch/x86/include/asm/processor.h:20,
>                  from arch/x86/include/asm/thread_info.h:23,
>                  from include/linux/thread_info.h:54,
>                  from arch/x86/include/asm/preempt.h:6,
>                  from include/linux/preempt.h:18,
>                  from include/linux/smp.h:55,
>                  from include/linux/kernel_stat.h:4,
>                  from drivers/cpufreq/intel_pstate.c:14:
> drivers/cpufreq/intel_pstate.c: In function 'knl_get_turbo_pstate':
> drivers/cpufreq/intel_pstate.c:622:9: error: 'MSR_NHM_TURBO_RATIO_LIMIT' undeclared (first use in this function)
>   rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
>          ^
> arch/x86/include/asm/paravirt.h:153:26: note: in definition of macro 'rdmsrl'
>   val = paravirt_read_msr(msr, &_err); \
>                           ^
> drivers/cpufreq/intel_pstate.c:622:9: note: each undeclared identifier is reported only once for each function it appears in
>   rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
>          ^
> arch/x86/include/asm/paravirt.h:153:26: note: in definition of macro 'rdmsrl'
>   val = paravirt_read_msr(msr, &_err); \
>                           ^
> 
> Caused by commit 6acfd09a439a ("tools/power turbostat: define and dump
> MSR_TURBO_RATIO_LIMIT2") interacting with commit b34ef932d79a
> ("intel_pstate: Knights Landing support").  This should have been
> resolved in commit 08fb40f3fbeb ("Merge branches 'powercap' and
> 'pm-tools'").
> 
> I have added the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 13 Apr 2015 14:11:11 +1000
> Subject: [PATCH] intel_pstate: fix bad merge (MSR_NHM_TURBO_RATIO_LIMIT rename)
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 875154d5f60b..5ecd2689a8fc 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -619,7 +619,7 @@ static int knl_get_turbo_pstate(void)
>  	u64 value;
>  	int nont, ret;
>  
> -	rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
> +	rdmsrl(MSR_TURBO_RATIO_LIMIT, value);
>  	nont = core_get_max_pstate();
>  	ret = (((value) >> 8) & 0xFF);
>  	if (ret <= nont)

This is now required after the merge of the idle tree (since the code
was removed from the pm tree).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-04-13  4:24 Stephen Rothwell
@ 2015-04-13 12:06 ` Rafael J. Wysocki
  2015-04-15  2:30 ` Stephen Rothwell
  1 sibling, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2015-04-13 12:06 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Len Brown, Dasaratharaman Chandramouli

On Monday, April 13, 2015 02:24:42 PM Stephen Rothwell wrote:
> 
> --Sig_/wQd_Ak5TvD_LSZFUNsW5WJr
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> In file included from arch/x86/include/asm/msr.h:131:0,
>                  from arch/x86/include/asm/processor.h:20,
>                  from arch/x86/include/asm/thread_info.h:23,
>                  from include/linux/thread_info.h:54,
>                  from arch/x86/include/asm/preempt.h:6,
>                  from include/linux/preempt.h:18,
>                  from include/linux/smp.h:55,
>                  from include/linux/kernel_stat.h:4,
>                  from drivers/cpufreq/intel_pstate.c:14:
> drivers/cpufreq/intel_pstate.c: In function 'knl_get_turbo_pstate':
> drivers/cpufreq/intel_pstate.c:622:9: error: 'MSR_NHM_TURBO_RATIO_LIMIT' un=
> declared (first use in this function)
>   rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
>          ^
> arch/x86/include/asm/paravirt.h:153:26: note: in definition of macro 'rdmsr=
> l'
>   val =3D paravirt_read_msr(msr, &_err); \
>                           ^
> drivers/cpufreq/intel_pstate.c:622:9: note: each undeclared identifier is r=
> eported only once for each function it appears in
>   rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
>          ^
> arch/x86/include/asm/paravirt.h:153:26: note: in definition of macro 'rdmsr=
> l'
>   val =3D paravirt_read_msr(msr, &_err); \
>                           ^
> 
> Caused by commit 6acfd09a439a ("tools/power turbostat: define and dump
> MSR_TURBO_RATIO_LIMIT2") interacting with commit b34ef932d79a
> ("intel_pstate: Knights Landing support").  This should have been
> resolved in commit 08fb40f3fbeb ("Merge branches 'powercap' and
> 'pm-tools'").

Right, will fix.

Thanks and sorry for the breakage.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2015-04-13  4:24 Stephen Rothwell
  2015-04-13 12:06 ` Rafael J. Wysocki
  2015-04-15  2:30 ` Stephen Rothwell
  0 siblings, 2 replies; 110+ messages in thread
From: Stephen Rothwell @ 2015-04-13  4:24 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Len Brown, Dasaratharaman Chandramouli

[-- Attachment #1: Type: text/plain, Size: 2535 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from arch/x86/include/asm/msr.h:131:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/thread_info.h:23,
                 from include/linux/thread_info.h:54,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:18,
                 from include/linux/smp.h:55,
                 from include/linux/kernel_stat.h:4,
                 from drivers/cpufreq/intel_pstate.c:14:
drivers/cpufreq/intel_pstate.c: In function 'knl_get_turbo_pstate':
drivers/cpufreq/intel_pstate.c:622:9: error: 'MSR_NHM_TURBO_RATIO_LIMIT' undeclared (first use in this function)
  rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
         ^
arch/x86/include/asm/paravirt.h:153:26: note: in definition of macro 'rdmsrl'
  val = paravirt_read_msr(msr, &_err); \
                          ^
drivers/cpufreq/intel_pstate.c:622:9: note: each undeclared identifier is reported only once for each function it appears in
  rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
         ^
arch/x86/include/asm/paravirt.h:153:26: note: in definition of macro 'rdmsrl'
  val = paravirt_read_msr(msr, &_err); \
                          ^

Caused by commit 6acfd09a439a ("tools/power turbostat: define and dump
MSR_TURBO_RATIO_LIMIT2") interacting with commit b34ef932d79a
("intel_pstate: Knights Landing support").  This should have been
resolved in commit 08fb40f3fbeb ("Merge branches 'powercap' and
'pm-tools'").

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 13 Apr 2015 14:11:11 +1000
Subject: [PATCH] intel_pstate: fix bad merge (MSR_NHM_TURBO_RATIO_LIMIT rename)

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/cpufreq/intel_pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 875154d5f60b..5ecd2689a8fc 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -619,7 +619,7 @@ static int knl_get_turbo_pstate(void)
 	u64 value;
 	int nont, ret;
 
-	rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value);
+	rdmsrl(MSR_TURBO_RATIO_LIMIT, value);
 	nont = core_get_max_pstate();
 	ret = (((value) >> 8) & 0xFF);
 	if (ret <= nont)
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09 15:21           ` Jiang Liu
@ 2015-02-09 15:50             ` Lorenzo Pieralisi
  0 siblings, 0 replies; 110+ messages in thread
From: Lorenzo Pieralisi @ 2015-02-09 15:50 UTC (permalink / raw)
  To: Jiang Liu
  Cc: Rafael J. Wysocki, Stephen Rothwell, Bjorn Helgaas, linux-next,
	linux-kernel

On Mon, Feb 09, 2015 at 03:21:25PM +0000, Jiang Liu wrote:
> On 2015/2/9 23:10, Rafael J. Wysocki wrote:
> > On Monday, February 09, 2015 06:23:40 AM Lorenzo Pieralisi wrote:
> >> On Mon, Feb 09, 2015 at 05:36:07AM +0000, Jiang Liu wrote:
> >>> Hi Rafael and Lorenzo,
> >>> 	With more closer review, I suspect statement "kfree(bus_range)"
> >>> in commit d2be00c0fb5a ("of/pci: Free resources on failure in
> >>> of_pci_get_host_bridge_resources()") may cause double free of bus_range
> >>> because bus_range will also be freed by kfree(window->res);
> >>
> >> Gah, my bad, you are right, sorry I missed that. Please let me know
> >> how you prefer fixing that, you could remove that line as part
> >> of the merge commit, or I can send you a patch to apply on top of it,
> >> it is a trivial one-line removal.
> > 
> > I re-did the merge.
> > 
> > Please have a look at my linux-next branch again and let me know if that's OK
> > with everybody.
> I'm OK with new merging commit.

Yes, it is ok now, thank you both !!

Lorenzo


^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09 15:10         ` Rafael J. Wysocki
@ 2015-02-09 15:21           ` Jiang Liu
  2015-02-09 15:50             ` Lorenzo Pieralisi
  0 siblings, 1 reply; 110+ messages in thread
From: Jiang Liu @ 2015-02-09 15:21 UTC (permalink / raw)
  To: Rafael J. Wysocki, Lorenzo Pieralisi
  Cc: Stephen Rothwell, Bjorn Helgaas, linux-next, linux-kernel

On 2015/2/9 23:10, Rafael J. Wysocki wrote:
> On Monday, February 09, 2015 06:23:40 AM Lorenzo Pieralisi wrote:
>> On Mon, Feb 09, 2015 at 05:36:07AM +0000, Jiang Liu wrote:
>>> Hi Rafael and Lorenzo,
>>> 	With more closer review, I suspect statement "kfree(bus_range)"
>>> in commit d2be00c0fb5a ("of/pci: Free resources on failure in
>>> of_pci_get_host_bridge_resources()") may cause double free of bus_range
>>> because bus_range will also be freed by kfree(window->res);
>>
>> Gah, my bad, you are right, sorry I missed that. Please let me know
>> how you prefer fixing that, you could remove that line as part
>> of the merge commit, or I can send you a patch to apply on top of it,
>> it is a trivial one-line removal.
> 
> I re-did the merge.
> 
> Please have a look at my linux-next branch again and let me know if that's OK
> with everybody.
I'm OK with new merging commit.


^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09  6:23       ` Lorenzo Pieralisi
@ 2015-02-09 15:10         ` Rafael J. Wysocki
  2015-02-09 15:21           ` Jiang Liu
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2015-02-09 15:10 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Jiang Liu
  Cc: Stephen Rothwell, Bjorn Helgaas, linux-next, linux-kernel

On Monday, February 09, 2015 06:23:40 AM Lorenzo Pieralisi wrote:
> On Mon, Feb 09, 2015 at 05:36:07AM +0000, Jiang Liu wrote:
> > Hi Rafael and Lorenzo,
> > 	With more closer review, I suspect statement "kfree(bus_range)"
> > in commit d2be00c0fb5a ("of/pci: Free resources on failure in
> > of_pci_get_host_bridge_resources()") may cause double free of bus_range
> > because bus_range will also be freed by kfree(window->res);
> 
> Gah, my bad, you are right, sorry I missed that. Please let me know
> how you prefer fixing that, you could remove that line as part
> of the merge commit, or I can send you a patch to apply on top of it,
> it is a trivial one-line removal.

I re-did the merge.

Please have a look at my linux-next branch again and let me know if that's OK
with everybody.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09  5:36     ` Jiang Liu
@ 2015-02-09  6:23       ` Lorenzo Pieralisi
  2015-02-09 15:10         ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Lorenzo Pieralisi @ 2015-02-09  6:23 UTC (permalink / raw)
  To: Jiang Liu
  Cc: Rafael J. Wysocki, Stephen Rothwell, Bjorn Helgaas, linux-next,
	linux-kernel

On Mon, Feb 09, 2015 at 05:36:07AM +0000, Jiang Liu wrote:
> Hi Rafael and Lorenzo,
> 	With more closer review, I suspect statement "kfree(bus_range)"
> in commit d2be00c0fb5a ("of/pci: Free resources on failure in
> of_pci_get_host_bridge_resources()") may cause double free of bus_range
> because bus_range will also be freed by kfree(window->res);

Gah, my bad, you are right, sorry I missed that. Please let me know
how you prefer fixing that, you could remove that line as part
of the merge commit, or I can send you a patch to apply on top of it,
it is a trivial one-line removal.

Thanks,
Lorenzo

> Regards!
> Gerry
> 
> On 2015/2/9 11:22, Rafael J. Wysocki wrote:
> > On Monday, February 09, 2015 10:53:05 AM Jiang Liu wrote:
> >>
> >> On 2015/2/9 10:26, Stephen Rothwell wrote:
> >>> Hi Rafael,
> > 
> > [cut]
> > 
> >>>                ^
> >>>
> >>> Caused by commit 14d76b68f281 ("PCI: Use common resource list
> >>> management code instead of private implementation") interacting with
> >>> commit d2be00c0fb5a ("of/pci: Free resources on failure in
> >>> of_pci_get_host_bridge_resources()") from the pci tree.
> >>>
> >>> I applied the following merge fix patch (which may need more work?).
> >> Hi Stephen,
> >> 	Thanks for fixing it and there should no more work needed.
> > 
> > Can you please have a look at my linux-next branch now and see if the code
> > is correct in there as well?
> > 
> > Rafael
> > 
> 


^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09  3:22   ` Rafael J. Wysocki
@ 2015-02-09  5:36     ` Jiang Liu
  2015-02-09  6:23       ` Lorenzo Pieralisi
  0 siblings, 1 reply; 110+ messages in thread
From: Jiang Liu @ 2015-02-09  5:36 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, Bjorn Helgaas, linux-next, linux-kernel,
	Lorenzo Pieralisi

Hi Rafael and Lorenzo,
	With more closer review, I suspect statement "kfree(bus_range)"
in commit d2be00c0fb5a ("of/pci: Free resources on failure in
of_pci_get_host_bridge_resources()") may cause double free of bus_range
because bus_range will also be freed by kfree(window->res);
Regards!
Gerry

On 2015/2/9 11:22, Rafael J. Wysocki wrote:
> On Monday, February 09, 2015 10:53:05 AM Jiang Liu wrote:
>>
>> On 2015/2/9 10:26, Stephen Rothwell wrote:
>>> Hi Rafael,
> 
> [cut]
> 
>>>                ^
>>>
>>> Caused by commit 14d76b68f281 ("PCI: Use common resource list
>>> management code instead of private implementation") interacting with
>>> commit d2be00c0fb5a ("of/pci: Free resources on failure in
>>> of_pci_get_host_bridge_resources()") from the pci tree.
>>>
>>> I applied the following merge fix patch (which may need more work?).
>> Hi Stephen,
>> 	Thanks for fixing it and there should no more work needed.
> 
> Can you please have a look at my linux-next branch now and see if the code
> is correct in there as well?
> 
> Rafael
> 

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09  3:19 ` Rafael J. Wysocki
@ 2015-02-09  3:53   ` Lorenzo Pieralisi
  0 siblings, 0 replies; 110+ messages in thread
From: Lorenzo Pieralisi @ 2015-02-09  3:53 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, Bjorn Helgaas, linux-next, linux-kernel, Jiang Liu

On Mon, Feb 09, 2015 at 03:19:33AM +0000, Rafael J. Wysocki wrote:
> On Monday, February 09, 2015 01:26:42 PM Stephen Rothwell wrote:
> > Hi Rafael,
> > 
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > In file included from drivers/of/of_pci.c:1:0:
> > drivers/of/of_pci.c: In function 'of_pci_get_host_bridge_resources':
> > include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
> >   for (pos = list_first_entry(head, typeof(*pos), member); \
> >                                            ^
> 
> [cut]
> 
> > 
> > Caused by commit 14d76b68f281 ("PCI: Use common resource list
> > management code instead of private implementation") interacting with
> > commit d2be00c0fb5a ("of/pci: Free resources on failure in
> > of_pci_get_host_bridge_resources()") from the pci tree.
> 
> Thanks for identifying this!

Thank you !

> > I applied the following merge fix patch (which may need more work?).
> > Someone needs to remember to tell Linus about this fix (or similar)
> > when these trees get merged.
> 
> The patch looks correct to me, so I did the following.
> 
> I pulled the Bjorn's pci/host-generic branch that contained just that one
> commit which conflicted with the Gerry's one into my acpi-resources branch
> and folded the patch below into the merge.
> 

It looks fine to me, thank you.

Lorenzo

> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Mon, 9 Feb 2015 13:08:24 +1100
> > Subject: [PATCH] of/pci: fix up for "PCI: Use common resource list management
> >  code instead of private implementation"
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/of/of_pci.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c
> > index 60dc36c865b5..110fece2ff53 100644
> > --- a/drivers/of/of_pci.c
> > +++ b/drivers/of/of_pci.c
> > @@ -140,7 +140,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
> >  			unsigned char busno, unsigned char bus_max,
> >  			struct list_head *resources, resource_size_t *io_base)
> >  {
> > -	struct pci_host_bridge_window *window;
> > +	struct resource_entry *window;
> >  	struct resource *res;
> >  	struct resource *bus_range;
> >  	struct of_pci_range range;
> > @@ -226,7 +226,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
> >  conversion_failed:
> >  	kfree(res);
> >  parse_failed:
> > -	list_for_each_entry(window, resources, list)
> > +	resource_list_for_each_entry(window, resources)
> >  		kfree(window->res);
> >  	pci_free_resource_list(resources);
> >  	kfree(bus_range);
> > 
> 
> -- 
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.




^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09  2:53 ` Jiang Liu
@ 2015-02-09  3:22   ` Rafael J. Wysocki
  2015-02-09  5:36     ` Jiang Liu
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2015-02-09  3:22 UTC (permalink / raw)
  To: Jiang Liu
  Cc: Stephen Rothwell, Bjorn Helgaas, linux-next, linux-kernel,
	Lorenzo Pieralisi

On Monday, February 09, 2015 10:53:05 AM Jiang Liu wrote:
> 
> On 2015/2/9 10:26, Stephen Rothwell wrote:
> > Hi Rafael,

[cut]

> >                ^
> > 
> > Caused by commit 14d76b68f281 ("PCI: Use common resource list
> > management code instead of private implementation") interacting with
> > commit d2be00c0fb5a ("of/pci: Free resources on failure in
> > of_pci_get_host_bridge_resources()") from the pci tree.
> > 
> > I applied the following merge fix patch (which may need more work?).
> Hi Stephen,
> 	Thanks for fixing it and there should no more work needed.

Can you please have a look at my linux-next branch now and see if the code
is correct in there as well?

Rafael


^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09  2:26 Stephen Rothwell
  2015-02-09  2:53 ` Jiang Liu
@ 2015-02-09  3:19 ` Rafael J. Wysocki
  2015-02-09  3:53   ` Lorenzo Pieralisi
  1 sibling, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2015-02-09  3:19 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Bjorn Helgaas, linux-next, linux-kernel, Lorenzo Pieralisi, Jiang Liu

[-- Attachment #1: Type: text/plain, Size: 2577 bytes --]

On Monday, February 09, 2015 01:26:42 PM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> In file included from drivers/of/of_pci.c:1:0:
> drivers/of/of_pci.c: In function 'of_pci_get_host_bridge_resources':
> include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>                                            ^

[cut]

> 
> Caused by commit 14d76b68f281 ("PCI: Use common resource list
> management code instead of private implementation") interacting with
> commit d2be00c0fb5a ("of/pci: Free resources on failure in
> of_pci_get_host_bridge_resources()") from the pci tree.

Thanks for identifying this!

> I applied the following merge fix patch (which may need more work?).
> Someone needs to remember to tell Linus about this fix (or similar)
> when these trees get merged.

The patch looks correct to me, so I did the following.

I pulled the Bjorn's pci/host-generic branch that contained just that one
commit which conflicted with the Gerry's one into my acpi-resources branch
and folded the patch below into the merge.

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 9 Feb 2015 13:08:24 +1100
> Subject: [PATCH] of/pci: fix up for "PCI: Use common resource list management
>  code instead of private implementation"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/of/of_pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c
> index 60dc36c865b5..110fece2ff53 100644
> --- a/drivers/of/of_pci.c
> +++ b/drivers/of/of_pci.c
> @@ -140,7 +140,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
>  			unsigned char busno, unsigned char bus_max,
>  			struct list_head *resources, resource_size_t *io_base)
>  {
> -	struct pci_host_bridge_window *window;
> +	struct resource_entry *window;
>  	struct resource *res;
>  	struct resource *bus_range;
>  	struct of_pci_range range;
> @@ -226,7 +226,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
>  conversion_failed:
>  	kfree(res);
>  parse_failed:
> -	list_for_each_entry(window, resources, list)
> +	resource_list_for_each_entry(window, resources)
>  		kfree(window->res);
>  	pci_free_resource_list(resources);
>  	kfree(bus_range);
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2015-02-09  2:26 Stephen Rothwell
@ 2015-02-09  2:53 ` Jiang Liu
  2015-02-09  3:22   ` Rafael J. Wysocki
  2015-02-09  3:19 ` Rafael J. Wysocki
  1 sibling, 1 reply; 110+ messages in thread
From: Jiang Liu @ 2015-02-09  2:53 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki, Bjorn Helgaas
  Cc: linux-next, linux-kernel, Lorenzo Pieralisi



On 2015/2/9 10:26, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> In file included from drivers/of/of_pci.c:1:0:
> drivers/of/of_pci.c: In function 'of_pci_get_host_bridge_resources':
> include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>                                            ^
> include/linux/kernel.h:799:18: note: in definition of macro 'container_of'
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                   ^
> include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
>   list_entry((ptr)->next, type, member)
>   ^
> include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> include/linux/kernel.h:799:48: warning: initialization from incompatible pointer type
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                                                 ^
> include/linux/list.h:352:2: note: in expansion of macro 'container_of'
>   container_of(ptr, type, member)
>   ^
> include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
>   list_entry((ptr)->next, type, member)
>   ^
> include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>                                            ^
> include/linux/kernel.h:800:3: note: in definition of macro 'container_of'
>   (type *)( (char *)__mptr - offsetof(type,member) );})
>    ^
> include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
>   list_entry((ptr)->next, type, member)
>   ^
> include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> In file included from include/linux/compiler-gcc.h:106:0,
>                  from include/linux/compiler.h:54,
>                  from include/linux/linkage.h:4,
>                  from include/linux/kernel.h:6,
>                  from drivers/of/of_pci.c:1:
> include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>                                            ^
> include/linux/compiler-gcc4.h:14:53: note: in definition of macro '__compiler_offsetof'
>  #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
>                                                      ^
> include/linux/kernel.h:800:29: note: in expansion of macro 'offsetof'
>   (type *)( (char *)__mptr - offsetof(type,member) );})
>                              ^
> include/linux/list.h:352:2: note: in expansion of macro 'container_of'
>   container_of(ptr, type, member)
>   ^
> include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
>   list_entry((ptr)->next, type, member)
>   ^
> include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> In file included from include/linux/kobject.h:20:0,
>                  from include/linux/of.h:21,
>                  from drivers/of/of_pci.c:3:
> include/linux/list.h:448:11: error: dereferencing pointer to incomplete type
>        &pos->member != (head);     \
>            ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> In file included from drivers/of/of_pci.c:1:0:
> include/linux/list.h:393:40: error: dereferencing pointer to incomplete type
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>                                         ^
> include/linux/kernel.h:799:18: note: in definition of macro 'container_of'
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                   ^
> include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>   ^
> include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
>        pos = list_next_entry(pos, member))
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> include/linux/list.h:393:18: error: dereferencing pointer to incomplete type
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>                   ^
> include/linux/kernel.h:799:49: note: in definition of macro 'container_of'
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                                                  ^
> include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>   ^
> include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
>        pos = list_next_entry(pos, member))
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> include/linux/list.h:393:40: error: dereferencing pointer to incomplete type
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>                                         ^
> include/linux/kernel.h:800:3: note: in definition of macro 'container_of'
>   (type *)( (char *)__mptr - offsetof(type,member) );})
>    ^
> include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>   ^
> include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
>        pos = list_next_entry(pos, member))
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> In file included from include/linux/compiler-gcc.h:106:0,
>                  from include/linux/compiler.h:54,
>                  from include/linux/linkage.h:4,
>                  from include/linux/kernel.h:6,
>                  from drivers/of/of_pci.c:1:
> include/linux/list.h:393:40: error: dereferencing pointer to incomplete type
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>                                         ^
> include/linux/compiler-gcc4.h:14:53: note: in definition of macro '__compiler_offsetof'
>  #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
>                                                      ^
> include/linux/kernel.h:800:29: note: in expansion of macro 'offsetof'
>   (type *)( (char *)__mptr - offsetof(type,member) );})
>                              ^
> include/linux/list.h:352:2: note: in expansion of macro 'container_of'
>   container_of(ptr, type, member)
>   ^
> include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
>   list_entry((pos)->member.next, typeof(*(pos)), member)
>   ^
> include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
>        pos = list_next_entry(pos, member))
>              ^
> drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(window, resources, list)
>   ^
> drivers/of/of_pci.c:230:15: error: dereferencing pointer to incomplete type
>    kfree(window->res);
>                ^
> 
> Caused by commit 14d76b68f281 ("PCI: Use common resource list
> management code instead of private implementation") interacting with
> commit d2be00c0fb5a ("of/pci: Free resources on failure in
> of_pci_get_host_bridge_resources()") from the pci tree.
> 
> I applied the following merge fix patch (which may need more work?).
Hi Stephen,
	Thanks for fixing it and there should no more work needed.
Regards!
Gerry

> Someone needs to remember to tell Linus about this fix (or similar)
> when these trees get merged.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 9 Feb 2015 13:08:24 +1100
> Subject: [PATCH] of/pci: fix up for "PCI: Use common resource list management
>  code instead of private implementation"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/of/of_pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c
> index 60dc36c865b5..110fece2ff53 100644
> --- a/drivers/of/of_pci.c
> +++ b/drivers/of/of_pci.c
> @@ -140,7 +140,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
>  			unsigned char busno, unsigned char bus_max,
>  			struct list_head *resources, resource_size_t *io_base)
>  {
> -	struct pci_host_bridge_window *window;
> +	struct resource_entry *window;
>  	struct resource *res;
>  	struct resource *bus_range;
>  	struct of_pci_range range;
> @@ -226,7 +226,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
>  conversion_failed:
>  	kfree(res);
>  parse_failed:
> -	list_for_each_entry(window, resources, list)
> +	resource_list_for_each_entry(window, resources)
>  		kfree(window->res);
>  	pci_free_resource_list(resources);
>  	kfree(bus_range);
> 

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2015-02-09  2:26 Stephen Rothwell
  2015-02-09  2:53 ` Jiang Liu
  2015-02-09  3:19 ` Rafael J. Wysocki
  0 siblings, 2 replies; 110+ messages in thread
From: Stephen Rothwell @ 2015-02-09  2:26 UTC (permalink / raw)
  To: Rafael J. Wysocki, Bjorn Helgaas
  Cc: linux-next, linux-kernel, Lorenzo Pieralisi, Jiang Liu

[-- Attachment #1: Type: text/plain, Size: 9498 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from drivers/of/of_pci.c:1:0:
drivers/of/of_pci.c: In function 'of_pci_get_host_bridge_resources':
include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
  for (pos = list_first_entry(head, typeof(*pos), member); \
                                           ^
include/linux/kernel.h:799:18: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                  ^
include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
  list_entry((ptr)->next, type, member)
  ^
include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
  for (pos = list_first_entry(head, typeof(*pos), member); \
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
include/linux/kernel.h:799:48: warning: initialization from incompatible pointer type
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                ^
include/linux/list.h:352:2: note: in expansion of macro 'container_of'
  container_of(ptr, type, member)
  ^
include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
  list_entry((ptr)->next, type, member)
  ^
include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
  for (pos = list_first_entry(head, typeof(*pos), member); \
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
  for (pos = list_first_entry(head, typeof(*pos), member); \
                                           ^
include/linux/kernel.h:800:3: note: in definition of macro 'container_of'
  (type *)( (char *)__mptr - offsetof(type,member) );})
   ^
include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
  list_entry((ptr)->next, type, member)
  ^
include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
  for (pos = list_first_entry(head, typeof(*pos), member); \
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
In file included from include/linux/compiler-gcc.h:106:0,
                 from include/linux/compiler.h:54,
                 from include/linux/linkage.h:4,
                 from include/linux/kernel.h:6,
                 from drivers/of/of_pci.c:1:
include/linux/list.h:447:43: error: dereferencing pointer to incomplete type
  for (pos = list_first_entry(head, typeof(*pos), member); \
                                           ^
include/linux/compiler-gcc4.h:14:53: note: in definition of macro '__compiler_offsetof'
 #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
                                                     ^
include/linux/kernel.h:800:29: note: in expansion of macro 'offsetof'
  (type *)( (char *)__mptr - offsetof(type,member) );})
                             ^
include/linux/list.h:352:2: note: in expansion of macro 'container_of'
  container_of(ptr, type, member)
  ^
include/linux/list.h:363:2: note: in expansion of macro 'list_entry'
  list_entry((ptr)->next, type, member)
  ^
include/linux/list.h:447:13: note: in expansion of macro 'list_first_entry'
  for (pos = list_first_entry(head, typeof(*pos), member); \
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
In file included from include/linux/kobject.h:20:0,
                 from include/linux/of.h:21,
                 from drivers/of/of_pci.c:3:
include/linux/list.h:448:11: error: dereferencing pointer to incomplete type
       &pos->member != (head);     \
           ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
In file included from drivers/of/of_pci.c:1:0:
include/linux/list.h:393:40: error: dereferencing pointer to incomplete type
  list_entry((pos)->member.next, typeof(*(pos)), member)
                                        ^
include/linux/kernel.h:799:18: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                  ^
include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
  list_entry((pos)->member.next, typeof(*(pos)), member)
  ^
include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
       pos = list_next_entry(pos, member))
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
include/linux/list.h:393:18: error: dereferencing pointer to incomplete type
  list_entry((pos)->member.next, typeof(*(pos)), member)
                  ^
include/linux/kernel.h:799:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                 ^
include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
  list_entry((pos)->member.next, typeof(*(pos)), member)
  ^
include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
       pos = list_next_entry(pos, member))
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
include/linux/list.h:393:40: error: dereferencing pointer to incomplete type
  list_entry((pos)->member.next, typeof(*(pos)), member)
                                        ^
include/linux/kernel.h:800:3: note: in definition of macro 'container_of'
  (type *)( (char *)__mptr - offsetof(type,member) );})
   ^
include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
  list_entry((pos)->member.next, typeof(*(pos)), member)
  ^
include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
       pos = list_next_entry(pos, member))
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
In file included from include/linux/compiler-gcc.h:106:0,
                 from include/linux/compiler.h:54,
                 from include/linux/linkage.h:4,
                 from include/linux/kernel.h:6,
                 from drivers/of/of_pci.c:1:
include/linux/list.h:393:40: error: dereferencing pointer to incomplete type
  list_entry((pos)->member.next, typeof(*(pos)), member)
                                        ^
include/linux/compiler-gcc4.h:14:53: note: in definition of macro '__compiler_offsetof'
 #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
                                                     ^
include/linux/kernel.h:800:29: note: in expansion of macro 'offsetof'
  (type *)( (char *)__mptr - offsetof(type,member) );})
                             ^
include/linux/list.h:352:2: note: in expansion of macro 'container_of'
  container_of(ptr, type, member)
  ^
include/linux/list.h:393:2: note: in expansion of macro 'list_entry'
  list_entry((pos)->member.next, typeof(*(pos)), member)
  ^
include/linux/list.h:449:13: note: in expansion of macro 'list_next_entry'
       pos = list_next_entry(pos, member))
             ^
drivers/of/of_pci.c:229:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(window, resources, list)
  ^
drivers/of/of_pci.c:230:15: error: dereferencing pointer to incomplete type
   kfree(window->res);
               ^

Caused by commit 14d76b68f281 ("PCI: Use common resource list
management code instead of private implementation") interacting with
commit d2be00c0fb5a ("of/pci: Free resources on failure in
of_pci_get_host_bridge_resources()") from the pci tree.

I applied the following merge fix patch (which may need more work?).
Someone needs to remember to tell Linus about this fix (or similar)
when these trees get merged.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 9 Feb 2015 13:08:24 +1100
Subject: [PATCH] of/pci: fix up for "PCI: Use common resource list management
 code instead of private implementation"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/of/of_pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c
index 60dc36c865b5..110fece2ff53 100644
--- a/drivers/of/of_pci.c
+++ b/drivers/of/of_pci.c
@@ -140,7 +140,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
 			unsigned char busno, unsigned char bus_max,
 			struct list_head *resources, resource_size_t *io_base)
 {
-	struct pci_host_bridge_window *window;
+	struct resource_entry *window;
 	struct resource *res;
 	struct resource *bus_range;
 	struct of_pci_range range;
@@ -226,7 +226,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
 conversion_failed:
 	kfree(res);
 parse_failed:
-	list_for_each_entry(window, resources, list)
+	resource_list_for_each_entry(window, resources)
 		kfree(window->res);
 	pci_free_resource_list(resources);
 	kfree(bus_range);
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2014-08-11  1:57 Stephen Rothwell
@ 2014-08-12  1:10 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2014-08-12  1:10 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Chanwoo Choi, Lee Jones

On Monday, August 11, 2014 11:57:26 AM Stephen Rothwell wrote:
> 
> --Sig_/+JDUwDarNoGtzkfUjWIyaKJ
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/mfd/sec-core.c: In function 'sec_pmic_suspend':
> drivers/mfd/sec-core.c:438:29: error: 'PM_SUSPEND_MEM' undeclared (first us=
> e in this function)
>    regulator_suspend_prepare(PM_SUSPEND_MEM);
>                              ^
> 
> Caused by commit bb3274b6442d ("PM / sleep: Rename symbols, functions
> and variables related to sleep") interacting with commit b7cde7078d23
> ("mfd: sec-core: Prepare regulators for suspend state to reduce
> power-consumption") from Linus' tree.

I dropped that commit from linux-next, sorry for the breakage.

Rafael


^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2014-08-11  1:57 Stephen Rothwell
  2014-08-12  1:10 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2014-08-11  1:57 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Chanwoo Choi, Lee Jones

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/sec-core.c: In function 'sec_pmic_suspend':
drivers/mfd/sec-core.c:438:29: error: 'PM_SUSPEND_MEM' undeclared (first use in this function)
   regulator_suspend_prepare(PM_SUSPEND_MEM);
                             ^

Caused by commit bb3274b6442d ("PM / sleep: Rename symbols, functions
and variables related to sleep") interacting with commit b7cde7078d23
("mfd: sec-core: Prepare regulators for suspend state to reduce
power-consumption") from Linus' tree.

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 11 Aug 2014 11:55:23 +1000
Subject: [PATCH] PM / sleep: fix for Rename symbols, functions and variables related to sleep

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mfd/sec-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index dba7e2b6f8e9..d289dc5fef66 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -435,7 +435,7 @@ static int sec_pmic_suspend(struct device *dev)
 	switch (sec_pmic->device_type) {
 	case S2MPS14X:
 	case S2MPU02:
-		regulator_suspend_prepare(PM_SUSPEND_MEM);
+		regulator_suspend_prepare(PM_SUSPEND_DEEP);
 		break;
 	default:
 		break;
-- 
2.1.0.rc1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2013-12-18  1:00 Stephen Rothwell
@ 2013-12-18  1:17 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2013-12-18  1:17 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Lv Zheng

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

On Wednesday, December 18, 2013 12:00:26 PM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/acpi/nvs.c:15:27: fatal error: linux/acpi_io.h: No such file or directory
>  #include <linux/acpi_io.h>
>                            ^
> 
> Caused by commit a99493647c1a ("Merge branch 'acpi-cleanup' into
> linux-next") which incorrectly reintroduced the include of
> linux/acpi_io.h.
> 
> I have used the pm tree from next-20131217 for today.

Sorry for the breakage, I messed up a conflict resolution.  It should be
fixed now in my tree FWIW.

Thanks,
Rafael

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2013-12-18  1:00 Stephen Rothwell
  2013-12-18  1:17 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2013-12-18  1:00 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Lv Zheng

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/acpi/nvs.c:15:27: fatal error: linux/acpi_io.h: No such file or directory
 #include <linux/acpi_io.h>
                           ^

Caused by commit a99493647c1a ("Merge branch 'acpi-cleanup' into
linux-next") which incorrectly reintroduced the include of
linux/acpi_io.h.

I have used the pm tree from next-20131217 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2013-07-05  1:24 Stephen Rothwell
@ 2013-07-05  1:37 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2013-07-05  1:37 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Alex Deucher

On Friday, July 05, 2013 11:24:58 AM Stephen Rothwell wrote:
> Hi Rafael,

Hi,

> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/gpu/drm/radeon/atombios_encoders.c: In function 'radeon_atom_backlight_init':
> drivers/gpu/drm/radeon/atombios_encoders.c:230:2: error: implicit declaration of function 'acpi_osi_version' [-Werror=implicit-function-declaration]
>   if (acpi_osi_version() >= ACPI_OSI_WIN_8)
>   ^
> drivers/gpu/drm/radeon/atombios_encoders.c:230:28: error: 'ACPI_OSI_WIN_8' undeclared (first use in this function)
>   if (acpi_osi_version() >= ACPI_OSI_WIN_8)
>                             ^
> drivers/gpu/drm/radeon/atombios_encoders.c:231:3: error: implicit declaration of function 'acpi_video_backlight_unregister' [-Werror=implicit-function-declaration]
>    acpi_video_backlight_unregister();
>    ^
> 
> Caused by commit 1823b2aeccce ("drm/radeon: don't provide ACPI backlight
> if firmware expects Windows 8").

Dropped that commit for now (along with the whole branch).

> 
> I have used the pm tree from next-20130704 for today.

Sorry for the trouble!

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2013-07-05  1:24 Stephen Rothwell
  2013-07-05  1:37 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2013-07-05  1:24 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Alex Deucher

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/gpu/drm/radeon/atombios_encoders.c: In function 'radeon_atom_backlight_init':
drivers/gpu/drm/radeon/atombios_encoders.c:230:2: error: implicit declaration of function 'acpi_osi_version' [-Werror=implicit-function-declaration]
  if (acpi_osi_version() >= ACPI_OSI_WIN_8)
  ^
drivers/gpu/drm/radeon/atombios_encoders.c:230:28: error: 'ACPI_OSI_WIN_8' undeclared (first use in this function)
  if (acpi_osi_version() >= ACPI_OSI_WIN_8)
                            ^
drivers/gpu/drm/radeon/atombios_encoders.c:231:3: error: implicit declaration of function 'acpi_video_backlight_unregister' [-Werror=implicit-function-declaration]
   acpi_video_backlight_unregister();
   ^

Caused by commit 1823b2aeccce ("drm/radeon: don't provide ACPI backlight
if firmware expects Windows 8").

I have used the pm tree from next-20130704 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2013-03-03 23:58 Stephen Rothwell
@ 2013-03-04 11:54 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2013-03-04 11:54 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

On Monday, March 04, 2013 10:58:41 AM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/base/power/qos.c: In function '__dev_pm_qos_flags':
> drivers/base/power/qos.c:64:2: error: implicit declaration of function 'IS_ERR_OR_NULL' [-Werror=implicit-function-declaration]
> drivers/base/power/qos.c: In function 'dev_pm_qos_constraints_destroy':
> drivers/base/power/qos.c:248:2: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
> drivers/base/power/qos.c:248:17: warning: assignment makes pointer from integer without a cast [enabled by default]
> drivers/base/power/qos.c: In function 'dev_pm_qos_add_request':
> drivers/base/power/qos.c:294:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> drivers/base/power/qos.c: At top level:
> drivers/base/power/qos.c:202:13: warning: '__dev_pm_qos_hide_latency_limit' used but never defined [enabled by default]
> drivers/base/power/qos.c:203:13: warning: '__dev_pm_qos_hide_flags' used but never defined [enabled by default]
> 
> Caused by commit 1e3b5df683e2 ("PM / QoS: Remove device PM QoS sysfs
> attributes at the right place").
> 
> I have used the pm tree from next-20130301 for today.

Thanks for the report and sorry for the breakage.  It should be fixed now.

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2013-03-03 23:58 Stephen Rothwell
  2013-03-04 11:54 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2013-03-03 23:58 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/base/power/qos.c: In function '__dev_pm_qos_flags':
drivers/base/power/qos.c:64:2: error: implicit declaration of function 'IS_ERR_OR_NULL' [-Werror=implicit-function-declaration]
drivers/base/power/qos.c: In function 'dev_pm_qos_constraints_destroy':
drivers/base/power/qos.c:248:2: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
drivers/base/power/qos.c:248:17: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/base/power/qos.c: In function 'dev_pm_qos_add_request':
drivers/base/power/qos.c:294:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
drivers/base/power/qos.c: At top level:
drivers/base/power/qos.c:202:13: warning: '__dev_pm_qos_hide_latency_limit' used but never defined [enabled by default]
drivers/base/power/qos.c:203:13: warning: '__dev_pm_qos_hide_flags' used but never defined [enabled by default]

Caused by commit 1e3b5df683e2 ("PM / QoS: Remove device PM QoS sysfs
attributes at the right place").

I have used the pm tree from next-20130301 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2013-01-30  8:48 Stephen Rothwell
@ 2013-01-30 12:50 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2013-01-30 12:50 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

Hi,

On Wednesday, January 30, 2013 07:48:41 PM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/built-in.o: In function `ipc_init':
> pl320-ipc.c:(.init.text+0xf96b): undefined reference to `amba_driver_register'
> 
> Caused by commit 970066f5b269 ("ARM / highbank: add support for pl320 IPC").
> 
> I have used the pm tree from next-20130128 for today.

Sorry for the breakage.  I'm not sure why that hasn't been caught by the
automatic build testing.  Anyway, I've dropped the whole cpufreq material
from my linux-next branch for now.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2013-01-30  8:48 Stephen Rothwell
  2013-01-30 12:50 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2013-01-30  8:48 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `ipc_init':
pl320-ipc.c:(.init.text+0xf96b): undefined reference to `amba_driver_register'

Caused by commit 970066f5b269 ("ARM / highbank: add support for pl320 IPC").

I have used the pm tree from next-20130128 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2013-01-14 13:22 ` Sedat Dilek
@ 2013-01-14 18:54   ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2013-01-14 18:54 UTC (permalink / raw)
  To: sedat.dilek; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Monday, January 14, 2013 02:22:20 PM Sedat Dilek wrote:
> On Mon, Jan 14, 2013 at 1:03 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > In file included from init/main.c:25:0:
> > include/linux/acpi.h:549:46: error: unknown type name 'acpi_handle'
> > include/linux/acpi.h:551:49: error: unknown type name 'acpi_handle'
> >
> > and many more.
> >
> > Caused by commit c9b147cd9648 ("ACPI / PM: Rework the handling of devices
> > depending on power resources").  Please check with and without CONFIG
> > options that affect patches ...
> >
> > I have used the pm tree from next-20130111 for today.
> 
> [ Please also CC linux-next ML ! ]
> 
> [ QUOTE ]
> Thanks for the report and sorry for the breakage.  Should be fixed now.
> 
> Rafael
> [ /QUOTE ]
> 
> What was the cause for this?
> 
> Did you refresh "ACPI / PM: Rework the handling of devices depending
> on power resources" [1]?

I did.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2013-01-14  0:03 Stephen Rothwell
  2013-01-14 12:37 ` Rafael J. Wysocki
@ 2013-01-14 13:22 ` Sedat Dilek
  2013-01-14 18:54   ` Rafael J. Wysocki
  1 sibling, 1 reply; 110+ messages in thread
From: Sedat Dilek @ 2013-01-14 13:22 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Rafael J. Wysocki, linux-next, linux-kernel

On Mon, Jan 14, 2013 at 1:03 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rafael,
>
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from init/main.c:25:0:
> include/linux/acpi.h:549:46: error: unknown type name 'acpi_handle'
> include/linux/acpi.h:551:49: error: unknown type name 'acpi_handle'
>
> and many more.
>
> Caused by commit c9b147cd9648 ("ACPI / PM: Rework the handling of devices
> depending on power resources").  Please check with and without CONFIG
> options that affect patches ...
>
> I have used the pm tree from next-20130111 for today.

[ Please also CC linux-next ML ! ]

[ QUOTE ]
Thanks for the report and sorry for the breakage.  Should be fixed now.

Rafael
[ /QUOTE ]

What was the cause for this?

Did you refresh "ACPI / PM: Rework the handling of devices depending
on power resources" [1]?

- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/rafael/linux-pm.git;a=commitdiff;h=d99d400c824b008202e2b7b4bf2080cf5d18d601

> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2013-01-14  0:03 Stephen Rothwell
@ 2013-01-14 12:37 ` Rafael J. Wysocki
  2013-01-14 13:22 ` Sedat Dilek
  1 sibling, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2013-01-14 12:37 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

Hi,

On Monday, January 14, 2013 11:03:11 AM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> In file included from init/main.c:25:0:
> include/linux/acpi.h:549:46: error: unknown type name 'acpi_handle'
> include/linux/acpi.h:551:49: error: unknown type name 'acpi_handle'
> 
> and many more.
> 
> Caused by commit c9b147cd9648 ("ACPI / PM: Rework the handling of devices
> depending on power resources").  Please check with and without CONFIG
> options that affect patches ...
> 
> I have used the pm tree from next-20130111 for today.

Thanks for the report and sorry for the breakage.  Should be fixed now.

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.


^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2013-01-14  0:03 Stephen Rothwell
  2013-01-14 12:37 ` Rafael J. Wysocki
  2013-01-14 13:22 ` Sedat Dilek
  0 siblings, 2 replies; 110+ messages in thread
From: Stephen Rothwell @ 2013-01-14  0:03 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from init/main.c:25:0:
include/linux/acpi.h:549:46: error: unknown type name 'acpi_handle'
include/linux/acpi.h:551:49: error: unknown type name 'acpi_handle'

and many more.

Caused by commit c9b147cd9648 ("ACPI / PM: Rework the handling of devices
depending on power resources").  Please check with and without CONFIG
options that affect patches ...

I have used the pm tree from next-20130111 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2012-11-28  4:02 Stephen Rothwell
@ 2012-11-28  9:32 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2012-11-28  9:32 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Rajagopal Venkat, MyungJoo Ham

On Wednesday, November 28, 2012 03:02:18 PM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "devfreq_monitor_resume" [drivers/devfreq/governor_simpleondemand.ko] undefined!
> ERROR: "devfreq_monitor_suspend" [drivers/devfreq/governor_simpleondemand.ko] undefined!
> ERROR: "devfreq_interval_update" [drivers/devfreq/governor_simpleondemand.ko] undefined!
> ERROR: "devfreq_monitor_stop" [drivers/devfreq/governor_simpleondemand.ko] undefined!
> ERROR: "devfreq_monitor_start" [drivers/devfreq/governor_simpleondemand.ko] undefined!
> 
> Caused by commit 206c30cfeb7c ("PM / devfreq: Add suspend and resume apis").
> 
> I have used the pm tree from next-20121127 for today.

Sorry about this, I dropped the devfreq tree from my linux-next branch for now,
but that was after you had pulled from it.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2012-11-28  4:02 Stephen Rothwell
  2012-11-28  9:32 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2012-11-28  4:02 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Rajagopal Venkat, MyungJoo Ham

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "devfreq_monitor_resume" [drivers/devfreq/governor_simpleondemand.ko] undefined!
ERROR: "devfreq_monitor_suspend" [drivers/devfreq/governor_simpleondemand.ko] undefined!
ERROR: "devfreq_interval_update" [drivers/devfreq/governor_simpleondemand.ko] undefined!
ERROR: "devfreq_monitor_stop" [drivers/devfreq/governor_simpleondemand.ko] undefined!
ERROR: "devfreq_monitor_start" [drivers/devfreq/governor_simpleondemand.ko] undefined!

Caused by commit 206c30cfeb7c ("PM / devfreq: Add suspend and resume apis").

I have used the pm tree from next-20121127 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2012-11-26  6:09 Stephen Rothwell
@ 2012-11-26 10:10 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2012-11-26 10:10 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Nishanth Menon, MyungJoo Ham

On Monday, November 26, 2012 05:09:19 PM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/devfreq/governor_simpleondemand.c: In function 'devfreq_simple_ondemand_func':
> drivers/devfreq/governor_simpleondemand.c:36:11: error: dereferencing pointer to incomplete type
> drivers/devfreq/governor_simpleondemand.c:37:27: error: dereferencing pointer to incomplete type
> drivers/devfreq/governor_simpleondemand.c:38:11: error: dereferencing pointer to incomplete type
> drivers/devfreq/governor_simpleondemand.c:39:32: error: dereferencing pointer to incomplete type
> 
> Caused by commit eff607fdb1f7 ("PM / devfreq: governors: add GPL module
> license and allow module build").  The definition of struct
> devfreq_simple_ondemand_data depends on
> CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND, but this is a modular build, so
> CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND_MODULE is defined instead.
> 
> I have used the pm tree fomr next-20121115 for today.

Sorry for the breakage, I've dropped the most recent devfreq patches from
my linux-next branch for now.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2012-11-26  6:09 Stephen Rothwell
  2012-11-26 10:10 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2012-11-26  6:09 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Nishanth Menon, MyungJoo Ham

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/devfreq/governor_simpleondemand.c: In function 'devfreq_simple_ondemand_func':
drivers/devfreq/governor_simpleondemand.c:36:11: error: dereferencing pointer to incomplete type
drivers/devfreq/governor_simpleondemand.c:37:27: error: dereferencing pointer to incomplete type
drivers/devfreq/governor_simpleondemand.c:38:11: error: dereferencing pointer to incomplete type
drivers/devfreq/governor_simpleondemand.c:39:32: error: dereferencing pointer to incomplete type

Caused by commit eff607fdb1f7 ("PM / devfreq: governors: add GPL module
license and allow module build").  The definition of struct
devfreq_simple_ondemand_data depends on
CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND, but this is a modular build, so
CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND_MODULE is defined instead.

I have used the pm tree fomr next-20121115 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2012-09-25  4:30 Stephen Rothwell
@ 2012-09-25 11:51 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2012-09-25 11:51 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Matthew Garrett, Andre Przywara

On Tuesday, September 25, 2012, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/cpufreq/powernow-k8.c: In function 'transition_frequency_pstate':
> drivers/cpufreq/powernow-k8.c:991:19: error: 'HW_PSTATE_MASK' undeclared (first use in this function)
> drivers/cpufreq/powernow-k8.c:991:19: note: each undeclared identifier is reported only once for each function it appears in
> drivers/cpufreq/powernow-k8.c:992:19: error: 'struct powernow_k8_data' has no member named 'max_hw_pstate'
> drivers/cpufreq/powernow-k8.c:995:2: error: implicit declaration of function 'find_khz_freq_from_pstate' [-Werror=implicit-function-declaration]
> drivers/cpufreq/powernow-k8.c:996:8: error: 'struct powernow_k8_data' has no member named 'currpstate'
> drivers/cpufreq/powernow-k8.c:1004:2: error: implicit declaration of function 'transition_pstate' [-Werror=implicit-function-declaration]
> drivers/cpufreq/powernow-k8.c: At top level:
> drivers/cpufreq/powernow-k8.c:981:12: warning: 'transition_frequency_pstate' defined but not used [-Wunused-function]
> 
> The code causing this was removed by commit e1f0b8e9b04a ("cpufreq:
> Remove support for hardware P-state chips from powernow-k8") but
> reintroduced (presumably incorrectly) by commit d20801be3c11 ("Merge
> branch 'master' into linux-next").
> 
> I have used the pm tree from next-20120924 for today.

It looks like I got the merge wrong.  Sorry about that, I'll fix it up later
today.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2012-09-25  4:30 Stephen Rothwell
  2012-09-25 11:51 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2012-09-25  4:30 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Matthew Garrett, Andre Przywara

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/cpufreq/powernow-k8.c: In function 'transition_frequency_pstate':
drivers/cpufreq/powernow-k8.c:991:19: error: 'HW_PSTATE_MASK' undeclared (first use in this function)
drivers/cpufreq/powernow-k8.c:991:19: note: each undeclared identifier is reported only once for each function it appears in
drivers/cpufreq/powernow-k8.c:992:19: error: 'struct powernow_k8_data' has no member named 'max_hw_pstate'
drivers/cpufreq/powernow-k8.c:995:2: error: implicit declaration of function 'find_khz_freq_from_pstate' [-Werror=implicit-function-declaration]
drivers/cpufreq/powernow-k8.c:996:8: error: 'struct powernow_k8_data' has no member named 'currpstate'
drivers/cpufreq/powernow-k8.c:1004:2: error: implicit declaration of function 'transition_pstate' [-Werror=implicit-function-declaration]
drivers/cpufreq/powernow-k8.c: At top level:
drivers/cpufreq/powernow-k8.c:981:12: warning: 'transition_frequency_pstate' defined but not used [-Wunused-function]

The code causing this was removed by commit e1f0b8e9b04a ("cpufreq:
Remove support for hardware P-state chips from powernow-k8") but
reintroduced (presumably incorrectly) by commit d20801be3c11 ("Merge
branch 'master' into linux-next").

I have used the pm tree from next-20120924 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2012-06-20  5:01 Stephen Rothwell
@ 2012-06-20 22:54 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2012-06-20 22:54 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Sameer Nanda, Srivatsa S. Bhat

On Wednesday, June 20, 2012, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/built-in.o:(.toc1+0x37f0): undefined reference to `pm_print_times_enabled'
> 
> Caused by commit 0eb8c06cb620 ("PM / Sleep: Separate printing suspend
> times from initcall_debug") or maybe 1873ce64491a ("M / Sleep: add knob
> for printing device resume times").

That should be fixed now, sorry for the breakage.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2012-06-20  5:01 Stephen Rothwell
  2012-06-20 22:54 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2012-06-20  5:01 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Sameer Nanda, Srivatsa S. Bhat

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/built-in.o:(.toc1+0x37f0): undefined reference to `pm_print_times_enabled'

Caused by commit 0eb8c06cb620 ("PM / Sleep: Separate printing suspend
times from initcall_debug") or maybe 1873ce64491a ("M / Sleep: add knob
for printing device resume times").

I have used the pm tree from next-20120619 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2012-01-27  1:53 Stephen Rothwell
@ 2012-01-27  9:35 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2012-01-27  9:35 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Alex Frid, Antti Miettinen,
	Diwakar Tundlam, Scott Williams, Yu-Huan Hsu, markgross,
	Linux PM mailing list

On Friday, January 27, 2012, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> kernel/power/process.c: In function 'thaw_kernel_threads':
> kernel/power/process.c:199:2: error: 'g' undeclared (first use in this function)
> kernel/power/process.c:199:2: note: each undeclared identifier is reported only once for each function it appears in
> kernel/power/process.c:199:2: error: 'p' undeclared (first use in this function)
> 
> Caused by commit 625278ca8016 ("PM / QoS: Simplify PM QoS expansion/merge").
> 
> Clearly never built :-(  At least, not in this form.
> 
> I have used the pm tree from next-20120125 for today.

Sorry for the breakage.

I took a broken version of that patch from my quilt queue by mistake,
should be fixed now.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2012-01-27  1:53 Stephen Rothwell
  2012-01-27  9:35 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2012-01-27  1:53 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Alex Frid, Antti Miettinen,
	Diwakar Tundlam, Scott Williams, Yu-Huan Hsu, markgross

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/power/process.c: In function 'thaw_kernel_threads':
kernel/power/process.c:199:2: error: 'g' undeclared (first use in this function)
kernel/power/process.c:199:2: note: each undeclared identifier is reported only once for each function it appears in
kernel/power/process.c:199:2: error: 'p' undeclared (first use in this function)

Caused by commit 625278ca8016 ("PM / QoS: Simplify PM QoS expansion/merge").

Clearly never built :-(  At least, not in this form.

I have used the pm tree from next-20120125 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-11-10  2:31 Stephen Rothwell
  2011-11-10 12:11 ` Rafael J. Wysocki
@ 2011-11-11 12:27 ` Rafael J. Wysocki
  1 sibling, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-11-11 12:27 UTC (permalink / raw)
  To: Stephen Rothwell, Tejun Heo; +Cc: linux-next, linux-kernel

On Thursday, November 10, 2011, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> mm/oom_kill.c: In function 'select_bad_process':
> mm/oom_kill.c:326:5: error: implicit declaration of function 'thaw_process'
> 
> Caused by commit 944e192db53c ("freezer: rename thaw_process() to
> __thaw_task() and simplify the implementation").
> 
> I have used the pm tree from next-20111109 for today.

The appended patch fixes the build problem for me.  I've added it to my
linux-next branch already.

Tejun, please let me know if that's OK.

Rafael

---
From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: PM / Freezer: Fix fallout of thaw_process() -> __thaw_task() rename

The changset that renamed thaw_process() to __thaw_task() forgot to
modify oom_kill.c in accordance with that change and introduced
a build problem.  Fix it.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 mm/oom_kill.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/mm/oom_kill.c
===================================================================
--- linux.orig/mm/oom_kill.c
+++ linux/mm/oom_kill.c
@@ -323,7 +323,7 @@ static struct task_struct *select_bad_pr
 		 */
 		if (test_tsk_thread_flag(p, TIF_MEMDIE)) {
 			if (unlikely(frozen(p)))
-				thaw_process(p);
+				__thaw_task(p);
 			return ERR_PTR(-1UL);
 		}
 		if (!p->mm)

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-11-10 12:11 ` Rafael J. Wysocki
@ 2011-11-10 15:48   ` Tejun Heo
  0 siblings, 0 replies; 110+ messages in thread
From: Tejun Heo @ 2011-11-10 15:48 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, Nov 10, 2011 at 01:11:31PM +0100, Rafael J. Wysocki wrote:
> On Thursday, November 10, 2011, Stephen Rothwell wrote:
> > Hi Rafael,
> > 
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > mm/oom_kill.c: In function 'select_bad_process':
> > mm/oom_kill.c:326:5: error: implicit declaration of function 'thaw_process'
> > 
> > Caused by commit 944e192db53c ("freezer: rename thaw_process() to
> > __thaw_task() and simplify the implementation").
> > 
> > I have used the pm tree from next-20111109 for today.
> 
> Thanks, I'll drop pm-freezer from my linux-next branch until that issue is
> fixed.

Will try to resolve soon.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-11-10  2:31 Stephen Rothwell
@ 2011-11-10 12:11 ` Rafael J. Wysocki
  2011-11-10 15:48   ` Tejun Heo
  2011-11-11 12:27 ` Rafael J. Wysocki
  1 sibling, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-11-10 12:11 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Tejun Heo

On Thursday, November 10, 2011, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> mm/oom_kill.c: In function 'select_bad_process':
> mm/oom_kill.c:326:5: error: implicit declaration of function 'thaw_process'
> 
> Caused by commit 944e192db53c ("freezer: rename thaw_process() to
> __thaw_task() and simplify the implementation").
> 
> I have used the pm tree from next-20111109 for today.

Thanks, I'll drop pm-freezer from my linux-next branch until that issue is
fixed.

Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2011-11-10  2:31 Stephen Rothwell
  2011-11-10 12:11 ` Rafael J. Wysocki
  2011-11-11 12:27 ` Rafael J. Wysocki
  0 siblings, 2 replies; 110+ messages in thread
From: Stephen Rothwell @ 2011-11-10  2:31 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Tejun Heo

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

mm/oom_kill.c: In function 'select_bad_process':
mm/oom_kill.c:326:5: error: implicit declaration of function 'thaw_process'

Caused by commit 944e192db53c ("freezer: rename thaw_process() to
__thaw_task() and simplify the implementation").

I have used the pm tree from next-20111109 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-29  9:32             ` Ming Lei
@ 2011-09-29 20:25               ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-09-29 20:25 UTC (permalink / raw)
  To: Ming Lei; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thursday, September 29, 2011, Ming Lei wrote:
> On Thu, Sep 29, 2011 at 5:26 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> But I don't think it is ugly, and this way is taken by BLOCK/PERF_EVENTS/
> >> KGDB_KDB in kernel/trace/Makefile.
> >
> > You're right about this.
> >
> >> Also this one is a simple fix and don't introduce any new config option,
> >> which is unnecessary.
> >
> > OK, I'll use your last patch.  Care to resend it with a sign-off?
> 
> OK, thanks, see attachment.

Applied.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-29  9:26           ` Rafael J. Wysocki
@ 2011-09-29  9:32             ` Ming Lei
  2011-09-29 20:25               ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Ming Lei @ 2011-09-29  9:32 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Stephen Rothwell, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

On Thu, Sep 29, 2011 at 5:26 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> But I don't think it is ugly, and this way is taken by BLOCK/PERF_EVENTS/
>> KGDB_KDB in kernel/trace/Makefile.
>
> You're right about this.
>
>> Also this one is a simple fix and don't introduce any new config option,
>> which is unnecessary.
>
> OK, I'll use your last patch.  Care to resend it with a sign-off?

OK, thanks, see attachment.

thanks,
--
Ming Lei

[-- Attachment #2: 0001-kernel-trace-Makefile-build-rpm-traces.c-only-if-CON.patch --]
[-- Type: text/x-patch, Size: 856 bytes --]

From a5a34ac175e0223148b9fe8089c99e27882cf024 Mon Sep 17 00:00:00 2001
From: Ming Lei <ming.lei@canonical.com>
Date: Wed, 28 Sep 2011 22:40:06 +0800
Subject: [PATCH] kernel/trace/Makefile: build rpm-traces.c only if
 CONFIG_PM_RUNTIME


Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 kernel/trace/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
index 56bdab5..f49405f 100644
--- a/kernel/trace/Makefile
+++ b/kernel/trace/Makefile
@@ -53,7 +53,9 @@ endif
 obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o
 obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o
 obj-$(CONFIG_TRACEPOINTS) += power-traces.o
+ifeq ($(CONFIG_PM_RUNTIME),y)
 obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
+endif
 ifeq ($(CONFIG_TRACING),y)
 obj-$(CONFIG_KGDB_KDB) += trace_kdb.o
 endif
-- 
1.7.5.4


^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-29  1:32         ` Ming Lei
@ 2011-09-29  9:26           ` Rafael J. Wysocki
  2011-09-29  9:32             ` Ming Lei
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-09-29  9:26 UTC (permalink / raw)
  To: Ming Lei; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thursday, September 29, 2011, Ming Lei wrote:
> On Thu, Sep 29, 2011 at 3:32 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Wednesday, September 28, 2011, Ming Lei wrote:
> >> Hi,
> >>
> >> 2011/9/28 Rafael J. Wysocki <rjw@sisk.pl>:
> >> > On Wednesday, September 28, 2011, Ming Lei wrote:
> >> >> Hi Stephen and Rafael,
> >> >>
> >> >> Sorry, the attachment patch can fix the build failure, which is
> >> >> caused by unset CONFIG_RUNTIME_PM.
> >> >
> >> > First off, that's CONFIG_PM_RUNTIME.  Second, why do you want to build
> >> > rpm-traces.c at all if CONFIG_PM_RUNTIME is unset?
> >> >
> >>
> >> Yes, you are right,  follows the correct fix:
> >>
> >> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
> >> index 56bdab5..f49405f 100644
> >> --- a/kernel/trace/Makefile
> >> +++ b/kernel/trace/Makefile
> >> @@ -53,7 +53,9 @@ endif
> >>  obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o
> >>  obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o
> >>  obj-$(CONFIG_TRACEPOINTS) += power-traces.o
> >> +ifeq ($(CONFIG_PM_RUNTIME),y)
> >>  obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
> >> +endif
> >>  ifeq ($(CONFIG_TRACING),y)
> >>  obj-$(CONFIG_KGDB_KDB) += trace_kdb.o
> >>  endif
> >
> > Well, this still is kind of ugly.  I'd prefer my patch sent in this thread.
> 
> Both are doable, :-)
> 
> But I don't think it is ugly, and this way is taken by BLOCK/PERF_EVENTS/
> KGDB_KDB in kernel/trace/Makefile.

You're right about this.

> Also this one is a simple fix and don't introduce any new config option,
> which is unnecessary.

OK, I'll use your last patch.  Care to resend it with a sign-off?

Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-28 19:32       ` Rafael J. Wysocki
@ 2011-09-29  1:32         ` Ming Lei
  2011-09-29  9:26           ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Ming Lei @ 2011-09-29  1:32 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, Sep 29, 2011 at 3:32 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Wednesday, September 28, 2011, Ming Lei wrote:
>> Hi,
>>
>> 2011/9/28 Rafael J. Wysocki <rjw@sisk.pl>:
>> > On Wednesday, September 28, 2011, Ming Lei wrote:
>> >> Hi Stephen and Rafael,
>> >>
>> >> Sorry, the attachment patch can fix the build failure, which is
>> >> caused by unset CONFIG_RUNTIME_PM.
>> >
>> > First off, that's CONFIG_PM_RUNTIME.  Second, why do you want to build
>> > rpm-traces.c at all if CONFIG_PM_RUNTIME is unset?
>> >
>>
>> Yes, you are right,  follows the correct fix:
>>
>> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
>> index 56bdab5..f49405f 100644
>> --- a/kernel/trace/Makefile
>> +++ b/kernel/trace/Makefile
>> @@ -53,7 +53,9 @@ endif
>>  obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o
>>  obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o
>>  obj-$(CONFIG_TRACEPOINTS) += power-traces.o
>> +ifeq ($(CONFIG_PM_RUNTIME),y)
>>  obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
>> +endif
>>  ifeq ($(CONFIG_TRACING),y)
>>  obj-$(CONFIG_KGDB_KDB) += trace_kdb.o
>>  endif
>
> Well, this still is kind of ugly.  I'd prefer my patch sent in this thread.

Both are doable, :-)

But I don't think it is ugly, and this way is taken by BLOCK/PERF_EVENTS/
KGDB_KDB in kernel/trace/Makefile. Also this one is a simple fix and
don't introduce any new config option, which is unnecessary.


thanks,
--
Ming Lei

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-28 14:47     ` Ming Lei
@ 2011-09-28 19:32       ` Rafael J. Wysocki
  2011-09-29  1:32         ` Ming Lei
  0 siblings, 1 reply; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-09-28 19:32 UTC (permalink / raw)
  To: Ming Lei; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wednesday, September 28, 2011, Ming Lei wrote:
> Hi,
> 
> 2011/9/28 Rafael J. Wysocki <rjw@sisk.pl>:
> > On Wednesday, September 28, 2011, Ming Lei wrote:
> >> Hi Stephen and Rafael,
> >>
> >> Sorry, the attachment patch can fix the build failure, which is
> >> caused by unset CONFIG_RUNTIME_PM.
> >
> > First off, that's CONFIG_PM_RUNTIME.  Second, why do you want to build
> > rpm-traces.c at all if CONFIG_PM_RUNTIME is unset?
> >
> 
> Yes, you are right,  follows the correct fix:
> 
> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
> index 56bdab5..f49405f 100644
> --- a/kernel/trace/Makefile
> +++ b/kernel/trace/Makefile
> @@ -53,7 +53,9 @@ endif
>  obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o
>  obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o
>  obj-$(CONFIG_TRACEPOINTS) += power-traces.o
> +ifeq ($(CONFIG_PM_RUNTIME),y)
>  obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
> +endif
>  ifeq ($(CONFIG_TRACING),y)
>  obj-$(CONFIG_KGDB_KDB) += trace_kdb.o
>  endif

Well, this still is kind of ugly.  I'd prefer my patch sent in this thread.

Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-28 13:58   ` Rafael J. Wysocki
  2011-09-28 14:47     ` Ming Lei
@ 2011-09-28 14:47     ` Rafael J. Wysocki
  1 sibling, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-09-28 14:47 UTC (permalink / raw)
  To: Ming Lei; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wednesday, September 28, 2011, Rafael J. Wysocki wrote:
> On Wednesday, September 28, 2011, Ming Lei wrote:
> > Hi Stephen and Rafael,
> > 
> > Sorry, the attachment patch can fix the build failure, which is
> > caused by unset CONFIG_RUNTIME_PM.
> 
> First off, that's CONFIG_PM_RUNTIME.  Second, why do you want to build
> rpm-traces.c at all if CONFIG_PM_RUNTIME is unset?

IOW, what about the appended patch instead?

Rafael

---
From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: PM / Tracing: Build runtime PM tracepoints if PM_RUNTIME is set

Do not build kernel/trace/rpm-traces.c if CONFIG_PM_RUNTIME is not
set, which avoids a build failure.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/power/Kconfig  |    4 ++++
 kernel/trace/Makefile |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Index: linux/kernel/power/Kconfig
===================================================================
--- linux.orig/kernel/power/Kconfig
+++ linux/kernel/power/Kconfig
@@ -238,3 +238,7 @@ config PM_GENERIC_DOMAINS
 config PM_GENERIC_DOMAINS_RUNTIME
 	def_bool y
 	depends on PM_RUNTIME && PM_GENERIC_DOMAINS
+
+config RUNTIME_PM_TRACEPOINTS
+	def_bool y
+	depends on PM_RUNTIME && TRACEPOINTS
Index: linux/kernel/trace/Makefile
===================================================================
--- linux.orig/kernel/trace/Makefile
+++ linux/kernel/trace/Makefile
@@ -53,7 +53,7 @@ endif
 obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o
 obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o
 obj-$(CONFIG_TRACEPOINTS) += power-traces.o
-obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
+obj-$(CONFIG_RUNTIME_PM_TRACEPOINTS) += rpm-traces.o
 ifeq ($(CONFIG_TRACING),y)
 obj-$(CONFIG_KGDB_KDB) += trace_kdb.o
 endif

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-28 13:58   ` Rafael J. Wysocki
@ 2011-09-28 14:47     ` Ming Lei
  2011-09-28 19:32       ` Rafael J. Wysocki
  2011-09-28 14:47     ` Rafael J. Wysocki
  1 sibling, 1 reply; 110+ messages in thread
From: Ming Lei @ 2011-09-28 14:47 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Stephen Rothwell, linux-next, linux-kernel

Hi,

2011/9/28 Rafael J. Wysocki <rjw@sisk.pl>:
> On Wednesday, September 28, 2011, Ming Lei wrote:
>> Hi Stephen and Rafael,
>>
>> Sorry, the attachment patch can fix the build failure, which is
>> caused by unset CONFIG_RUNTIME_PM.
>
> First off, that's CONFIG_PM_RUNTIME.  Second, why do you want to build
> rpm-traces.c at all if CONFIG_PM_RUNTIME is unset?
>

Yes, you are right,  follows the correct fix:

diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
index 56bdab5..f49405f 100644
--- a/kernel/trace/Makefile
+++ b/kernel/trace/Makefile
@@ -53,7 +53,9 @@ endif
 obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o
 obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o
 obj-$(CONFIG_TRACEPOINTS) += power-traces.o
+ifeq ($(CONFIG_PM_RUNTIME),y)
 obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
+endif
 ifeq ($(CONFIG_TRACING),y)
 obj-$(CONFIG_KGDB_KDB) += trace_kdb.o
 endif

thanks,
--
Ming Lei

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-28  5:11 ` Ming Lei
@ 2011-09-28 13:58   ` Rafael J. Wysocki
  2011-09-28 14:47     ` Ming Lei
  2011-09-28 14:47     ` Rafael J. Wysocki
  0 siblings, 2 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-09-28 13:58 UTC (permalink / raw)
  To: Ming Lei; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wednesday, September 28, 2011, Ming Lei wrote:
> Hi Stephen and Rafael,
> 
> Sorry, the attachment patch can fix the build failure, which is
> caused by unset CONFIG_RUNTIME_PM.

First off, that's CONFIG_PM_RUNTIME.  Second, why do you want to build
rpm-traces.c at all if CONFIG_PM_RUNTIME is unset?

Rafael


> On Wed, Sep 28, 2011 at 12:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > In file included from include/trace/ftrace.h:567:0,
> >                 from include/trace/define_trace.h:96,
> >                 from include/trace/events/rpm.h:99,
> >                 from kernel/trace/rpm-traces.c:15:
> > include/trace/events/rpm.h: In function 'ftrace_raw_event_rpm_internal':
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'usage_count'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'disable_depth'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'runtime_auto'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'request_pending'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'irq_safe'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'child_count'
> > In file included from include/trace/ftrace.h:771:0,
> >                 from include/trace/define_trace.h:96,
> >                 from include/trace/events/rpm.h:99,
> >                 from kernel/trace/rpm-traces.c:15:
> > include/trace/events/rpm.h: In function 'perf_trace_rpm_internal':
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'usage_count'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'disable_depth'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'runtime_auto'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'request_pending'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'irq_safe'
> > include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'child_count'
> >
> > Presumably caused by commit 53b615ccca56 ("PM / Runtime: Introduce trace
> > points for tracing rpm_* functions").
> >
> > I have used the pm tree from next-20110927 for today.
> > --
> > Cheers,
> > Stephen Rothwell                    sfr@canb.auug.org.au
> > http://www.canb.auug.org.au/~sfr/
> >
> 


^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-09-28  4:51 Stephen Rothwell
@ 2011-09-28  5:11 ` Ming Lei
  2011-09-28 13:58   ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Ming Lei @ 2011-09-28  5:11 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Rafael J. Wysocki, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2427 bytes --]

Hi Stephen and Rafael,

Sorry, the attachment patch can fix the build failure, which is
caused by unset CONFIG_RUNTIME_PM.

thanks,
--
Ming Lei

On Wed, Sep 28, 2011 at 12:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rafael,
>
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from include/trace/ftrace.h:567:0,
>                 from include/trace/define_trace.h:96,
>                 from include/trace/events/rpm.h:99,
>                 from kernel/trace/rpm-traces.c:15:
> include/trace/events/rpm.h: In function 'ftrace_raw_event_rpm_internal':
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'usage_count'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'disable_depth'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'runtime_auto'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'request_pending'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'irq_safe'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'child_count'
> In file included from include/trace/ftrace.h:771:0,
>                 from include/trace/define_trace.h:96,
>                 from include/trace/events/rpm.h:99,
>                 from kernel/trace/rpm-traces.c:15:
> include/trace/events/rpm.h: In function 'perf_trace_rpm_internal':
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'usage_count'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'disable_depth'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'runtime_auto'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'request_pending'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'irq_safe'
> include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'child_count'
>
> Presumably caused by commit 53b615ccca56 ("PM / Runtime: Introduce trace
> points for tracing rpm_* functions").
>
> I have used the pm tree from next-20110927 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

[-- Attachment #2: 0001-kernel-trace-rpm-traces.c-fix-build-failure-if-RUNTI.patch --]
[-- Type: text/x-patch, Size: 910 bytes --]

From feb037e957149f0dc405b80b4bb9cdafec6fcb0f Mon Sep 17 00:00:00 2001
From: Ming Lei <ming.lei@canonical.com>
Date: Wed, 28 Sep 2011 13:07:04 +0800
Subject: [PATCH] kernel/trace/rpm-traces.c: fix build failure if RUNTIME_PM
 unset


Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 kernel/trace/rpm-traces.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/rpm-traces.c b/kernel/trace/rpm-traces.c
index 998949e..c161c5e 100644
--- a/kernel/trace/rpm-traces.c
+++ b/kernel/trace/rpm-traces.c
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/usb.h>
 
+#ifdef CONFIG_PM_RUNTIME
 #define CREATE_TRACE_POINTS
 #include <trace/events/rpm.h>
 
@@ -18,4 +19,5 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(rpm_return_int);
 EXPORT_TRACEPOINT_SYMBOL_GPL(rpm_idle);
 EXPORT_TRACEPOINT_SYMBOL_GPL(rpm_suspend);
 EXPORT_TRACEPOINT_SYMBOL_GPL(rpm_resume);
+#endif
 
-- 
1.7.5.4


^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2011-09-28  4:51 Stephen Rothwell
  2011-09-28  5:11 ` Ming Lei
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2011-09-28  4:51 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Ming Lei

[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/trace/ftrace.h:567:0,
                 from include/trace/define_trace.h:96,
                 from include/trace/events/rpm.h:99,
                 from kernel/trace/rpm-traces.c:15:
include/trace/events/rpm.h: In function 'ftrace_raw_event_rpm_internal':
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'usage_count'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'disable_depth'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'runtime_auto'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'request_pending'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'irq_safe'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'child_count'
In file included from include/trace/ftrace.h:771:0,
                 from include/trace/define_trace.h:96,
                 from include/trace/events/rpm.h:99,
                 from kernel/trace/rpm-traces.c:15:
include/trace/events/rpm.h: In function 'perf_trace_rpm_internal':
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'usage_count'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'disable_depth'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'runtime_auto'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'request_pending'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'irq_safe'
include/trace/events/rpm.h:16:1: error: 'struct dev_pm_info' has no member named 'child_count'

Presumably caused by commit 53b615ccca56 ("PM / Runtime: Introduce trace
points for tracing rpm_* functions").

I have used the pm tree from next-20110927 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

* Re: linux-next: build failure after merge of the pm tree
  2011-08-19 13:47 Stephen Rothwell
@ 2011-08-19 21:31 ` Rafael J. Wysocki
  0 siblings, 0 replies; 110+ messages in thread
From: Rafael J. Wysocki @ 2011-08-19 21:31 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

Hi,

On Friday, August 19, 2011, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (most of the arm and
> avr32 builds at least) failed like this:
> 
> In file included from drivers/base/power/clock_ops.c:14:
> include/linux/pm_clock.h:15: error: field 'nb' has incomplete type

Sorry about that.

> You need to include something that defines "struct notifier_block".

Right, should be fixed now.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 110+ messages in thread

* linux-next: build failure after merge of the pm tree
@ 2011-08-19 13:47 Stephen Rothwell
  2011-08-19 21:31 ` Rafael J. Wysocki
  0 siblings, 1 reply; 110+ messages in thread
From: Stephen Rothwell @ 2011-08-19 13:47 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (most of the arm and
avr32 builds at least) failed like this:

In file included from drivers/base/power/clock_ops.c:14:
include/linux/pm_clock.h:15: error: field 'nb' has incomplete type

You need to include something that defines "struct notifier_block".

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 110+ messages in thread

end of thread, other threads:[~2022-06-29 13:02 UTC | newest]

Thread overview: 110+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17  7:52 linux-next: build failure after merge of the pm tree Stephen Rothwell
2020-03-18 11:44 ` Stephen Rothwell
2020-03-18 11:52   ` Colin Ian King
2020-03-18 12:18     ` Stephen Rothwell
2020-03-19  5:42       ` Stephen Rothwell
2020-03-19  9:32         ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2022-06-29  0:23 Stephen Rothwell
2022-06-29 13:01 ` Rafael J. Wysocki
2022-04-28  1:00 Stephen Rothwell
2022-04-28  3:07 ` Zhang Rui
2022-04-28  8:53 ` Zhang Rui
2022-04-28  8:56 ` Zhang Rui
2022-04-28 12:32   ` Rafael J. Wysocki
2022-01-04  0:15 Stephen Rothwell
2022-01-04  7:29 ` Heiner Kallweit
2022-01-04  8:02   ` Stephen Rothwell
2022-01-04 14:43     ` Heiner Kallweit
2022-01-04 14:57       ` Rafael J. Wysocki
2021-12-01 23:28 Stephen Rothwell
2021-12-02 10:04 ` Daniel Lezcano
2021-12-03 16:50   ` Rafael J. Wysocki
2021-12-03 17:22     ` Daniel Lezcano
2021-02-05  0:51 Stephen Rothwell
     [not found] ` <CAHp75VfiyAtxg+wqZ30kSzCfFFsLndLjzrUc1njZG0x6vQeyBQ@mail.gmail.com>
2021-02-05 11:15   ` Andy Shevchenko
2021-02-08 19:30     ` Rafael J. Wysocki
2021-02-08 19:47       ` Andy Shevchenko
2021-02-08 19:48         ` Andy Shevchenko
2021-02-09 14:32           ` Rafael J. Wysocki
2021-02-09 16:04             ` Andy Shevchenko
2020-12-09  9:57 Stephen Rothwell
2019-07-31  5:34 Stephen Rothwell
2019-07-31 10:27 ` Rafael J. Wysocki
2019-07-15  0:02 Stephen Rothwell
2019-07-15  9:44 ` Rafael J. Wysocki
2019-07-04  9:41 Stephen Rothwell
2019-07-04  9:48 ` Viresh Kumar
2019-07-04 10:33   ` Rafael J. Wysocki
2019-07-01  3:37 Stephen Rothwell
2019-07-01  7:48 ` Viresh Kumar
2018-05-24 14:16 Mark Brown
2016-09-14  4:27 Stephen Rothwell
2016-09-14 21:38 ` Rafael J. Wysocki
2016-07-22  1:56 Stephen Rothwell
2016-07-22  2:26 ` Steve Muckle
2016-07-22 12:08   ` Rafael J. Wysocki
2016-07-22 12:16     ` Fengguang Wu
2016-07-11  1:46 Stephen Rothwell
2016-07-11  4:48 ` Mika Westerberg
2016-07-11  5:29   ` Stephen Rothwell
2016-07-11 12:57     ` Rafael J. Wysocki
2016-06-02  2:12 Stephen Rothwell
2016-04-01  1:27 Stephen Rothwell
2016-04-01 20:51 ` Rafael J. Wysocki
2015-12-09  1:54 Stephen Rothwell
2015-12-09  2:00 ` Viresh Kumar
2015-11-01  6:57 Stephen Rothwell
2015-11-02  0:37 ` Rafael J. Wysocki
2015-04-13  4:24 Stephen Rothwell
2015-04-13 12:06 ` Rafael J. Wysocki
2015-04-15  2:30 ` Stephen Rothwell
2015-02-09  2:26 Stephen Rothwell
2015-02-09  2:53 ` Jiang Liu
2015-02-09  3:22   ` Rafael J. Wysocki
2015-02-09  5:36     ` Jiang Liu
2015-02-09  6:23       ` Lorenzo Pieralisi
2015-02-09 15:10         ` Rafael J. Wysocki
2015-02-09 15:21           ` Jiang Liu
2015-02-09 15:50             ` Lorenzo Pieralisi
2015-02-09  3:19 ` Rafael J. Wysocki
2015-02-09  3:53   ` Lorenzo Pieralisi
2014-08-11  1:57 Stephen Rothwell
2014-08-12  1:10 ` Rafael J. Wysocki
2013-12-18  1:00 Stephen Rothwell
2013-12-18  1:17 ` Rafael J. Wysocki
2013-07-05  1:24 Stephen Rothwell
2013-07-05  1:37 ` Rafael J. Wysocki
2013-03-03 23:58 Stephen Rothwell
2013-03-04 11:54 ` Rafael J. Wysocki
2013-01-30  8:48 Stephen Rothwell
2013-01-30 12:50 ` Rafael J. Wysocki
2013-01-14  0:03 Stephen Rothwell
2013-01-14 12:37 ` Rafael J. Wysocki
2013-01-14 13:22 ` Sedat Dilek
2013-01-14 18:54   ` Rafael J. Wysocki
2012-11-28  4:02 Stephen Rothwell
2012-11-28  9:32 ` Rafael J. Wysocki
2012-11-26  6:09 Stephen Rothwell
2012-11-26 10:10 ` Rafael J. Wysocki
2012-09-25  4:30 Stephen Rothwell
2012-09-25 11:51 ` Rafael J. Wysocki
2012-06-20  5:01 Stephen Rothwell
2012-06-20 22:54 ` Rafael J. Wysocki
2012-01-27  1:53 Stephen Rothwell
2012-01-27  9:35 ` Rafael J. Wysocki
2011-11-10  2:31 Stephen Rothwell
2011-11-10 12:11 ` Rafael J. Wysocki
2011-11-10 15:48   ` Tejun Heo
2011-11-11 12:27 ` Rafael J. Wysocki
2011-09-28  4:51 Stephen Rothwell
2011-09-28  5:11 ` Ming Lei
2011-09-28 13:58   ` Rafael J. Wysocki
2011-09-28 14:47     ` Ming Lei
2011-09-28 19:32       ` Rafael J. Wysocki
2011-09-29  1:32         ` Ming Lei
2011-09-29  9:26           ` Rafael J. Wysocki
2011-09-29  9:32             ` Ming Lei
2011-09-29 20:25               ` Rafael J. Wysocki
2011-09-28 14:47     ` Rafael J. Wysocki
2011-08-19 13:47 Stephen Rothwell
2011-08-19 21:31 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).