From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbeECSVL (ORCPT ); Thu, 3 May 2018 14:21:11 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37510 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbeECSVJ (ORCPT ); Thu, 3 May 2018 14:21:09 -0400 To: LKML , "linux-block@vger.kernel.org" , axboe@kernel.dk From: Randy Dunlap Subject: [PATCH -next] zram: fix printk formats in zram_drv.c Cc: Nitin Gupta , Minchan Kim , Sergey Senozhatsky Message-ID: <3652ccb1-96ef-0b0b-05d1-f661d7733dcc@infradead.org> Date: Thu, 3 May 2018 11:21:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Fix printk format warnings (seen on i386 build): ../drivers/block/zram/zram_drv.c:678:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘ssize_t’ [-Wformat=] ../drivers/block/zram/zram_drv.c:678:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘time64_t’ [-Wformat=] time64_t is 64 bits (and signed), so printing it should use %lld, not %ld. %ld (long) is only 32 bits on several architectures. Signed-off-by: Randy Dunlap Cc: Nitin Gupta Cc: Minchan Kim Cc: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20180503.orig/drivers/block/zram/zram_drv.c +++ linux-next-20180503/drivers/block/zram/zram_drv.c @@ -671,7 +671,7 @@ static ssize_t read_block_state(struct f ts = ktime_to_timespec64(zram->table[index].ac_time); copied = snprintf(kbuf + written, count, - "%12lu %12lu.%06lu %c%c%c\n", + "%12zd %12lld.%06lu %c%c%c\n", index, ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC, zram_test_flag(zram, index, ZRAM_SAME) ? 's' : '.', zram_test_flag(zram, index, ZRAM_WB) ? 'w' : '.',