LKML Archive on
help / color / mirror / Atom feed
To: "Heinz Mauelshagen" <>
Cc:, "Alasdair Kergon" <>,
	"Mike Snitzer" <>,,
Subject: Re: Re: [PATCH] dm raid: add missed unlock in raid_ctr
Date: Mon, 6 Sep 2021 10:14:24 +0800 (GMT+08:00)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> > On Fri, Sep 3, 2021 at 10:02 AM Dinghao Liu> wrote:
> > mddev_unlock() is called on all paths after we call mddev_lock_nointr(),
> > except for three error handling paths, which may cause a deadlock. This
> > bug is suggested by a static analysis tool, please advise.
> > Hi,    
> >     
> >     correct, those unlock calls are missing.    
> >
> >     As we are bailing out after md_run() with lock held,     
> >     we can clean the lot of error paths underneath up by jumping to before
> >     md_stop() and add the mddev_unlock upfront it like:    
Thanks for your advice! I will fix this and send a new patch soon.


      parent reply	other threads:[~2021-09-06  2:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03  7:55 Dinghao Liu
     [not found] ` <>
2021-09-06  2:14   ` dinghao.liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: Re: [PATCH] dm raid: add missed unlock in raid_ctr' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).