From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5BFC4320E for ; Thu, 2 Sep 2021 09:28:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B288610C8 for ; Thu, 2 Sep 2021 09:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245734AbhIBJ3V (ORCPT ); Thu, 2 Sep 2021 05:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343506AbhIBJ3M (ORCPT ); Thu, 2 Sep 2021 05:29:12 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECE38C061757 for ; Thu, 2 Sep 2021 02:28:13 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id b10so1878581wru.0 for ; Thu, 02 Sep 2021 02:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JulsKOOHoUI648OBMneLJD+Pe4T/1GCL07CNgEfZXgk=; b=rvX9zXCID20fIilvSAkjd4Ra9SnD24QjvpUrI6S1ze5XFnydaO4qW+BEsfoFNGCvpe 8h+uMZG5ERJA2X+9BfuQxTv//xrju7s2W8HlEl4cwfAWZY83IAf3eh8ab9EoHAUAu1Y+ 2makvCsDrQd0ggTyLREza3i6Xp2H6YErAiqubL7CS6xjSNRfRMzaFOu04J3MuLBJJTpy KLuHysnpMQ+aQ0QVaF6jci/cCB0dKxq/VaZaT3it9ggFNRbA8L0uTcQUL3zgz4UcgZfI qSFMrogIpYuyzhZ4UxigzMfGAv0DQy+8SKvIRZnTdP1Ngzf1O7cvbopfo+p3P2EOSM6A 4Neg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JulsKOOHoUI648OBMneLJD+Pe4T/1GCL07CNgEfZXgk=; b=pS0bsCZScu+EwTeeOfU58d6VhYsi2OYTigRyZlmNyYtVGGZWoxbHr4+MgwyDkGZFmv vFRcRcm1mgNQWJYjA01AIZOXHAp5txxHZnZGM4WqsGxmvFs671i2S/6X4tifLfpUwuyY kEHzQV/9b1IehQdx7hlu59pWT77VB3zOwPsd/thqtCb+eMQqg2oP2Cmby4ioriM9vRoG sOrdae6EgbDJiDecflNvT8SEGseROgWLIDC56iVkGZkuFyUHKtK+FZm2H0hHtHIF8D1y +d/WR0XyD/o2KaN3i8BlrlNIV+X+5QvruMXhcCT4srKJ1Gb2fZ5uPKWGlpUbJ9lKd66K zHwQ== X-Gm-Message-State: AOAM532nfxqP1zuvafJneRjdG0tYunVa4R+It8fnsO3xEFw1kWOAOUQS Jz2o5776QM6V5AyaRXA2yuPcfA== X-Google-Smtp-Source: ABdhPJzFyo8/t2ymlfo2L3m7r4EgO6FKW9Ly2eu67gMFWa75yF0K65Cnk4haXpEkH2rlnwViTpCkMA== X-Received: by 2002:a5d:534c:: with SMTP id t12mr2494344wrv.219.1630574892606; Thu, 02 Sep 2021 02:28:12 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id z5sm1123749wmp.26.2021.09.02.02.28.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 02:28:11 -0700 (PDT) Subject: Re: [GIT PULL] Networking for v5.15 To: Dan Carpenter , John Stultz Cc: Jakub Kicinski , Linus Torvalds , David Miller , netdev , Linux Kernel Mailing List , Greg Kroah-Hartman , Bjorn Andersson References: <20210902092500.GA11020@kili> From: Srinivas Kandagatla Message-ID: <38288aff-71d4-bde2-7547-dff5ca20091c@linaro.org> Date: Thu, 2 Sep 2021 10:28:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210902092500.GA11020@kili> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2021 10:25, Dan Carpenter wrote: > I'm sorry John, > > Can you try this partial revert? I'll resend with a commit message if > it works. I was about to send similar patch. This should work, I think your original patch introduced a qrtr packet payload alignment constraint which was not there originally. Tested-by: Srinivas Kandagatla --srini > > --- > net/qrtr/qrtr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c > index 525e3ea063b1..ec2322529727 100644 > --- a/net/qrtr/qrtr.c > +++ b/net/qrtr/qrtr.c > @@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len) > goto err; > } > > - if (!size || size & 3 || len != size + hdrlen) > + if (!size || len != ALIGN(size, 4) + hdrlen) > goto err; > > if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA && >