LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: torvic9@mailbox.org
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"clang-built-linux@googlegroups.com" 
	<clang-built-linux@googlegroups.com>
Subject: Re: [PATCH 1/2] x86, Makefile: Move the CPU-specific 64-bit tuning settings to arch/x86/Makefile.cpu
Date: Wed, 18 Aug 2021 11:46:16 +0200 (CEST)	[thread overview]
Message-ID: <385024923.121081.1629279976794@office.mailbox.org> (raw)
In-Reply-To: <YRyyicOaNu/HDgJR@infradead.org>


> Christoph Hellwig <hch@infradead.org> hat am 18.08.2021 09:11 geschrieben:
> 
>  
> On Tue, Aug 17, 2021 at 04:23:09PM +0200, torvic9@mailbox.org wrote:
> > +# SPDX-License-Identifier: GPL-2.0
> > +# CPU tuning section (64-bit) - shared with UML.
> > +# Must change only cflags-y (or [yn]), not CFLAGS! That makes a difference for UML.
> 
> Plase avoid the overly long line.  Also having an empty line between the
> SPDX tag and the actual top of the file comment really helps readability.

It's a copy-paste from the existing Makefile_32.cpu, so I guess it has to
be changed there as well?

  reply	other threads:[~2021-08-18  9:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 14:23 torvic9
2021-08-17 14:24 ` [PATCH 2/2] x86, Makefile: Add new generic x86-64 settings v2/v3/v4 torvic9
2021-08-17 18:17   ` Nick Desaulniers
2021-08-17 18:22     ` Nick Desaulniers
2021-08-17 18:31       ` Tor Vic
2021-08-17 18:47         ` Nick Desaulniers
2021-08-17 18:36   ` Borislav Petkov
2021-08-17 19:12     ` Tor Vic
2021-08-18 15:08     ` torvic9
2021-08-18 17:59       ` Borislav Petkov
2021-08-18 18:28         ` Tor Vic
2021-08-18 18:43           ` Borislav Petkov
2021-08-18  7:15   ` Christoph Hellwig
2021-08-18  9:46     ` torvic9
2021-08-19 21:58     ` David Laight
2021-08-17 17:58 ` [PATCH 1/2] x86, Makefile: Move the CPU-specific 64-bit tuning settings to arch/x86/Makefile.cpu Nick Desaulniers
2021-08-17 18:28   ` Tor Vic
2021-08-18  7:11 ` Christoph Hellwig
2021-08-18  9:46   ` torvic9 [this message]
2021-08-18 14:51 ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=385024923.121081.1629279976794@office.mailbox.org \
    --to=torvic9@mailbox.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH 1/2] x86, Makefile: Move the CPU-specific 64-bit tuning settings to arch/x86/Makefile.cpu' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).