LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Bryan Wu" <cooloney@kernel.org>
To: "Javier Herrero" <jherrero@hvsistemas.es>
Cc: "Vojtech Pavlik" <vojtech@suse.cz>,
	"Bryan Wu" <bryan.wu@analog.com>,
	"Will Newton" <will.newton@gmail.com>,
	dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 try#2] [INPUT] keypad driver: Added support for OpenCores Keyboard Controller
Date: Mon, 12 May 2008 13:50:42 +0800	[thread overview]
Message-ID: <386072610805112250p33e1c10cm347682fc5fe40d55@mail.gmail.com> (raw)
In-Reply-To: <47A84979.5080004@hvsistemas.es>

On Tue, Feb 5, 2008 at 7:33 PM, Javier Herrero <jherrero@hvsistemas.es> wrote:
> Vojtech Pavlik escribió:
>>
>> On Tue, Feb 05, 2008 at 12:18:15PM +0100, Javier Herrero wrote:
>>>
>>> Dear Vojtech,
>>>
>>> I think that a 1:1 mapping between linux keycodes and what keyboard sends
>>> is right, because the scan code to key code conversion is already programmed
>>> and done inside the FPGA code.
>>
>> And the FPGA code changes with different keyboards attached?
>>
> The original OpenCores keyboard controller is a 6 rows x 12 cols keyboard
> controller that can be customized for other row/col sizes modifiying
> Constants.vhd VHDL file, in which also the translation table is defined, and
> for different key disposition schemes both the number of rows and cols can
> be changed. We are currently using this controller with a 4x4 key matrix,
> and with a different key mapping values, so I thought that it would be
> preferable to have the driver mapping fixed to 1:1 and do the mapping in the
> VHDL, since in most cases the keyboard using this controller would be
> different to the default keyboard defined in the original Contants.vhd VHDL
> file.
>
> Regards,
>
> Javier
>

Hi Vojtech, Will and Dmitry,

How do you think of this driver from Javier?
It works fine on Blackfin arch, but it can also be shared by other platform.
So this driver is useful of the other developers.
Could you please consider merging this driver?

If you need me to resend this patch, please ping me.

Thanks
-Bryan

      reply	other threads:[~2008-05-12  5:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30  9:50 [PATCH 1/1] " Bryan Wu
2008-01-30 11:53 ` Will Newton
2008-01-30 17:07   ` Bryan Wu
2008-01-30 17:18   ` [PATCH 1/1 try#2] " Bryan Wu
2008-02-05 10:42     ` Vojtech Pavlik
2008-02-05 11:18       ` Javier Herrero
2008-02-05 11:22         ` Vojtech Pavlik
2008-02-05 11:33           ` Javier Herrero
2008-05-12  5:50             ` Bryan Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=386072610805112250p33e1c10cm347682fc5fe40d55@mail.gmail.com \
    --to=cooloney@kernel.org \
    --cc=bryan.wu@analog.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jherrero@hvsistemas.es \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    --cc=will.newton@gmail.com \
    --subject='Re: [PATCH 1/1 try#2] [INPUT] keypad driver: Added support for OpenCores Keyboard Controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).