LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Luming Yu" <luming.yu@gmail.com>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
	"Jeff Garzik" <jgarzik@pobox.com>
Subject: Re: [PATCH] ATA convert GSI to irq on ia64
Date: Thu, 8 Feb 2007 17:17:40 +0800	[thread overview]
Message-ID: <3877989d0702080117j6ee666aahbb89ca0098ca38a5@mail.gmail.com> (raw)
In-Reply-To: <3877989d0702080115o15feb447h73e3fa310bc09fb4@mail.gmail.com>

sorry, it should be
#define ATA_PRIMARY_IRQ(dev)  ide_default_irq(0x1F0)

On 2/8/07, Luming Yu <luming.yu@gmail.com> wrote:
> if use ide_default_irq , then I guess the #if defined can be removed.
> #define ATA_PRIMARY_IRQ(dev)   isa_irq_to_vector(0x1F0)
>
>
> On 2/8/07, Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:
> > If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the
> > fixed irq number. On ia64 platform, such numbers are GSI and should be converted
> > to irq vector.
> >
> > Below patch against kernel 2.6.20 fixes it.
> >
> > Signed-off-by: Zhang Yanmin <yanmin.zhang@intel.com>
> >
> > ---
> >
> > diff -Nraup linux-2.6.20/include/asm-generic/libata-portmap.h linux-2.6.20_fix/include/asm-generic/libata-portmap.h
> > --- linux-2.6.20/include/asm-generic/libata-portmap.h   2007-02-08 15:13:44.000000000 +0800
> > +++ linux-2.6.20_fix/include/asm-generic/libata-portmap.h       2007-02-08 15:20:13.000000000 +0800
> > @@ -3,10 +3,20 @@
> >
> >  #define ATA_PRIMARY_CMD                0x1F0
> >  #define ATA_PRIMARY_CTL                0x3F6
> > +#if defined(__ia64__)
> > +#define ATA_PRIMARY_IRQ(dev)   isa_irq_to_vector(14)
> > +#else
> >  #define ATA_PRIMARY_IRQ(dev)   14
> > +#endif
> > +
> >
> >  #define ATA_SECONDARY_CMD      0x170
> >  #define ATA_SECONDARY_CTL      0x376
> > +#if defined(__ia64__)
> > +#define ATA_SECONDARY_IRQ(dev) isa_irq_to_vector(15)
> > +#else
> >  #define ATA_SECONDARY_IRQ(dev) 15
> > +#endif
> > +
> >
> >  #endif
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >
>

  reply	other threads:[~2007-02-08  9:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  7:40 Zhang, Yanmin
2007-02-08  9:15 ` Luming Yu
2007-02-08  9:17   ` Luming Yu [this message]
2007-02-09  1:07     ` Zhang, Yanmin
2007-02-08 19:42 ` Christoph Hellwig
2007-02-08 20:25   ` Andrew Morton
2007-02-08 20:34     ` Christoph Hellwig
2007-02-08 20:46       ` Andrew Morton
2007-02-09  1:19 ` Jeff Garzik
2007-02-09  3:29   ` Zhang, Yanmin
2007-02-15 23:09     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3877989d0702080117j6ee666aahbb89ca0098ca38a5@mail.gmail.com \
    --to=luming.yu@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=yanmin_zhang@linux.intel.com \
    --subject='Re: [PATCH] ATA convert GSI to irq on ia64' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).