LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Neil Armstrong <narmstrong@baylibre.com>,
	airlied@linux.ie, hans.verkuil@cisco.com, lee.jones@linaro.org,
	olof@lixom.net, seanpaul@google.com
Cc: sadolfsson@google.com, felixe@google.com, bleung@google.com,
	darekm@google.com, marcheu@chromium.org, fparent@baylibre.com,
	dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi
Date: Tue, 15 May 2018 08:34:06 +0200	[thread overview]
Message-ID: <38dcd327-004c-3fb3-8e22-3b3b92542fc9@xs4all.nl> (raw)
In-Reply-To: <1526337639-3568-4-git-send-email-narmstrong@baylibre.com>

On 05/15/2018 12:40 AM, Neil Armstrong wrote:
> This patchs adds the cec_notifier feature to the intel_hdmi part
> of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate
> between each HDMI ports.
> The changes will allow the i915 HDMI code to notify EDID and HPD changes
> to an eventual CEC adapter.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/gpu/drm/i915/intel_drv.h  |  2 ++
>  drivers/gpu/drm/i915/intel_hdmi.c | 10 ++++++++++

The Kconfig also needs to be changed. In the DRM_I915 you need to add:

	select CEC_CORE if CEC_NOTIFIER

Otherwise you'll get problems if the cec driver is a module and i915 is built-in.

Regards,

	Hans

  parent reply	other threads:[~2018-05-15  6:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 22:40 [RFC PATCH 0/5] Add ChromeOS EC CEC Support Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 1/5] mfd: cros_ec_dev: Add CEC sub-device registration Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name Neil Armstrong
2018-05-15  6:27   ` Hans Verkuil
2018-05-15  7:28     ` Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi Neil Armstrong
2018-05-15  6:29   ` Hans Verkuil
2018-05-15  7:30     ` Neil Armstrong
2018-05-15  6:34   ` Hans Verkuil [this message]
2018-05-15  7:29     ` Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 4/5] mfd: cros-ec: Introduce CEC commands and events definitions Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver Neil Armstrong
2018-05-15  6:58   ` Hans Verkuil
2018-05-15  7:25     ` Neil Armstrong
2018-05-15  8:10       ` Hans Verkuil
2018-05-15  8:28         ` Neil Armstrong
2018-05-15  8:30           ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38dcd327-004c-3fb3-8e22-3b3b92542fc9@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=airlied@linux.ie \
    --cc=bleung@google.com \
    --cc=darekm@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felixe@google.com \
    --cc=fparent@baylibre.com \
    --cc=hans.verkuil@cisco.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=marcheu@chromium.org \
    --cc=narmstrong@baylibre.com \
    --cc=olof@lixom.net \
    --cc=sadolfsson@google.com \
    --cc=seanpaul@google.com \
    --subject='Re: [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).