LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kgunda@codeaurora.org
To: Rob Herring <robh@kernel.org>
Cc: bjorn.andersson@linaro.org, Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Mark Rutland <mark.rutland@arm.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral
Date: Tue, 08 May 2018 15:34:19 +0530 [thread overview]
Message-ID: <398b0fafebdcad8072d592c2ab812286@codeaurora.org> (raw)
In-Reply-To: <20180507164534.GB21042@rob-hp-laptop>
On 2018-05-07 22:15, Rob Herring wrote:
> On Thu, May 03, 2018 at 03:42:29PM +0530, Kiran Gunda wrote:
>> WLED4 peripheral is present on some PMICs like pmi8998
>> and pm660l. It has a different register map and also
>> configurations are different. Add support for it.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>> .../bindings/leds/backlight/qcom-wled.txt | 172 ++++-
>
> Please split bindings to a separate patch.
>
> This is also a whole lot of churn re-formatting. That is fine, but
> don't
> mix actual changes to the binding with re-formatting. You can do 2
> patches in this case:
>
> - move and reformat (as long as the move shows up as a move
> and not a remove and add)
> - additions for new chips
>
Sure. I will do it in the next series.
>> drivers/video/backlight/qcom-wled.c | 749
>> +++++++++++++++------
>> 2 files changed, 696 insertions(+), 225 deletions(-)
next prev parent reply other threads:[~2018-05-08 10:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:12 [PATCH V2 0/5] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-05-03 10:12 ` [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-05-04 15:55 ` Jingoo Han
2018-05-07 5:56 ` kgunda
2018-05-08 8:36 ` Daniel Thompson
2018-05-08 9:53 ` kgunda
2018-05-07 16:40 ` Rob Herring
2018-05-08 10:25 ` kgunda
2018-05-08 8:43 ` Daniel Thompson
2018-05-03 10:12 ` [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-05-07 16:45 ` Rob Herring
2018-05-08 10:04 ` kgunda [this message]
2018-05-03 10:12 ` [PATCH V2 3/5] backlight: qcom-wled: Add support for short circuit handling Kiran Gunda
2018-05-08 10:35 ` Daniel Thompson
2018-05-09 5:30 ` kgunda
2018-05-03 10:12 ` [PATCH V2 4/5] backlight: qcom-wled: Add support for OVP interrupt handling Kiran Gunda
2018-05-08 10:39 ` Daniel Thompson
2018-05-09 5:17 ` kgunda
2018-05-03 10:12 ` [PATCH V2 5/5] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=398b0fafebdcad8072d592c2ab812286@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--subject='Re: [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).