LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "BALBIR SINGH" <balbir.singh@wipro.com>
To: "David S. Miller" <davem@redhat.com>
Cc: alan@lxorguk.ukuu.org.uk, torvalds@transmeta.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Trivial patch for SIOCGIFCOUNT
Date: Wed, 10 Oct 2001 11:06:29 +0530	[thread overview]
Message-ID: <3BC3DE5D.8000500@wipro.com> (raw)
In-Reply-To: <3BC2FA63.6070006@wipro.com> <20011009.153746.59466398.davem@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

David S. Miller wrote:

>   From: "BALBIR SINGH" <balbir.singh@wipro.com>
>   Date: Tue, 09 Oct 2001 18:53:47 +0530
>
>   	To make the API orthogonal, I have included a patch for SIOCGIFCOUNT,
>   which currently returns -EINVAL. The only reason I am providing this patch
>   is to make the API complete and make it easier to port applications from
>   other UNIX like OS'es.
>
>There is no need for this change, and _EVEN_ if we put this
>change in today every APP out there would _STILL_ need to deal with
>all existing kernels which do not have SIOCGIFCOUNT implemented.
>
>Furthermore, SIOCGIFCOUNT also gives no new functionality that does
>not exist already.  SIOCGIFCONF with a zero size with give the
>behavior necessary to get the same answer as a SIOCGIFCOUNT would
>provide.  As far as I am aware, every system providing BSD sockets
>provides this SIOCGIFCONF "feature".
>
>Therefore, it is already quite easy to make applications portable
>between Linux and other BSD socket based systems.  Simply use the
>SIOCGIFCONF method throughout.
>
I had mentioned even earlier, the same functionality can be obtained otherwise.
I was talking about porting from SUN, HP-UX, AIX, etc. I have had people coming
to me and telling me that SIOCGIFNUM (equivalent to SIOCGIFCOUNT) does not exist
and I have had to ask them to use SIOCGIFCONF, if ifc.ifc_len and ifc.ifc_buf set
to '0', to obtain the total size. Again, it is not a must it should be around.
But since the ioctl is there, it might be good to have it work the way some one
reading a man page would expect it to work, or if somebody wanted to port some
application from Sun, HP-UX or AIX would just do

#define SIOCGIFNUM SIOCGIFCOUNT

and get his application to compile without changing the code

Regards,
Balbir

>
>Franks a lot,
>David S. Miller
>davem@redhat.com
>
>




[-- Attachment #2: Wipro_Disclaimer.txt --]
[-- Type: text/plain, Size: 853 bytes --]

----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and
is intended for use only by the individual or entity to which it is
addressed, and may contain information that is privileged, confidential or
exempt from disclosure under applicable law. If you are not the intended
recipient or it appears that this mail has been forwarded to you without
proper authority, you are notified that any use or dissemination of this
information in any manner is strictly prohibited. In such cases, please
notify us immediately at mailto:mailadmin@wipro.com and delete this mail
from your records.
----------------------------------------------------------------------------------------------------------------------


  reply	other threads:[~2001-10-10  5:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-09 13:23 BALBIR SINGH
2001-10-09 22:37 ` David S. Miller
2001-10-10  5:36   ` BALBIR SINGH [this message]
2001-10-10 18:31     ` kuznet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BC3DE5D.8000500@wipro.com \
    --to=balbir.singh@wipro.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --subject='Re: [PATCH] Trivial patch for SIOCGIFCOUNT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).