LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>,
	syzbot <syzbot+7b938780d5deeaaf938f@syzkaller.appspotmail.com>,
	davem@davemloft.net, johan.hedberg@gmail.com, kuba@kernel.org,
	linux-bluetooth@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, luiz.dentz@gmail.com,
	marcel@holtmann.org, mathew.j.martineau@linux.intel.com,
	netdev@vger.kernel.org, pabeni@redhat.com,
	syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk
Subject: Re: [syzbot] KFENCE: use-after-free in kvm_fastop_exception
Date: Wed, 18 Aug 2021 11:55:19 +0300	[thread overview]
Message-ID: <3a8dd8db-61d6-603e-b270-5faf1be02c6b@gmail.com> (raw)
In-Reply-To: <32aeb66e-d4f0-26b5-a140-4477bb87067f@tessares.net>

On 8/18/21 11:21 AM, Matthieu Baerts wrote:
> Hi Pavel,
> 
[snip]
>>>
>>> I'm pretty sure the commit c4512c63b119 ("mptcp: fix 'masking a bool'
>>> warning") doesn't introduce the reported bug. This minor fix is specific
>>> to MPTCP which doesn't seem to be used here.
>>>
>>> I'm not sure how I can tell syzbot this is a false positive.
>>>
>> 
>> 
>> looks like it's fs/namei bug. Similar reports:
>> 
>> https://syzkaller.appspot.com/bug?id=517fa734b92b7db404c409b924cf5c997640e324
>> 
>> 
>> https://syzkaller.appspot.com/bug?id=484483daf3652b40dae18531923aa9175d392a4d
> 
> Thank you for having checked!
> Should we mark them as "#syz dup" if you think they have the same root
> cause?
> 

I think, yes, but I want to receive feedback from fs people about this 
bug. There were huge updates last month, and, maybe, I am missing some 
details. Alloc/free calltrace is the same, but anyway, I want some 
confirmation to not close different bugs by mistake :)

If these bugs really have same root case I will close them manually 
after fix posted.

>> It's not false positive. I've suggested the fix here:
>> https://groups.google.com/g/syzkaller-bugs/c/HE3c2fP5nic/m/1Yk17GBeAwAJ
>> I am waiting for author comments about the fix :)
>> 
>> But, yes, syzbot bisection is often wrong, so don't rely on it much :)
> 
> Yes sorry, I wanted to say the bisection picked a wrong commit :)
> 
> All good then if syzbot often blames the wrong modification :)
> 
With regards,
Pavel Skripkin

  reply	other threads:[~2021-08-18  8:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  8:27 syzbot
2021-08-16 22:01 ` syzbot
2021-08-17 22:21 ` syzbot
2021-08-18  8:02   ` Matthieu Baerts
2021-08-18  8:12     ` Pavel Skripkin
2021-08-18  8:21       ` Matthieu Baerts
2021-08-18  8:55         ` Pavel Skripkin [this message]
2021-08-18  8:57           ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a8dd8db-61d6-603e-b270-5faf1be02c6b@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+7b938780d5deeaaf938f@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [syzbot] KFENCE: use-after-free in kvm_fastop_exception' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).