LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos.
Date: Tue, 21 May 2019 17:54:21 +0000 [thread overview]
Message-ID: <3ac55e59-a75c-0b9a-be24-148007bb522e@c-s.fr> (raw)
In-Reply-To: <1449c1a24e2e06ac6c8c2e1b7f73feedfd51894c.1558445259.git.christophe.leroy@c-s.fr>
Hi Joe & Andy
On 05/21/2019 01:34 PM, Christophe Leroy wrote:
> The talitos driver has two ways to perform AEAD depending on the
> HW capability. Some HW support both. It is needed to give them
> different names to distingish which one it is for instance when
> a test fails.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Fixes: 7405c8d7ff97 ("crypto: talitos - templates for AEAD using HMAC_SNOOP_NO_AFEU")
> Cc: stable@vger.kernel.org
> ---
> drivers/crypto/talitos.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index f443cbe7da80..6f8bc6467706 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -2356,7 +2356,7 @@ static struct talitos_alg_template driver_algs[] = {
> .base = {
> .cra_name = "authenc(hmac(sha1),cbc(aes))",
> .cra_driver_name = "authenc-hmac-sha1-"
> - "cbc-aes-talitos",
> + "cbc-aes-talitos-hsna",
checkpatch reports the following warning on the above:
WARNING: quoted string split across lines
#27: FILE: drivers/crypto/talitos.c:2359:
.cra_driver_name = "authenc-hmac-sha1-"
+ "cbc-aes-talitos-hsna",
But when I fixes the patch as follows, I get another warning:
@@ -2355,8 +2355,7 @@ static struct talitos_alg_template driver_algs[] = {
.alg.aead = {
.base = {
.cra_name = "authenc(hmac(sha1),cbc(aes))",
- .cra_driver_name = "authenc-hmac-sha1-"
- "cbc-aes-talitos",
+ .cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos-hsna",
.cra_blocksize = AES_BLOCK_SIZE,
.cra_flags = CRYPTO_ALG_ASYNC,
},
WARNING: line over 80 characters
#28: FILE: drivers/crypto/talitos.c:2358:
+ .cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos-hsna",
So, how should this be fixed ?
Thanks
Christophe
> .cra_blocksize = AES_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
> @@ -2401,7 +2401,7 @@ static struct talitos_alg_template driver_algs[] = {
> .cra_name = "authenc(hmac(sha1),"
> "cbc(des3_ede))",
> .cra_driver_name = "authenc-hmac-sha1-"
> - "cbc-3des-talitos",
> + "cbc-3des-talitos-hsna",
> .cra_blocksize = DES3_EDE_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
> @@ -2444,7 +2444,7 @@ static struct talitos_alg_template driver_algs[] = {
> .base = {
> .cra_name = "authenc(hmac(sha224),cbc(aes))",
> .cra_driver_name = "authenc-hmac-sha224-"
> - "cbc-aes-talitos",
> + "cbc-aes-talitos-hsna",
> .cra_blocksize = AES_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
> @@ -2489,7 +2489,7 @@ static struct talitos_alg_template driver_algs[] = {
> .cra_name = "authenc(hmac(sha224),"
> "cbc(des3_ede))",
> .cra_driver_name = "authenc-hmac-sha224-"
> - "cbc-3des-talitos",
> + "cbc-3des-talitos-hsna",
> .cra_blocksize = DES3_EDE_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
> @@ -2532,7 +2532,7 @@ static struct talitos_alg_template driver_algs[] = {
> .base = {
> .cra_name = "authenc(hmac(sha256),cbc(aes))",
> .cra_driver_name = "authenc-hmac-sha256-"
> - "cbc-aes-talitos",
> + "cbc-aes-talitos-hsna",
> .cra_blocksize = AES_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
> @@ -2577,7 +2577,7 @@ static struct talitos_alg_template driver_algs[] = {
> .cra_name = "authenc(hmac(sha256),"
> "cbc(des3_ede))",
> .cra_driver_name = "authenc-hmac-sha256-"
> - "cbc-3des-talitos",
> + "cbc-3des-talitos-hsna",
> .cra_blocksize = DES3_EDE_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
> @@ -2706,7 +2706,7 @@ static struct talitos_alg_template driver_algs[] = {
> .base = {
> .cra_name = "authenc(hmac(md5),cbc(aes))",
> .cra_driver_name = "authenc-hmac-md5-"
> - "cbc-aes-talitos",
> + "cbc-aes-talitos-hsna",
> .cra_blocksize = AES_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
> @@ -2749,7 +2749,7 @@ static struct talitos_alg_template driver_algs[] = {
> .base = {
> .cra_name = "authenc(hmac(md5),cbc(des3_ede))",
> .cra_driver_name = "authenc-hmac-md5-"
> - "cbc-3des-talitos",
> + "cbc-3des-talitos-hsna",
> .cra_blocksize = DES3_EDE_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
>
next prev parent reply other threads:[~2019-05-21 17:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 13:34 [PATCH v1 00/15] Fixing selftests failure on Talitos driver Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 01/15] crypto: talitos - fix skcipher failure due to wrong output IV Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos Christophe Leroy
2019-05-21 17:54 ` Christophe Leroy [this message]
2019-05-21 18:10 ` Joe Perches
2019-05-21 13:34 ` [PATCH v1 03/15] crypto: talitos - reduce max key size for SEC1 Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 04/15] crypto: talitos - check AES key size Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 05/15] crypto: talitos - fix CTR alg blocksize Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 06/15] crypto: talitos - check data blocksize in ablkcipher Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 07/15] crypto: talitos - fix ECB algs ivsize Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 08/15] crypto: talitos - Do not modify req->cryptlen on decryption Christophe Leroy
2019-05-28 8:20 ` Horia Geanta
2019-05-21 13:34 ` [PATCH v1 09/15] crypto: talitos - HMAC SNOOP NO AFEU mode requires SW icv checking Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 10/15] crypto: talitos - properly handle split ICV Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 11/15] crypto: talitos - Align SEC1 accesses to 32 bits boundaries Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 12/15] crypto: talitos - fix AEAD processing Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 13/15] Revert "crypto: talitos - export the talitos_submit function" Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 14/15] crypto: talitos - use IS_ENABLED() in has_ftr_sec1() Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 15/15] crypto: talitos - use SPDX-License-Identifier Christophe Leroy
2019-05-28 9:17 ` [PATCH v1 00/15] Fixing selftests failure on Talitos driver Horia Geanta
2019-05-28 16:48 ` Christophe Leroy
2019-05-30 13:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac55e59-a75c-0b9a-be24-148007bb522e@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).