LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] edac: fix skx_edac build error when ACPI_NFIT=m
@ 2018-05-13 17:35 Randy Dunlap
  2018-05-14  9:37 ` Borislav Petkov
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-05-13 17:35 UTC (permalink / raw)
  To: LKML, Linux Edac Mailing List
  Cc: Andrew Morton, Tony Luck, Borislav Petkov, Mauro Carvalho Chehab

From: Randy Dunlap <rdunlap@infradead.org>

Prevent build error when CONFIG_ACPI_NFIT=m and CONFIG_EDAC_SKX=y
by limiting EDAC_SKX based on how ACPI_NFIT is set.

Fixes this build error:
drivers/edac/skx_edac.o: In function `get_nvdimm_info':
../drivers/edac/skx_edac.c:399: undefined reference to `nfit_get_smbios_id'

Fixes: 58ca9ac1463d ("EDAC, skx_edac: Detect non-volatile DIMMs")

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: stable@vger.kernel.org
---
 drivers/edac/Kconfig |    1 +
 1 file changed, 1 insertion(+)

v2: add comment in Kconfig file

--- lnx-417-rc4.orig/drivers/edac/Kconfig
+++ lnx-417-rc4/drivers/edac/Kconfig
@@ -232,6 +232,7 @@ config EDAC_SBRIDGE
 config EDAC_SKX
 	tristate "Intel Skylake server Integrated MC"
 	depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
+	depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y
 	select DMI
 	help
 	  Support for error detection and correction the Intel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] edac: fix skx_edac build error when ACPI_NFIT=m
  2018-05-13 17:35 [PATCH v2] edac: fix skx_edac build error when ACPI_NFIT=m Randy Dunlap
@ 2018-05-14  9:37 ` Borislav Petkov
  0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2018-05-14  9:37 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: LKML, Linux Edac Mailing List, Andrew Morton, Tony Luck,
	Mauro Carvalho Chehab

On Sun, May 13, 2018 at 10:35:44AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Prevent build error when CONFIG_ACPI_NFIT=m and CONFIG_EDAC_SKX=y
> by limiting EDAC_SKX based on how ACPI_NFIT is set.
> 
> Fixes this build error:
> drivers/edac/skx_edac.o: In function `get_nvdimm_info':
> ../drivers/edac/skx_edac.c:399: undefined reference to `nfit_get_smbios_id'
> 
> Fixes: 58ca9ac1463d ("EDAC, skx_edac: Detect non-volatile DIMMs")
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: stable@vger.kernel.org
> ---
>  drivers/edac/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> v2: add comment in Kconfig file
> 
> --- lnx-417-rc4.orig/drivers/edac/Kconfig
> +++ lnx-417-rc4/drivers/edac/Kconfig
> @@ -232,6 +232,7 @@ config EDAC_SBRIDGE
>  config EDAC_SKX
>  	tristate "Intel Skylake server Integrated MC"
>  	depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
> +	depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y
>  	select DMI
>  	help
>  	  Support for error detection and correction the Intel
--

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-14  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-13 17:35 [PATCH v2] edac: fix skx_edac build error when ACPI_NFIT=m Randy Dunlap
2018-05-14  9:37 ` Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).