LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: jbrunet@baylibre.com, linux-amlogic@lists.infradead.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] clk: meson: g12a: Add support for G12B CPUB clocks
Date: Wed, 29 May 2019 12:23:32 +0200	[thread overview]
Message-ID: <3b546e23-50f1-0261-4409-d4812fd28bfb@baylibre.com> (raw)
In-Reply-To: <CAFBinCCMfTL337=HtvoXDDznfqhH+i0N6NAj8qBPso84XFoJBg@mail.gmail.com>

On 28/05/2019 20:13, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Tue, May 28, 2019 at 10:08 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Update the Meson G12A Clock driver to support the Amlogic G12B SoC.
>>
>> G12B clock driver is very close, the main differences are :
>> - the clock tree is duplicated for the both clusters, and the
>>   SYS_PLL are swapped between the clusters
>> - G12B has additional clocks like for CSI an other components
>>
>> Here only the cpu clock tree is handled.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> thank you for taking care of everything I noticed in the previous version!
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> do you still have the CPU post-divider muxes (which are currently
> modeled as CLK_DIVIDER_POWER_OF_TWO dividers) on your TODO-list once
> this is merged?

Yes, thanks for reviewing !

Neil

> 
> 
> Martin
> 


  reply	other threads:[~2019-05-29 10:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  8:07 [PATCH v2 0/3] clk: meson: add support for Amlogic G12B Neil Armstrong
2019-05-28  8:07 ` [PATCH v2 1/3] dt-bindings: clk: meson: add g12b periph clock controller bindings Neil Armstrong
2019-05-28  8:07 ` [PATCH v2 2/3] clk: meson: g12a: Add support for G12B CPUB clocks Neil Armstrong
2019-05-28 18:13   ` Martin Blumenstingl
2019-05-29 10:23     ` Neil Armstrong [this message]
2019-05-28  8:07 ` [PATCH v2 3/3] clk: meson: g12a: mark fclk_div3 as critical Neil Armstrong
2019-06-11 12:33 ` [PATCH v2 0/3] clk: meson: add support for Amlogic G12B Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b546e23-50f1-0261-4409-d4812fd28bfb@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --subject='Re: [PATCH v2 2/3] clk: meson: g12a: Add support for G12B CPUB clocks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).