LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: "Clément Péron" <peron.clem@gmail.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	David Airlie <airlied@linux.ie>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 0/8] Allwinner H6 Mali GPU support
Date: Tue, 14 May 2019 22:56:50 +0100	[thread overview]
Message-ID: <3c2c9094-69d4-bace-d5ee-c02b7f56ac82@arm.com> (raw)
In-Reply-To: <CAJiuCccWa5UTML68JDQq6q8SyNZzVWwQWTOL=+84Bh4EMHGC3A@mail.gmail.com>

On 2019-05-14 10:22 pm, Clément Péron wrote:
> Hi,
> 
> On Tue, 14 May 2019 at 17:17, Clément Péron <peron.clem@gmail.com> wrote:
>>
>> Hi,
>>
>> On Tue, 14 May 2019 at 12:29, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>
>>> Hi,
>>>
>>> On 13/05/2019 17:14, Daniel Vetter wrote:
>>>> On Sun, May 12, 2019 at 07:46:00PM +0200, peron.clem@gmail.com wrote:
>>>>> From: Clément Péron <peron.clem@gmail.com>
>>>>>
>>>>> Hi,
>>>>>
>>>>> The Allwinner H6 has a Mali-T720 MP2. The drivers are
>>>>> out-of-tree so this series only introduce the dt-bindings.
>>>>
>>>> We do have an in-tree midgard driver now (since 5.2). Does this stuff work
>>>> together with your dt changes here?
>>>
>>> No, but it should be easy to add.
>> I will give it a try and let you know.
> Added the bus_clock and a ramp delay to the gpu_vdd but the driver
> fail at probe.
> 
> [    3.052919] panfrost 1800000.gpu: clock rate = 432000000
> [    3.058278] panfrost 1800000.gpu: bus_clock rate = 100000000
> [    3.179772] panfrost 1800000.gpu: mali-t720 id 0x720 major 0x1
> minor 0x1 status 0x0
> [    3.187432] panfrost 1800000.gpu: features: 00000000,10309e40,
> issues: 00000000,21054400
> [    3.195531] panfrost 1800000.gpu: Features: L2:0x07110206
> Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002821 AS:0xf
> JS:0x7
> [    3.207178] panfrost 1800000.gpu: shader_present=0x3 l2_present=0x1
> [    3.238257] panfrost 1800000.gpu: Fatal error during GPU init
> [    3.244165] panfrost: probe of 1800000.gpu failed with error -12
> 
> The ENOMEM is coming from "panfrost_mmu_init"
> alloc_io_pgtable_ops(ARM_MALI_LPAE, &pfdev->mmu->pgtbl_cfg,
>                                           pfdev);
> 
> Which is due to a check in the pgtable alloc "cfg->ias != 48"
> arm-lpae io-pgtable: arm_mali_lpae_alloc_pgtable cfg->ias 33 cfg->oas 40
> 
> DRI stack is totally new for me, could you give me a little clue about
> this issue ?

Heh, this is probably the one bit which doesn't really count as "DRI stack".

That's merely a somewhat-conservative sanity check - I'm pretty sure it 
*should* be fine to change the test to "cfg->ias > 48" (io-pgtable 
itself ought to cope). You'll just get to be the first to actually test 
a non-48-bit configuration here :)

Robin.

  reply	other threads:[~2019-05-14 21:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-12 17:46 peron.clem
2019-05-12 17:46 ` [PATCH v4 1/8] dt-bindings: gpu: mali-midgard: Add resets property peron.clem
2019-05-12 17:46 ` [PATCH v4 2/8] dt-bindings: gpu: add bus clock for Mali Midgard GPUs peron.clem
2019-05-12 17:46 ` [PATCH v4 3/8] dt-bindings: gpu: mali-midgard: Add H6 mali gpu compatible peron.clem
2019-05-12 17:46 ` [PATCH v4 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6 peron.clem
2019-05-12 17:46 ` [PATCH v4 5/8] arm64: dts: allwinner: Add mali GPU supply for Pine H64 peron.clem
2019-05-12 18:28   ` [linux-sunxi] " Jagan Teki
2019-05-14 10:18     ` Chen-Yu Tsai
2019-05-14 15:22       ` Clément Péron
2019-05-12 17:46 ` [PATCH v4 6/8] arm64: dts: allwinner: Add mali GPU supply for Beelink GS1 peron.clem
2019-05-12 17:46 ` [PATCH v4 7/8] arm64: dts: allwinner: Add mali GPU supply for OrangePi Boards peron.clem
2019-05-12 17:46 ` [PATCH v4 8/8] arm64: dts: allwinner: Add mali GPU supply for OrangePi 3 peron.clem
2019-05-13 15:14 ` [PATCH v4 0/8] Allwinner H6 Mali GPU support Daniel Vetter
2019-05-14 10:29   ` Neil Armstrong
2019-05-14 15:17     ` Clément Péron
2019-05-14 21:22       ` Clément Péron
2019-05-14 21:56         ` Robin Murphy [this message]
2019-05-15 22:05           ` Clément Péron
2019-05-15 23:22             ` Rob Herring
2019-05-16 11:19               ` Robin Murphy
2019-05-16 13:21                 ` Steven Price
2019-05-25 19:50                 ` [linux-sunxi] " Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c2c9094-69d4-bace-d5ee-c02b7f56ac82@arm.com \
    --to=robin.murphy@arm.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=narmstrong@baylibre.com \
    --cc=peron.clem@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH v4 0/8] Allwinner H6 Mali GPU support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).