LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>
To: "balbi@kernel.org" <balbi@kernel.org>
Cc: "rikard.falkeborn@gmail.com" <rikard.falkeborn@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"alcooperx@gmail.com" <alcooperx@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"pawell@cadence.com" <pawell@cadence.com>
Subject: Re: [PATCH 4/6] usb: gadget: tegra-xudc: fix the wrong mult value for HS isoc or intr
Date: Thu, 12 Aug 2021 11:54:10 +0000 [thread overview]
Message-ID: <3dbf2c4f28e29b7adcef94e2322d0dc773cc9d91.camel@mediatek.com> (raw)
In-Reply-To: <87k0kryx20.fsf@kernel.org>
On Thu, 2021-08-12 at 09:51 +0300, Felipe Balbi wrote:
> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
>
> > usb_endpoint_maxp() only returns the bit[10:0] of wMaxPacketSize
> > of endpoint descriptor, not includes bit[12:11] anymore, so use
> > usb_endpoint_maxp_mult() instead.
> > Meanwhile no need AND 0x7ff when get maxp, remove it.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/usb/gadget/udc/tegra-xudc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/udc/tegra-xudc.c
> > b/drivers/usb/gadget/udc/tegra-xudc.c
> > index a54d1cef17db..40a7417e7ae4 100644
> > --- a/drivers/usb/gadget/udc/tegra-xudc.c
> > +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> > @@ -1610,7 +1610,7 @@ static void
> > tegra_xudc_ep_context_setup(struct tegra_xudc_ep *ep)
> > u16 maxpacket, maxburst = 0, esit = 0;
> > u32 val;
> >
> > - maxpacket = usb_endpoint_maxp(desc) & 0x7ff;
> > + maxpacket = usb_endpoint_maxp(desc);
> > if (xudc->gadget.speed == USB_SPEED_SUPER) {
> > if (!usb_endpoint_xfer_control(desc))
> > maxburst = comp_desc->bMaxBurst;
> > @@ -1621,7 +1621,7 @@ static void
> > tegra_xudc_ep_context_setup(struct tegra_xudc_ep *ep)
> > (usb_endpoint_xfer_int(desc) ||
> > usb_endpoint_xfer_isoc(desc))) {
> > if (xudc->gadget.speed == USB_SPEED_HIGH) {
> > - maxburst = (usb_endpoint_maxp(desc) >> 11) &
> > 0x3;
> > + maxburst = usb_endpoint_maxp_mult(desc) - 1;
>
> this looks like a bug fix. Before this change, maxburst was always 0,
> right?
Yes
>
> In any case:
>
> Acked-by: Felipe Balbi <balbi@kernel.org>
>
next prev parent reply other threads:[~2021-08-12 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 3:32 [PATCH 1/6] usb: mtu3: restore HS function when set SS/SSP Chunfeng Yun
2021-08-12 3:32 ` [PATCH 2/6] usb: mtu3: fix the wrong HS mult value Chunfeng Yun
2021-08-12 6:49 ` Felipe Balbi
2021-08-12 11:51 ` Chunfeng Yun (云春峰)
2021-08-12 3:32 ` [PATCH 3/6] usb: cdnsp: fix the wrong mult value for HS isoc or intr Chunfeng Yun
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 11:53 ` Chunfeng Yun (云春峰)
2021-08-17 5:05 ` Pawel Laszczak
2021-08-17 7:10 ` Chunfeng Yun (云春峰)
2021-08-12 3:33 ` [PATCH 4/6] usb: gadget: tegra-xudc: " Chunfeng Yun
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 11:54 ` Chunfeng Yun (云春峰) [this message]
2021-08-12 3:33 ` [PATCH 5/6] usb: gadget: bdc: remove unnecessary AND operation when get ep maxp Chunfeng Yun
2021-08-12 6:52 ` Felipe Balbi
2021-08-12 3:33 ` [PATCH 6/6] usb: gadget: " Chunfeng Yun
2021-08-12 6:52 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbf2c4f28e29b7adcef94e2322d0dc773cc9d91.camel@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=Eddie.Hung@mediatek.com \
--cc=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pawell@cadence.com \
--cc=rikard.falkeborn@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=yangyingliang@huawei.com \
--subject='Re: [PATCH 4/6] usb: gadget: tegra-xudc: fix the wrong mult value for HS isoc or intr' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).