LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "davem@davemloft.net" <davem@davemloft.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"mroos@linux.ee" <mroos@linux.ee>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"namit@vmware.com" <namit@vmware.com>,
	"luto@kernel.org" <luto@kernel.org>,
	"bp@alien8.de" <bp@alien8.de>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>
Subject: Re: [PATCH v2] vmalloc: Fix issues with flush flag
Date: Tue, 21 May 2019 00:20:13 +0000	[thread overview]
Message-ID: <3e7e674c1fe094cd8dbe0c8933db18be1a37d76d.camel@intel.com> (raw)
In-Reply-To: <20190520.154855.2207738976381931092.davem@davemloft.net>

On Mon, 2019-05-20 at 15:48 -0700, David Miller wrote:
> From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
> Date: Mon, 20 May 2019 22:17:49 +0000
> 
> > Thanks for testing. So I guess that suggests it's the TLB flush
> > causing
> > the problem on sparc and not any lazy purge deadlock. I had sent
> > Meelis
> > another test patch that just flushed the entire 0 to ULONG_MAX
> > range to
> > try to always the get the "flush all" logic and apprently it didn't
> > boot mostly either. It also showed that it's not getting stuck
> > anywhere
> > in the vm_remove_alias() function. Something just hangs later.
> 
> I wonder if an address is making it to the TLB flush routines which
> is
> not page aligned.
I think vmalloc should force PAGE_SIZE alignment, but will double check
nothing got screwed up.

> Or a TLB flush is being done before the callsites
> are patched properly for the given cpu type.
Any idea how I could log when this is done? It looks like it's done
really early in boot assembly. This behavior shouldn't happen until
modules or BPF are being freed.

  reply	other threads:[~2019-05-21  0:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 20:07 Rick Edgecombe
2019-05-20 21:25 ` Andy Lutomirski
2019-05-20 21:48   ` Edgecombe, Rick P
2019-05-20 21:36 ` Meelis Roos
2019-05-20 22:17   ` Edgecombe, Rick P
2019-05-20 22:48     ` David Miller
2019-05-21  0:20       ` Edgecombe, Rick P [this message]
2019-05-21  0:33         ` David Miller
2019-05-21  1:20           ` Edgecombe, Rick P
2019-05-21  1:43             ` David Miller
2019-05-21  1:59               ` Edgecombe, Rick P
2019-05-22 17:40                 ` David Miller
2019-05-22 19:26                   ` Edgecombe, Rick P
2019-05-22 22:40                     ` Edgecombe, Rick P
2019-05-24 15:50                       ` Edgecombe, Rick P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e7e674c1fe094cd8dbe0c8933db18be1a37d76d.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mroos@linux.ee \
    --cc=namit@vmware.com \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=sparclinux@vger.kernel.org \
    --subject='Re: [PATCH v2] vmalloc: Fix issues with flush flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).