LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Amit Nischal <anischal@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Odelu Kukatla <okukatla@codeaurora.org>,
	Taniya Das <tdas@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-clk-owner@vger.kernel.org
Subject: Re: [PATCH v6 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845
Date: Mon, 07 May 2018 16:12:49 +0530	[thread overview]
Message-ID: <3f3049ee7cc151ac619cb29c3d07142c@codeaurora.org> (raw)
In-Reply-To: <152549007801.138124.1209193202019560634@swboyd.mtv.corp.google.com>

On 2018-05-05 08:44, Stephen Boyd wrote:
> Quoting Amit Nischal (2018-05-04 03:45:12)
>> On 2018-05-02 12:53, Stephen Boyd wrote:
>> > Quoting Amit Nischal (2018-04-30 09:20:10)
>> >> +
>> >> +static struct clk_branch gcc_disp_gpll0_clk_src = {
>> >> +       .halt_reg = 0x52004,
>> >> +       .halt_check = BRANCH_HALT_DELAY,
>> >
>> > What about this one? It's not a phy so I'm confused again why we're
>> > unable to check the halt bit. To be clear(er), I don't see why we ever
>> > want to have HALT_DELAY used. Hopefully we can remove that flag.
>> >
>> > From what I recall, the flag is there for clks that don't toggle their
>> > status bit at all, but that we know take a few cycles to ungate the
>> > upstream clk. So we threw a delay into the code to make sure that when
>> > clk_enable() returned, a driver wouldn't try to use hardware before the
>> > clk was actually on. But these cases should pretty much never happen,
>> > hence all the pushback against this flag.
>> >
>> 
>> For these "*gpll0_clk_src" and "*gpll0_div_clk" clocks, there is no 
>> halt
>> bit to check the status and it is required to have delay for few 
>> cycles
>> so that clock gets turned on before a client driver to use the 
>> hardware.
> 
> Ok.. but then why is there a 'halt_reg' configured for the clk?

Thanks for the review.
I will remove the halt_reg for the clocks where we are using the 
'HALT_DELAY'
flag and there is no need to poll the status bit as we are returning 
early
from the 'clk_branch_wait()' function.

> 
>> >> +
>> >> +static struct clk_branch gcc_ufs_card_rx_symbol_0_clk = {
>> >> +       .halt_reg = 0x75018,
>> >> +       .halt_check = BRANCH_HALT_DELAY,
>> >
>> > There are still HALT_DELAY flags for UFS though? Why?
>> 
>> For ufs_card tx/rx symbol clocks, we don't poll the status bit as
>> per the recommendation from the HW team. We can change the halt_check
>> type to newly implemented flag "BRANCH_HALT_SKIP". Please update us 
>> with
>> your thoughts to change the flag to "BRANCH_HALT_SKIP".
> 
> Yes use HALT_SKIP please.

Thanks for confirming. I will do the changes in the next patch series.

> 
>> 
>> >
>> > Also, are you going to send DFS support for the QUP clks? I would like
>> > to see that code merged soon.
>> 
>> Taniya has sent the patches for DFS support for QUP clocks.
>> https://patchwork.kernel.org/patch/10376951/
>> 
> 
> I'll take a look.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2018-05-07 10:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 16:20 [PATCH v6 0/3] Misc patches to support clocks " Amit Nischal
2018-04-30 16:20 ` [PATCH v6 1/3] clk: qcom: Configure the RCGs to a safe source as needed Amit Nischal
2018-05-02  7:45   ` Stephen Boyd
2018-05-03 11:57     ` Amit Nischal
2018-05-05  3:24       ` Stephen Boyd
2018-05-07 10:33         ` Amit Nischal
2018-04-30 16:20 ` [PATCH v6 2/3] clk: qcom: Add support for BRANCH_NO_DELAY flag for branch clocks Amit Nischal
2018-05-02  7:14   ` Stephen Boyd
2018-04-30 16:20 ` [PATCH v6 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845 Amit Nischal
2018-05-01 12:39   ` Rob Herring
2018-05-02  7:23   ` Stephen Boyd
2018-05-04 10:45     ` Amit Nischal
2018-05-05  3:14       ` Stephen Boyd
2018-05-07 10:42         ` Amit Nischal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f3049ee7cc151ac619cb29c3d07142c@codeaurora.org \
    --to=anischal@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk-owner@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=okukatla@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    --cc=sboyd@kernel.org \
    --cc=tdas@codeaurora.org \
    --subject='Re: [PATCH v6 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).