LKML Archive on
help / color / mirror / Atom feed
From: Shuah Khan <>
To: Christian Brauner <>,
	Michael Ellerman <>
	Shuah Khan <>,
	Shuah Khan <>
Subject: Re: [PATCH] selftests/filesystems: Don't run dnotify_test by default
Date: Tue, 10 Apr 2018 12:57:03 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 04/10/2018 03:45 AM, Christian Brauner wrote:
> On Tue, Apr 10, 2018 at 04:20:53PM +1000, Michael Ellerman wrote:
>> In commit ce290a19609d ("selftests: add devpts selftests"), the
>> filesystems directory was added to the top-level selftests Makefile.
>> That had the effect of causing the existing dnotify_test in the
>> filesystems directory to now be run as part of the default selftests
>> test-run. Unfortunately dnotify_test is actually an infinite loop.
>> Fix it by moving dnotify_test to TEST_GEN_PROGS_EXTENDED, which says
>> that it's a generated file (ie. built) but should not be run as part
>> of the default test suite run (it's an "extendend" test).

Typo - I can fix it when I apply it.

>> While we're here cleanup a few other things, devpts_pts should be in
>> TEST_GEN_PROGS to indicate that it's built, and with the above two
>> changes we no longer need a custom all or clean rule.
>> Fixes: ce290a19609d ("selftests: add devpts selftests")
>> Signed-off-by: Michael Ellerman <>
> I'm not sure if I should've made it to be built given that it wasn't
> before but it probably doesn't hurt. It's either that or remove it I
> guess.

This way the test gets built and gets included in the installed tests.
This way somebody can run it by itself.
> Acked-by: Christian brauner <>

Thanks Michael. I will get this into 4.17-rc2 or rc3.

-- Shuah

  reply	other threads:[~2018-04-10 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10  6:20 [PATCH] selftests/filesystems: Don't run dnotify_test by default Michael Ellerman
2018-04-10  9:45 ` Christian Brauner
2018-04-10 18:57   ` Shuah Khan [this message]
2018-04-11  3:24     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).