LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Kenichi Okuyama" <kenichi.okuyama@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] NULL pointer check for vma->vm_mm
Date: Sat, 2 Feb 2008 02:39:23 +0900	[thread overview]
Message-ID: <3fd7d7a70802010939q67770628r47ca8a23fb26ca1d@mail.gmail.com> (raw)
In-Reply-To: <20080201021917.5db3448d.akpm@linux-foundation.org>

Dear Andrew,
Sorry that it took very long before I could reply.

2008/2/1, Andrew Morton <akpm@linux-foundation.org>:
> On Fri, 1 Feb 2008 17:24:17 +0900 "Kenichi Okuyama" <kenichi.okuyama@gmail.com> wrote:
>
> > First of all, thank you for looking at the patch.
> >
> > I do agree that if mm is NULL, system will call Oops anyway.
> However, since it's oops, it does not stop the system, nor call kdump.
>
> That would be a huge bug in kdump?  Surely it dumps when the kernel oopses?

I'm sorry.
Oops did dump on my home pc. But it didn't on my office pc.
I'll take back the patch, and check what I've done wrong at office.


> But there are probably a million potential NULL-pointer dereferences in the
> kernel.  Why single out this one?

I was interested in "Bad swap file entry" problem.

I expereiced this myself. After (quite a lot of ) "Bad swap file
entry" error log from kernel, it Oopsed three times, then kernel was
dead ( It's almost three years from now, so this was without kdump ).

I did find that three Oops happened inside page_referenced() function,
and that it was due to NULL pointer. In 2.6.24, it was only this "mm"
and one more in page_referenced_file() that did not have NULL pointer
check.

So I was really thinking about two more patches. One for "mappers"
NULL pointer check, and other one is to add msr printout when Oops or
Pank happens , to make sure that when Oops or Paniced, still my PC is
not broken.


I needed the evidence so that I don't have to worry about
broken Memory, nor broken Cache.
and I think we still do not have MSRs dumped out as
part of kdump..
# Am I wrong again??
-- 
Kenichi Okuyama
URL: http://www.dd.iij4u.or.jp/~okuyamak/

      reply	other threads:[~2008-02-01 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01  7:39 Kenichi Okuyama
2008-02-01  7:55 ` Andrew Morton
2008-02-01  8:24   ` Kenichi Okuyama
2008-02-01 10:19     ` Andrew Morton
2008-02-01 17:39       ` Kenichi Okuyama [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fd7d7a70802010939q67770628r47ca8a23fb26ca1d@mail.gmail.com \
    --to=kenichi.okuyama@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [patch] NULL pointer check for vma->vm_mm' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).