LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Laurent Pinchart <firstname.lastname@example.org>
To: Sergei Shtylyov <email@example.com>
Cc: Mike Turquette <firstname.lastname@example.org>,
Wolfram Sang <email@example.com>,
Geert Uytterhoeven <firstname.lastname@example.org>,
Stephen Boyd <email@example.com>,
Ulrich Hecht <firstname.lastname@example.org>,
Wolfram Sang <email@example.com>,
Subject: Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()
Date: Thu, 05 Feb 2015 19:19:14 +0200 [thread overview]
Message-ID: <4034374.lq5RZGeRAm@avalon> (raw)
On Thursday 05 February 2015 01:14:46 Sergei Shtylyov wrote:
> On 02/05/2015 01:04 AM, Sergei Shtylyov wrote:
> >>>>> Anyone may call clk_round_rate() with a zero rate value, so we have to
> >>>>> protect against that.
> >>>>> Signed-off-by: Geert Uytterhoeven <firstname.lastname@example.org>
> >>>> Acked-by: Wolfram Sang <email@example.com>
> >>>> I agree that this should not be fixed in the core because the fixup is
> >>>> really driver dependant.
> >>> Dunno, zero frequency seems generally insane to me.
> >> It is useful to find the lowest frequency a clock can support. Basically
> >> it is a search for the floor frequency.
> > Why not just use 1? Or are you assuming that some hardware could actually
> > support 0 Hz?
> Replying to myself: yes, this has happened to me, when I forgot to override
> the EXTAL frequency in the board .dts file (default was 0).
So it was a good thing that the driver crashed, it let you find a bug ;-)
Jokes aside, a zero frequency is the usual way to find the lowest frequency,
but I agree that there aren't many integers between 0 and 1. Mike, do you have
an opinion ?
next prev parent reply other threads:[~2015-02-05 17:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 12:27 Geert Uytterhoeven
2015-02-04 13:31 ` Sergei Shtylyov
2015-02-04 13:50 ` Laurent Pinchart
2015-02-04 17:32 ` Wolfram Sang
2015-02-04 17:45 ` Sergei Shtylyov
2015-02-04 22:01 ` Mike Turquette
2015-02-04 22:04 ` Sergei Shtylyov
2015-02-04 22:14 ` Sergei Shtylyov
2015-02-05 17:19 ` Laurent Pinchart [this message]
2015-02-05 17:46 ` Mike Turquette
2015-02-06 11:12 ` Sergei Shtylyov
2015-02-04 22:05 ` Mike Turquette
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).