LKML Archive on
help / color / mirror / Atom feed
From: "Heiko Stübner" <>
Cc: Mark Yao <>,
	David Airlie <>, Daniel Vetter <>,
	Rob Clark <>,
	Philipp Zabel <>,
	Daniel Kurtz <>,,
Subject: Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
Date: Sat, 24 Jan 2015 16:14:54 +0100	[thread overview]
Message-ID: <4077998.GJIlik9CKQ@phil> (raw)
In-Reply-To: <>

Am Donnerstag, 22. Januar 2015, 18:29:55 schrieb Mark Yao:
> drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc.
> but vop only have enable/disable mode, maybe case such bug:
>  --> DRM_DPMS_ON: power on vop
>  --> DRM_DPMS_SUSPEND: power off vop
>  --> DRM_DPMS_OFF: already power off at SUSPEND, crash
> so use a bool val is more suitable.
> another problem at vop_crtc_dpms:
>   vop_enable()->drm_vblank_on, drm_vblank_on may call vop
> enable vblank. if it happen, vblank enable would failed,
> then cause irq status error. because is_enabled value is set
> after drm_vblank_on.

This series, on a rk3288-firefly board with a sda7123 vga connector
Tested-by: Heiko Stuebner <>


      parent reply	other threads:[~2015-01-24 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 10:29 Mark Yao
2015-01-22 10:29 ` [PATCH v2 1/2] drm/rockchip: vop use is_enabled instead of dpms mode Mark Yao
2015-01-23  2:04   ` Daniel Kurtz
2015-01-22 10:29 ` [PATCH v2 2/2] drm/rockchip: vop: set vop enabled after enable iommu Mark Yao
2015-01-24 15:14 ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4077998.GJIlik9CKQ@phil \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).