LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: akpm@osdl.org, bunk@fs.tum.de
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix tlan.c for !PCI
Date: Sat, 15 May 2004 14:53:03 -0400	[thread overview]
Message-ID: <40A6670F.3050300@pobox.com> (raw)
In-Reply-To: <200405151823.i4FINj8T001262@hera.kernel.org>

Linux Kernel Mailing List wrote:
> ChangeSet 1.1691, 2004/05/15 10:23:43-07:00, akpm@osdl.org
> 
> 	[PATCH] fix tlan.c for !PCI
> 	
> 	From: Adrian Bunk <bunk@fs.tum.de>
> 	
> 	drivers/net/tlan.c: In function `tlan_remove_one':
> 	drivers/net/tlan.c:449: warning: implicit declaration of function `pci_release_regions'
> 
> 
> # This patch includes the following deltas:
> #	           ChangeSet	1.1690  -> 1.1691 
> #	  drivers/net/tlan.c	1.31    -> 1.32   
> #
> 
>  tlan.c |    4 ++++
>  1 files changed, 4 insertions(+)
> 
> 
> diff -Nru a/drivers/net/tlan.c b/drivers/net/tlan.c
> --- a/drivers/net/tlan.c	Sat May 15 11:23:50 2004
> +++ b/drivers/net/tlan.c	Sat May 15 11:23:50 2004
> @@ -446,7 +446,9 @@
>  		pci_free_consistent(priv->pciDev, priv->dmaSize, priv->dmaStorage, priv->dmaStorageDMA );
>  	}
>  
> +#ifdef CONFIG_PCI
>  	pci_release_regions(pdev);
> +#endif


Ug.  Please revert and fix it the right way.

Think about this one:  we are getting the warning inside a function that 
will only ever be called when CONFIG_PCI is defined, the PCI ->remove hook.

IMO one of two things needs to happen:
a) wrap the PCI probe functions in tlan.c with CONFIG_PCI
	or
b) create the proper wrapper in include/linux/pci.h, following 
established practice in that header



       reply	other threads:[~2004-05-15 18:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200405151823.i4FINj8T001262@hera.kernel.org>
2004-05-15 18:53 ` Jeff Garzik [this message]
2004-05-16  0:21   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A6670F.3050300@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] fix tlan.c for '\!'PCI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).