LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: shai@ftcon.com,
	Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Multiple (ICH3) IDE-controllers in a system
Date: Sat, 15 May 2004 14:57:29 -0400	[thread overview]
Message-ID: <40A66819.9040806@pobox.com> (raw)
In-Reply-To: <200405151813.i4FIDoqt029818@hera.kernel.org>

Linux Kernel Mailing List wrote:
> ChangeSet 1.1627, 2004/05/15 09:42:40-07:00, shai@ftcon.com
> 
> 	[PATCH] Multiple (ICH3) IDE-controllers in a system
> 	
> 	This fixes a problem with multiple IDE controllers in a system.
> 	
> 	The problem is that pcibios_fixups table (in arch/i386/pci/fixup.c) uses
> 	the pci_fixup_ide_trash() quirk for Intel's ICH3 (my case specifically
> 	8086:248b).  This clears any bogus BAR information set up by the BIOS.
> 	
> 	In a system which has multiple ICH3's can't use any of the IDE
> 	controllers beside the one on the first ICH3.
> 	
> 	Anyhow, the fix is to make sure pci_fixup_ide_trash resets the BARs only
> 	for first time being called, so the subsequent IDE controllers will use
> 	the BIOS BARs.  This is better than "loosing" all these IDE controllers
> 	in the case their BARs set right.

I do not think this is correct.

The programming interface register tells us if we're in legacy or native 
mode, which is what this fixup is concerned with, AFAICS.

So, the code should base its actions on whether or not the controller is 
in legacy mode, _not_ ordering.

	Jeff



       reply	other threads:[~2004-05-15 18:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200405151813.i4FIDoqt029818@hera.kernel.org>
2004-05-15 18:57 ` Jeff Garzik [this message]
2004-05-16  4:20   ` Shai Fultheim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A66819.9040806@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shai@ftcon.com \
    --subject='Re: [PATCH] Multiple (ICH3) IDE-controllers in a system' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).