LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Greg KH <greg@kroah.com>,
	akpm@osdl.org, linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [BK PATCH] USB changes for 2.6.6
Date: Sun, 16 May 2004 11:28:30 -0700	[thread overview]
Message-ID: <40A7B2CE.2050409@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0405161120420.25502@ppc970.osdl.org>

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Linus Torvalds wrote:
> 
> On Sun, 16 May 2004, David Brownell wrote:
> 
>>More like this then?  I'm not sure whether you'd prefer
>>to apply that logic to the "struct pm_info" innards too.
>>That file has multiple CONFIG_PM sections, too.
> 
> 
> I was thinking just putting it in the existing wrapper sections.

Wouldn't quite work without moving "struct pm_info" up higher
in the file.  Seems like that stuff still isn't fully sorted
out yet, this may not be the best time to start.


> The alternative is to just always have "power_state" in the "dev_pm_info", 
> especially as some versions of gcc have had bugs with empty structures 
> anyway.

That sounds like a much simpler fix.

- Dave




[-- Attachment #2: Diff --]
[-- Type: text/plain, Size: 299 bytes --]

--- 1.13/include/linux/pm.h	Thu Aug 21 11:47:27 2003
+++ edited/include/linux/pm.h	Sun May 16 11:24:38 2004
@@ -229,8 +229,8 @@
 struct device;
 
 struct dev_pm_info {
-#ifdef	CONFIG_PM
 	u32			power_state;
+#ifdef	CONFIG_PM
 	u8			* saved_state;
 	atomic_t		pm_users;
 	struct device		* pm_parent;

  reply	other threads:[~2004-05-16 18:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-14 22:45 Greg KH
2004-05-15 11:32 ` [linux-usb-devel] " Olaf Hering
2004-05-15 17:37   ` Linus Torvalds
2004-05-16 17:51     ` David Brownell
2004-05-16 18:02       ` Linus Torvalds
2004-05-16 18:14         ` David Brownell
2004-05-16 18:22           ` Linus Torvalds
2004-05-16 18:28             ` David Brownell [this message]
2004-05-16 18:31       ` Greg KH
2004-05-19 20:33     ` Erik Rigtorp
2004-05-19 20:49       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A7B2CE.2050409@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=torvalds@osdl.org \
    --subject='Re: [linux-usb-devel] [BK PATCH] USB changes for 2.6.6' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).