Re: [PATCH] remove comx drivers from tree

Re: [PATCH] remove comx drivers from tree

[Jeff Garzik]

Christoph Hellwig wrote:
> the drivers have been broken since pre-2.4.0, like referencing a symbol
> that was made procfs-internal in 2.3.x, haven't received maintainer
> updates for about the same period and MOD_{INC,DEC}_USE_COUNT usage that
> pretty much unfixable (inside warts of _horrible_ procfs abuse).
> 
> I'd say just kill them.

I have applied this to my netdev-2.6 tree, and so it should show up in 
-mm sometime.

  drivers/net/wan/Kconfig           |  113 -
  drivers/net/wan/Makefile          |    8
  drivers/net/wan/comx-hw-comx.c    | 1449 -------------------
  drivers/net/wan/comx-hw-locomx.c  |  495 ------
  drivers/net/wan/comx-hw-mixcom.c  |  959 ------------
  drivers/net/wan/comx-hw-munich.c  | 2853 
--------------------------------------
  drivers/net/wan/comx-proto-fr.c   | 1013 -------------
  drivers/net/wan/comx-proto-lapb.c |  550 -------
  drivers/net/wan/comx-proto-ppp.c  |  268 ---
  drivers/net/wan/comx.c            | 1127 ---------------
  drivers/net/wan/comx.h            |  231 ---
  drivers/net/wan/comxhw.h          |  112 -
  12 files changed, 9178 deletions(-)

Even though it is quite moldy, I want to give people some time to object 
before I remove it upstream.


BTW, I plan to remove rcpci driver at the suggestion of Pete Popov, as 
well.  It seems it's another "hasn't really worked since late 2.3.x 
days" driver, and nobody really has the hardware from this defunct 
company anymore, apparently.

	Jeff

Re: [PATCH] remove comx drivers from tree

[Krzysztof Halasa]

Jeff Garzik <jgarzik@pobox.com> writes:

> I have applied this to my netdev-2.6 tree, and so it should show up in
> -mm sometime.
>
>   drivers/net/wan/Kconfig           |  113 -
>   drivers/net/wan/Makefile          |    8
>   drivers/net/wan/comx-hw-comx.c    | 1449 -------------------
>   drivers/net/wan/comx-hw-locomx.c  |  495 ------
>   drivers/net/wan/comx-hw-mixcom.c  |  959 ------------
>   drivers/net/wan/comx-hw-munich.c  | 2853
>   --------------------------------------
>   drivers/net/wan/comx-proto-fr.c   | 1013 -------------
>   drivers/net/wan/comx-proto-lapb.c |  550 -------
>   drivers/net/wan/comx-proto-ppp.c  |  268 ---
>   drivers/net/wan/comx.c            | 1127 ---------------
>   drivers/net/wan/comx.h            |  231 ---
>   drivers/net/wan/comxhw.h          |  112 -

While obviously I don't object (we should list removed things along
with kernel version somewhere, though)... I could possibly port
the drivers to my generic HDLC code, if someone sends me the hardware
in question. Sure, I will never send it back, and it has to have V.35
or V.24 interface, so I can connect it to something.
-- 
Krzysztof Halasa, B*FH

Re: [PATCH] remove comx drivers from tree

[Jeff Garzik]

Krzysztof Halasa wrote:
> While obviously I don't object (we should list removed things along
> with kernel version somewhere, though)... I could possibly port
> the drivers to my generic HDLC code, if someone sends me the hardware
> in question. Sure, I will never send it back, and it has to have V.35
> or V.24 interface, so I can connect it to something.

Then, *bang*, it's gone :)

We can resurrect if someone appears with hardware, and cares enough to 
bring the driver back to life...  Older kernels are archived on the 
Internet forever, after all :)

	Jeff