LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Grischa Jacobs <grischa@bitclown.de>
To: Daniele Venzano <webvenza@libero.it>
Cc: Dominik Karall <dominik.karall@gmx.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Sis900 bug fixes 0/4
Date: Wed, 19 May 2004 08:57:27 +0200	[thread overview]
Message-ID: <40AB0557.9080705@bitclown.de> (raw)
In-Reply-To: <200405181539.32595.dominik.karall@gmx.net>

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

Dominik Karall wrote:
> I applied all 4 patches, but the wrong PHY transceiver is used now again.
> Here is the dmesg output:
> 
> sis900.c: v1.08.07 11/02/2003
> eth0: Unknown PHY transceiver found at address 0.
> eth0: Realtek RTL8201 PHY transceiver found at address 1.
> eth0: Unknown PHY transceiver found at address 2.
<snip>
> eth0: Unknown PHY transceiver found at address 31.
> eth0: Using transceiver found at address 31 as default
> eth0: SiS 900 PCI Fast Ethernet at 0xdc00, IRQ 19, 00:10:dc:8f:a9:ac.
> 
> greets,
> dominik
> -

Hi

I had the same messages about unknown PHY transceivers and very poor 
transfer rates. I figured that all but one of the transceivers had the 
status bit MII_STAT_FAULT set. Selecting that one solved my problems.

I posted this and the patch already a while ago but didn't get any 
response. It would be nice if a few people could check whether this 
fixes/breaks it for them.

I just checked it with 2.6.6-rc3 and the problem is still there and gets 
solved by the attached patch.


Grischa

[-- Attachment #2: patch-2.6.3-bc-sis900 --]
[-- Type: text/plain, Size: 969 bytes --]

--- linux-2.6.3/drivers/net/sis900.c	2004-03-08 20:50:05.000000000 +0100
+++ linux-2.6.3-bc/drivers/net/sis900.c	2004-02-20 14:56:00.000000000 +0100
@@ -18,6 +18,7 @@
    preliminary Rev. 1.0 Jan. 18, 1998
    http://www.sis.com.tw/support/databook.htm
 
+               Jan.  7 2004 Grischa Jacobs - Skip mii's with MII_STAT_FAULT set
    Rev 1.08.07 Nov.  2 2003 Daniele Venzano <webvenza@libero.it> add suspend/resume support
    Rev 1.08.06 Sep. 24 2002 Mufasa Yang bug fix for Tx timeout & add SiS963 support
    Rev 1.08.05 Jun.  6 2002 Mufasa Yang bug fix for read_eeprom & Tx descriptor over-boundary
@@ -541,6 +542,10 @@
 			/* the mii is not accessible, try next one */
 			continue;
 		
+		if (mii_status & MII_STAT_FAULT)
+			/* ignore mii with the fault bit set */
+			continue;
+
 		if ((mii_phy = kmalloc(sizeof(struct mii_phy), GFP_KERNEL)) == NULL) {
 			printk(KERN_INFO "Cannot allocate mem for struct mii_phy\n");
 			mii_phy = sis_priv->first_mii;

  reply	other threads:[~2004-05-19  6:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-18 12:02 Daniele Venzano
2004-05-18 12:18 ` [PATCH] Sis900 bug fixes 1/4 Daniele Venzano
2004-05-18 12:22 ` [PATCH] Sis900 bug fixes 2/4 Daniele Venzano
2004-05-18 12:30 ` [PATCH] Sis900 bug fixes 3/4 Daniele Venzano
2004-05-18 12:39   ` Daniele Venzano
2004-05-19 14:28   ` Daniele Venzano
2004-05-19 23:58     ` Jeff Garzik
2004-05-18 12:33 ` [PATCH] Sis900 bug fixes 4/4 Daniele Venzano
2004-05-18 13:39 ` [PATCH] Sis900 bug fixes 0/4 Dominik Karall
2004-05-19  6:57   ` Grischa Jacobs [this message]
2004-05-18 14:23 ` Dominik Karall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40AB0557.9080705@bitclown.de \
    --to=grischa@bitclown.de \
    --cc=dominik.karall@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=webvenza@libero.it \
    --subject='Re: [PATCH] Sis900 bug fixes 0/4' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).