LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] powerpc/mm/radix: add missing braces for single statement block
@ 2018-04-08 19:44 Mathieu Malaterre
  2018-04-08 20:34 ` Randy Dunlap
  2018-04-23 19:36 ` [PATCH v2] powerpc/mm/radix: use do/while(0) trick " Mathieu Malaterre
  0 siblings, 2 replies; 7+ messages in thread
From: Mathieu Malaterre @ 2018-04-08 19:44 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Mathieu Malaterre, Benjamin Herrenschmidt, Paul Mackerras,
	linuxppc-dev, linux-kernel

In commit 7a22d6321c3d ("powerpc/mm/radix: Update command line parsing for
disable_radix") an `if` statement was added for a possible empty body
(prom_debug).

Fix the following warning, treated as error with W=1:

  arch/powerpc/kernel/prom_init.c:656:46: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/powerpc/kernel/prom_init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 5ae153b97d0a..f0e802495530 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -652,8 +652,9 @@ static void __init early_cmdline_parse(void)
 		} else
 			prom_radix_disable = true;
 	}
-	if (prom_radix_disable)
+	if (prom_radix_disable) {
 		prom_debug("Radix disabled from cmdline\n");
+	}
 }
 
 #if defined(CONFIG_PPC_PSERIES) || defined(CONFIG_PPC_POWERNV)
-- 
2.11.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-05-25 11:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-08 19:44 [PATCH] powerpc/mm/radix: add missing braces for single statement block Mathieu Malaterre
2018-04-08 20:34 ` Randy Dunlap
2018-04-23 19:31   ` Mathieu Malaterre
2018-04-23 19:34     ` Mathieu Malaterre
2018-04-23 19:36 ` [PATCH v2] powerpc/mm/radix: use do/while(0) trick " Mathieu Malaterre
2018-04-23 21:13   ` Randy Dunlap
2018-05-25 11:41   ` [v2] " Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).