LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kyle Moffett <mrmacman_g4@mac.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Alan <alan@lxorguk.ukuu.org.uk>, Zach Brown <zab@zabbo.net>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	hch@lst.de
Subject: Re: [RFC/PATCH] revokeat/frevoke system calls V5
Date: Mon, 26 Feb 2007 16:36:05 -0500	[thread overview]
Message-ID: <4182E03E-A471-458C-98E6-4524C10BBE9A@mac.com> (raw)
In-Reply-To: <45E32AFD.2050407@zytor.com>

On Feb 26, 2007, at 13:46:21, H. Peter Anvin wrote:
> Alan wrote:
>>> I'm not sure.  Turning, for example, the statat(dir_fd, name ==  
>>> NULL)  error case into fstat(dir_fd) sounds like a way for apps,  
>>> admittedly  buggy ones, to be surprised.  Maybe libc would be  
>>> exptected to catch  the error before performing the shared system  
>>> call?
>> At that point would it not be cheaper to have two system calls,  
>> the table cost isn't very large.
>
> It's not just the table, though, you need two entry points, but  
> even that isn't really all that big either, I guess.

Well, I suppose there are multiple possibilities for consolidation:
   frevokeat(fd, "/foo/bar/baz") => normal frevokeat
   frevokeat(-1, "/foo/bar/baz")	=> revoke("/foo/bar/baz");
   frevokeat(fd, NULL)		=> frevoke(fd);

Neither of those would ordinarily be considered to do anything useful  
and for new syscalls I can't see the possibility of breaking existing  
programs.  On the other hand, it's not like we have any problems with  
the syscall tables getting too large.

Cheers,
Kyle Moffett


      reply	other threads:[~2007-02-26 21:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-28 20:06 Pekka J Enberg
2007-02-01  4:28 ` Serge E. Hallyn
2007-02-07 10:45 ` Jan Kara
2007-02-07 10:50   ` Pekka J Enberg
2007-02-07 11:05     ` Jan Kara
2007-02-26  0:33 ` Alan
2007-02-26  7:25   ` Pekka Enberg
2007-02-26  7:53     ` H. Peter Anvin
     [not found]       ` <79B7BBDC-E953-4EAE-8D32-E510DE0981FF@zabbo.net>
2007-02-26 19:41         ` Alan
2007-02-26 18:46           ` H. Peter Anvin
2007-02-26 21:36             ` Kyle Moffett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4182E03E-A471-458C-98E6-4524C10BBE9A@mac.com \
    --to=mrmacman_g4@mac.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=zab@zabbo.net \
    --subject='Re: [RFC/PATCH] revokeat/frevoke system calls V5' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).