LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Chanho Min <chanho.min@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Gunho Lee <gunho.lee@lge.com>, Juneho Choi <juno.choi@lge.com>,
Inkyu Hwang <inkyu.hwang@lge.com>
Subject: Re: [PATCH] mm: make falutaround selectable
Date: Tue, 20 Jul 2021 14:11:52 +0200 [thread overview]
Message-ID: <42adbf38-7b1a-3039-c309-3d7023fc7c6c@redhat.com> (raw)
In-Reply-To: <20210719010845.31898-1-chanho.min@lge.com>
s/falutaround/faultaround/
On 19.07.21 03:08, Chanho Min wrote:
> While faultaround can have performance gains, on certain platform it
> increases pss and causes swap to occur more frequently. This patch allows
> to unselect faultaround on platforms that do not want this behavior.
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
> ---
> mm/Kconfig | 6 ++++++
> mm/memory.c | 4 ++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 39a6a977537d..8f834386e7f3 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -750,4 +750,10 @@ config ARCH_HAS_PTE_SPECIAL
> config ARCH_HAS_HUGEPD
> bool
>
> +config FAULT_AROUND
> + bool "Enable fault around"
> + default y
> + help
> + This option enables fault around. If say N, fault_around_bytes set to PAGE_SIZE
> + and disables fault around.
> endmenu
> diff --git a/mm/memory.c b/mm/memory.c
> index 10d2e4734e82..0bb037265dda 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3500,7 +3500,11 @@ vm_fault_t finish_fault(struct vm_fault *vmf)
> }
>
> static unsigned long fault_around_bytes __read_mostly =
> +#ifdef CONFIG_FAULT_AROUND
> rounddown_pow_of_two(65536);
> +#else
> + PAGE_SIZE;
> +#endif
>
> #ifdef CONFIG_DEBUG_FS
> static int fault_around_bytes_get(void *data, u64 *val)
>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-07-20 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 1:08 Chanho Min
2021-07-19 2:31 ` Matthew Wilcox
2021-07-20 12:11 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42adbf38-7b1a-3039-c309-3d7023fc7c6c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chanho.min@lge.com \
--cc=gunho.lee@lge.com \
--cc=inkyu.hwang@lge.com \
--cc=juno.choi@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--subject='Re: [PATCH] mm: make falutaround selectable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).