LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the i2c tree
Date: Wed, 18 Aug 2021 20:28:50 +0300	[thread overview]
Message-ID: <42b3cebf-de30-5677-f98b-7a59543a3004@omp.ru> (raw)
In-Reply-To: <20210818074903.2da12b1f@canb.auug.org.au>

On 8/18/21 12:49 AM, Stephen Rothwell wrote:

[...]
> In commit
> 
>   fcc750e0f4d8 ("i2c: s3c2410: fix IRQ check")
> 
> Fixes tag
> 
>   Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> So:
> 
> Fixes: 2bbd681ba2bf ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")

   Sorry for this copypaste blunder. :-/

> Or maybe you meant:
> 
> Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")

   Yes, this one looks more correct.

   Wolfram, what should we do now?
 
MBR, Sergei

  reply	other threads:[~2021-08-18 17:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 21:49 Stephen Rothwell
2021-08-18 17:28 ` Sergey Shtylyov [this message]
2021-08-19 17:15   ` Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2021-08-25 21:44 Stephen Rothwell
2021-08-17 21:52 Stephen Rothwell
2021-08-18 18:16 ` Sergey Shtylyov
2021-08-19 17:15   ` Wolfram Sang
2020-04-27 22:28 Stephen Rothwell
2020-04-28  7:01 ` Wolfram Sang
2020-04-28  8:41   ` Stephen Rothwell
2020-04-28 10:14     ` Wolfram Sang
2019-10-24 20:07 Stephen Rothwell
2019-08-01 14:02 Stephen Rothwell
2019-08-01 20:21 ` Wolfram Sang
2019-04-23 21:55 Stephen Rothwell
2019-04-23 22:17 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42b3cebf-de30-5677-f98b-7a59543a3004@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=wsa@the-dreams.de \
    --subject='Re: linux-next: Fixes tag needs some work in the i2c tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).