LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Agrawal, Akshu" <Akshu.Agrawal@amd.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	djkurtz@chromium.org, Mark Brown <broonie@kernel.org>,
	Alexander.Deucher@amd.com, Adam.Thomson.Opensource@diasemi.com
Subject: Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems
Date: Tue, 1 May 2018 20:01:24 +0530	[thread overview]
Message-ID: <43c7939d-e30b-27eb-59e4-c0e16248dad1@amd.com> (raw)
In-Reply-To: <cb0df61c-596b-b23c-fc34-52ac4b7830e8@linux.intel.com>



On 4/30/2018 9:54 PM, Pierre-Louis Bossart wrote:
> On 4/30/18 4:23 AM, Akshu Agrawal wrote:
>> Non-dts based systems can use ACPI DSDT to pass on the mclk
>> to da7219.
>> This enables da7219 mclk to be linked to system clock.
>> Enable/Disable of the mclk is already handled in the codec so
>> platform drivers don't have to explicitly do handling of mclk.
>>
>> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
>> ---
>> v2: Fixed kbuild error
>>   include/sound/da7219.h    | 2 ++
>>   sound/soc/codecs/da7219.c | 7 ++++++-
>>   2 files changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/sound/da7219.h b/include/sound/da7219.h
>> index 1bfcb16..df7ddf4 100644
>> --- a/include/sound/da7219.h
>> +++ b/include/sound/da7219.h
>> @@ -38,6 +38,8 @@ struct da7219_pdata {
>>       const char *dai_clks_name;
>> +    const char *mclk_name;
>> +
>>       /* Mic */
>>       enum da7219_micbias_voltage micbias_lvl;
>>       enum da7219_mic_amp_in_sel mic_amp_in_sel;
>> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
>> index 980a6a8..aed68a4 100644
>> --- a/sound/soc/codecs/da7219.c
>> +++ b/sound/soc/codecs/da7219.c
>> @@ -1624,6 +1624,8 @@ static struct da7219_pdata 
>> *da7219_fw_to_pdata(struct snd_soc_component *compone
>>           dev_warn(dev, "Using default clk name: %s\n",
>>                pdata->dai_clks_name);
>> +    device_property_read_string(dev, "dlg,mclk-name", 
>> &pdata->mclk_name);
>> +
>>       if (device_property_read_u32(dev, "dlg,micbias-lvl", &of_val32) 
>> >= 0)
>>           pdata->micbias_lvl = da7219_fw_micbias_lvl(dev, of_val32);
>>       else
>> @@ -1905,7 +1907,10 @@ static int da7219_probe(struct 
>> snd_soc_component *component)
>>       da7219_handle_pdata(component);
>>       /* Check if MCLK provided */
>> -    da7219->mclk = devm_clk_get(component->dev, "mclk");
>> +    if (da7219->pdata->mclk_name)
>> +        da7219->mclk = clk_get(NULL, da7219->pdata->mclk_name);
>> +    if (!da7219->mclk)
>> +        da7219->mclk = devm_clk_get(component->dev, "mclk");
> 
> this looks weird, why are you using different clk functions depending on 
> the existence of a _DSD property? Why not just change the name and keep 
> the same flow, e.g something like
> 
> if(!da7219->pdata->mclk_name)
>      da7219->pdata->mclk_name = "mclk";
> da7219->mclk = devm_clk_get(component->dev, da7219->pdata->mclk_name);
> 
> 

We can't use devm_clk_get as the value of dev argument has to be NULL, 
which can not be used with devm_clk_get.
System clock which are linked to mclk are registered by a separate ACPI 
device. And this exposing of DSD property is for all those platforms 
which are non-dts based.

>>       if (IS_ERR(da7219->mclk)) {
>>           if (PTR_ERR(da7219->mclk) != -ENOENT) {
>>               ret = PTR_ERR(da7219->mclk);
>>
> 

  reply	other threads:[~2018-05-01 14:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  9:23 Akshu Agrawal
2018-04-30 16:24 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-01 14:31   ` Agrawal, Akshu [this message]
2018-05-01 15:59     ` Pierre-Louis Bossart
2018-04-30 19:05 ` Adam Thomson
2018-05-01 14:40   ` Agrawal, Akshu
2018-05-01 20:50   ` Mark Brown
2018-05-02 10:13     ` Adam Thomson
2018-05-03  1:39       ` Mark Brown
2018-05-03  8:20         ` [alsa-devel] " Adam Thomson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43c7939d-e30b-27eb-59e4-c0e16248dad1@amd.com \
    --to=akshu.agrawal@amd.com \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=support.opensource@diasemi.com \
    --cc=tiwai@suse.com \
    --subject='Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).