LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Suwan Kim <suwan.kim027@gmail.com>,
	valentina.manea.m@gmail.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	shuah <shuah@kernel.org>
Subject: Re: [PATCH 1/2] usbip: Remove repeated setting of hcd->state in vhci_bus_suspend()
Date: Mon, 6 May 2019 09:13:02 -0600	[thread overview]
Message-ID: <440389ab-62c3-7bc2-0e9b-0b302a88c929@kernel.org> (raw)
In-Reply-To: <20190506125550.7826-1-suwan.kim027@gmail.com>

On 5/6/19 6:55 AM, Suwan Kim wrote:
> When hcd suspends execution, hcd_bus_suspend() calls vhci_bus_suspend()
> which sets hcd->state as HC_STATE_SUSPENDED. But after calling
> vhci_bus_suspend(), hcd_bus_suspend() also sets hcd->state as
> HC_STATE_SUSPENDED.
> So, setting hcd->state in vhci_hcd_suspend() is unnecessary.
> 
> Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
> ---
>   drivers/usb/usbip/vhci_hcd.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 667d9c0ec905..e6f378d00fb6 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1238,10 +1238,6 @@ static int vhci_bus_suspend(struct usb_hcd *hcd)
>   
>   	dev_dbg(&hcd->self.root_hub->dev, "%s\n", __func__);
>   
> -	spin_lock_irqsave(&vhci->lock, flags);
> -	hcd->state = HC_STATE_SUSPENDED;
> -	spin_unlock_irqrestore(&vhci->lock, flags);
> -
>   	return 0;
>   }
>   
> 

Tell me more about why you think this change is needed? How did you test
this change?

thanks,
-- Shuah

  parent reply	other threads:[~2019-05-06 15:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 12:55 Suwan Kim
2019-05-06 12:55 ` [PATCH 2/2] usbip: Remove repeated setting of hcd->state in vhci_bus_resume() Suwan Kim
2019-05-06 15:16   ` shuah
2019-05-06 15:13 ` shuah [this message]
2019-05-07 15:49   ` [PATCH 1/2] usbip: Remove repeated setting of hcd->state in vhci_bus_suspend() Suwan Kim
2019-05-08 17:28     ` shuah
2019-05-14 11:58       ` Suwan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440389ab-62c3-7bc2-0e9b-0b302a88c929@kernel.org \
    --to=shuah@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=suwan.kim027@gmail.com \
    --cc=valentina.manea.m@gmail.com \
    --subject='Re: [PATCH 1/2] usbip: Remove repeated setting of hcd->state in vhci_bus_suspend()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).