LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alex Dubov <oakad@yahoo.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller
Date: Wed, 5 Mar 2008 18:29:43 -0800 (PST) [thread overview]
Message-ID: <446410.44539.qm@web36709.mail.mud.yahoo.com> (raw)
--- Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 5 Mar 2008 03:02:28 +1100
> oakad@exemail.com.au wrote:
>
> > +static void jmb38x_ms_reset(struct jmb38x_ms_host *host)
> > +{
> > + unsigned int host_ctl = readl(host->addr + HOST_CONTROL);
> > +
> > + writel(host_ctl | HOST_CONTROL_RESET_REQ | HOST_CONTROL_RESET,
> > + host->addr + HOST_CONTROL);
> > +
> > + while (HOST_CONTROL_RESET_REQ
> > + & (host_ctl = readl(host->addr + HOST_CONTROL))) {
>
> host_ctl is written to but is not used again.
It was supposed to be used in the dev_dbg printout.
>
> > + ndelay(100);
> > + dev_dbg(&host->chip->pdev->dev, "reset\n");
> > + }
> > +
> > + writel(INT_STATUS_ALL, host->addr + INT_STATUS_ENABLE);
> > + writel(INT_STATUS_ALL, host->addr + INT_SIGNAL_ENABLE);
> > +
> > + dev_dbg(&host->chip->pdev->dev, "reset\n");
> > +}
>
____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
next reply other threads:[~2008-03-06 2:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 2:29 Alex Dubov [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-04 16:02 MemoryStick driver updates oakad
2008-03-04 16:02 ` [PATCH 01/11] memstick: introduce correct definitions in the header oakad
2008-03-04 16:02 ` [PATCH 02/11] memstick: add memstick_suspend/resume_host methods oakad
2008-03-04 16:02 ` [PATCH 03/11] memstick: make sure number of command retries is exactly as specified oakad
2008-03-04 16:02 ` [PATCH 04/11] memstick: drop DRIVER_VERSION numbers as meaningless oakad
2008-03-04 16:02 ` [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code oakad
2008-03-04 16:02 ` [PATCH 06/11] tifm: fix memorystick host initialization code oakad
2008-03-04 16:02 ` [PATCH 07/11] tifm: clear interrupt mask bits before setting them on adapter init oakad
2008-03-04 16:02 ` [PATCH 08/11] memstick: add support for decoding "specfile" media attributes oakad
2008-03-04 16:02 ` [PATCH 09/11] memstick: fix parsing of "assembly_date" attribute field oakad
2008-03-04 16:02 ` [PATCH 10/11] memstick: try harder to recover from unsuccessful interface mode switch oakad
2008-03-04 16:02 ` [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller oakad
2008-03-05 23:17 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446410.44539.qm@web36709.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).