LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Grzegorz Kulewski <kangur@polcom.net>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@osdl.org
Subject: Re: [PATCH] linux/magic.h for magic numbers
Date: Sat, 09 Sep 2006 09:44:15 -0400	[thread overview]
Message-ID: <4502C52F.9080900@garzik.org> (raw)
In-Reply-To: <20060909133334.GB17085@uranus.ravnborg.org>

Sam Ravnborg wrote:
> But do we want one common set of magic numbers or do we try to divide it
> up per subssystem. The lattter approach are used for many other purposes
> so why not for magics too?
> Or in other word magic.h => fs_magic.h

It's a fair question.  I would say, let need dictate the rename.

linux/poison.h covers many subsystems.  And even across the entire 
kernel, we don't often add magic numbers...

	Jeff



  reply	other threads:[~2006-09-09 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-09 11:02 Jeff Garzik
2006-09-09 12:58 ` Grzegorz Kulewski
2006-09-09 13:24   ` Jeff Garzik
2006-09-09 13:33     ` Sam Ravnborg
2006-09-09 13:44       ` Jeff Garzik [this message]
2006-09-12  8:22 ` Ian Kent
2006-09-12  9:33   ` Jan Engelhardt
2006-09-12 12:30   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4502C52F.9080900@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=kangur@polcom.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --subject='Re: [PATCH] linux/magic.h for magic numbers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).