LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@nvidia.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
Vlad Buslov <vladbu@nvidia.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
"natechancellor@gmail.com" <natechancellor@gmail.com>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ndesaulniers@google.com" <ndesaulniers@google.com>,
"naresh.kamboju@linaro.org" <naresh.kamboju@linaro.org>
Subject: Re: bridge.c:157:11: error: variable 'err' is used uninitialized whenever 'if' condition is false
Date: Tue, 7 Sep 2021 20:34:39 +0000 [thread overview]
Message-ID: <452cbfe701b1373c871ba584ef4b249a59d8edd6.camel@nvidia.com> (raw)
In-Reply-To: <ygnhk0jtwqs6.fsf@nvidia.com>
On Mon, 2021-09-06 at 20:35 +0300, Vlad Buslov wrote:
> On Mon 06 Sep 2021 at 19:39, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> > On Mon, Sep 6, 2021 at 2:11 AM Naresh Kamboju
> > <naresh.kamboju@linaro.org> wrote:
> > >
> > > drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c:157:11:
> > > error:
> > > variable 'err' is used uninitialized whenever 'if' condition is
> > > false
> >
> > That compiler warning (now error) seems to be entirely valid.
>
> I agree, this is a real issue. It had been reported before and my fix
> for it was submitted by Saeed last week but wasn't accepted since it
> was
> part of larger series that also included features and net-next had
> already been closed by that time. As far as I understand it is
> pending
> submission to net as part of series of bug fixes. Sorry for the
> delay.
>
>
yes, the fix will be submitted shortly to net/rc branch.
due to bad net-next timing the patch couldn't make it to -next.
prev parent reply other threads:[~2021-09-07 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 9:10 Naresh Kamboju
2021-09-06 16:39 ` Linus Torvalds
2021-09-06 17:35 ` Vlad Buslov
2021-09-07 20:34 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452cbfe701b1373c871ba584ef4b249a59d8edd6.camel@nvidia.com \
--to=saeedm@nvidia.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vladbu@nvidia.com \
--subject='Re: bridge.c:157:11: error: variable '\''err'\'' is used uninitialized whenever '\''if'\'' condition is false' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).