LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters
Date: Wed, 04 Aug 2021 11:00:25 +0200	[thread overview]
Message-ID: <4550286.edLFIWPnRF@localhost.localdomain> (raw)
In-Reply-To: <20210804075930.GD1931@kadam>

On Wednesday, August 4, 2021 9:59:30 AM CEST Dan Carpenter wrote:
> On Fri, Jul 30, 2021 at 08:14:52PM +0200, Fabio M. De Francesco wrote:
> >  static inline void __nat25_generate_ipx_network_addr_with_socket(unsigned 
char
> >  *networkAddr,> 
> > -				unsigned int *ipxNetAddr, 
unsigned short *ipxSocketAddr)
> >
> > [...]
> >
> Here is another bug which was obscured/caused by the union.
> 
> 	addr.f0 = be16_to_cpu(*ipxSocketAddr);
> 
> The addr.f0 variable is an int.  On big endian systems only the last two
> bytes are set:
> 
> 	memcpy(networkAddr+5, addr.f1, 2);
> 
> So this is the equivalent of:
> 
> 	memset(networkAddr+5, 0, 2);
> 
> regards,
> dan carpenter

Dear Dan,

Thanks, for pointing me to one more bug I introduced with this patch. The most 
of them were due to me forgetting that memcpy() takes pointers. For some 
reason I was thinking it takes values, therefore I put in it a lot of 
unnecessary and faulty complications.

I'd like to make a new patch, a better one (I hope), without unneeded unions 
without the other wrong lines that are in the commit 56febcc2595e.

However, I see that Greg hasn't yet had the time to revert the above commit, 
so I don't know how to make a new patch.

I mean: I could (1) either wait for Greg to revert it and then to fix the 
sparse warnings with a new patch, or (2) I could fix the bugs I made in 
56febcc2595e without having it reverted. I would prefer the solution (2) with 
a "Fixes: 56febcc2595e (...)" and a "Reported-by: Dan Carpenter <...>" tags.

What is the best solution between the two above?

Thanks,

Fabio




  reply	other threads:[~2021-08-04  9:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 18:14 Fabio M. De Francesco
2021-08-02 14:05 ` Dan Carpenter
2021-08-02 14:26   ` Fabio M. De Francesco
2021-08-02 15:21     ` Fabio M. De Francesco
2021-08-03  8:15   ` Fabio M. De Francesco
2021-08-03 14:01     ` Dan Carpenter
2021-08-04  7:59 ` Dan Carpenter
2021-08-04  9:00   ` Fabio M. De Francesco [this message]
2021-08-04  9:58     ` Dan Carpenter
2021-08-04 11:29       ` Fabio M. De Francesco
2021-08-04 12:00         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4550286.edLFIWPnRF@localhost.localdomain \
    --to=fmdefrancesco@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --subject='Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).