LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: broonie@kernel.org
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Barry Song <Baohua.Song@csr.com>
Subject: [PATCH] spi: sirf: add reset controller dependency
Date: Wed, 18 Feb 2015 16:29:10 +0100 [thread overview]
Message-ID: <4553005.HBquOfbqXe@wuerfel> (raw)
The sirf spi driver only builds correctly if the reset controller
framework is available, otherwise we get an error:
drivers/spi/spi-sirf.c: In function 'spi_sirfsoc_probe':
drivers/spi/spi-sirf.c:651:2: error: implicit declaration of function 'device_reset' [-Werror=implicit-function-declaration]
The adds a dependency in Kconfig to prevent it from being selected
if the resets are not available.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8509c55fcb51 ("spi: sirf: reset SPI controller in init stage")
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index ab8dfbef6f1b..b3ae90e4c03c 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -507,6 +507,7 @@ config SPI_SH_HSPI
config SPI_SIRF
tristate "CSR SiRFprimaII SPI controller"
depends on SIRF_DMA
+ depends on RESET_CONTROLLER
select SPI_BITBANG
help
SPI driver for CSR SiRFprimaII SoCs
next reply other threads:[~2015-02-18 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 15:29 Arnd Bergmann [this message]
2015-02-19 9:41 ` Mark Brown
2015-02-19 15:01 ` Arnd Bergmann
2015-02-21 9:44 ` Mark Brown
2015-02-23 22:01 ` Arnd Bergmann
2015-02-24 7:50 ` Mark Brown
2015-02-24 10:27 ` Arnd Bergmann
2015-02-24 10:56 ` Chen-Yu Tsai
2015-02-24 13:34 ` Arnd Bergmann
2015-02-24 13:36 ` Chen-Yu Tsai
2015-02-24 13:02 ` Arnd Bergmann
2015-02-24 14:27 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4553005.HBquOfbqXe@wuerfel \
--to=arnd@arndb.de \
--cc=Baohua.Song@csr.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--subject='Re: [PATCH] spi: sirf: add reset controller dependency' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).