From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbeCXO0p (ORCPT ); Sat, 24 Mar 2018 10:26:45 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:43851 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbeCXO0m (ORCPT ); Sat, 24 Mar 2018 10:26:42 -0400 X-Google-Smtp-Source: AG47ELttE8B3Oj5dk68RXjzaqGQbHi1PTBBTqsfQ3TaSejPAxy0Ab3pVsPEaJd8+FzEPbn2yu32S4Q== Subject: Re: [bug, bisected] pfifo_fast causes packet reordering To: Jakob Unterwurzacher , Dave Taht Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , "linux-can@vger.kernel.org" , Martin Elshuber References: <946dbe16-a2eb-eca8-8069-468859ccc78d@theobroma-systems.com> <95844480-d020-9000-53ef-0da8b965ce6e@gmail.com> <3a959e50-8656-5d9c-97b9-227d733948f8@theobroma-systems.com> <5aeb54ba-2d96-4ab5-53c4-2d3691be7acc@gmail.com> <340a6c54-6031-5522-98f5-eafdd3a37a38@theobroma-systems.com> <00cc2d41-6861-9a9c-603f-ba8013b2e2ce@theobroma-systems.com> <4e33aae4-9e87-22b4-7f09-008183ea553a@gmail.com> <983427eb-2e25-f201-c953-4cff22569deb@theobroma-systems.com> <9cf7a278-7269-9571-c378-ad98a5cd281b@theobroma-systems.com> From: John Fastabend Message-ID: <456f45a6-43b5-2ee5-bdcc-859f8d7d4a9a@gmail.com> Date: Sat, 24 Mar 2018 07:26:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <9cf7a278-7269-9571-c378-ad98a5cd281b@theobroma-systems.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22/2018 03:16 AM, Jakob Unterwurzacher wrote: > On 21.03.18 21:52, John Fastabend wrote: >> Can you try this, >> >> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h >> index d4907b5..1e596bd 100644 >> --- a/include/net/sch_generic.h >> +++ b/include/net/sch_generic.h >> @@ -30,6 +30,7 @@ struct qdisc_rate_table { >>   enum qdisc_state_t { >>          __QDISC_STATE_SCHED, >>          __QDISC_STATE_DEACTIVATED, >> +       __QDISC_STATE_RUNNING, >>   }; >> [...] > > Tested, looks good. No OOO observed, no side effects observed, iperf > numbers on Gigabit Ethernet look the same. > > Thanks, > Jakob Thanks, I'll send out an official patch today. .John